April 2017 - Koha-bugs - lists.koha-community.org

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14791 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 [Bug 14791] Automatically attempt to resend failed notices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13995 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62615|0 |1 is obsolete| | --- Comment #10 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62622&action=ed… Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers Sometimes notices keep failing due to various reasons. One common problem is network connection failures. Because of this, the notices go into 'failed' status without another attempt for sending. This is very problematic, because we have to not only monitor the failed messages but also resend them manually. The purpose of this patch is to move us into more automated way of handling delivery failures. This patch enables us to handle exceptions in SMS messaging. The main idea is to throw an exception from SMS::Send driver in case of a failure. The exception will be caught by C4::SMS and from here it will be forwarded to C4::Letters where instead of automatically setting the message into 'failed' status, we now can do as we wish with various exceptions. As an example I have caught Koha::Exceptions::ConnectionFailed in C4::Letters::_send_message_by_sms(). When we catch the said exception, we simply leave the message in 'pending' status. This way it will be resent whenever process_message_queue.pl is executed again. sub send_sms { #.....your implementation..... # Throw an exception in case of a connection error # $connError can be for example: ($curl->{'retcode'} == 6) # cURL code 6: CURLE_COULDNT_RESOLVE_HOST if ($connError){ Koha::Exceptions::ConnectionFailed->throw(error => "Connection failed"); } } To test: 1. prove t/db_dependent/Letters.t Also testable with your own implementation of SMSSendDriver. 1. Have/create some pending sms messages into message_queue 2. Go to Patrons -> Notices 3. Observe that the your message is in pending status 4. Run misc/cronjob/process_message_queue.pl 5. Observe that the message is no longer pending 6. Add Koha::Exceptions::ConnectionFailed->throw(error => "Connection failed"); to your SMS::Send driver send_sms. 7. Set your message back to pending status 8. Run misc/cronjob/process_message_queue.pl 9. Observe that your message is back in pending status 10. Observe it also has the following delivery note: "Connection failed. Attempting to resend." -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12074] Filter duplicates when adding a full batch from a staged file
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12074 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 [Bug 18482] False duplicates detected on adding a batch from a stage file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS:: Send drivers
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18457 [Bug 18457] process_message_queue.pl will die if a patron has no sms_provider_id set but sms via email is enabled for that patron -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15503] Grab Item Information from Order Files
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468 [Bug 18468] When adding from a staged file order discounts are not passed into C4::Acquisitions::populate_order_with_prices -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18461 [Bug 18461] Internal server error while approving OPAC-edited patron attributes containing umlauts (äöü) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18466 [Bug 18466] No article requests breaks the opac-user-views block -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14791] Automatically attempt to resend failed notices
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14791 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42698|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 62615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62615&action=ed… Bug 14791: Resend failed notices - Add Koha::Exceptions to SMS::Send drivers Sometimes notices keep failing due to various reasons. One common problem is network connection failures. Because of this, the notices go into 'failed' status without another attempt for sending. This is very problematic, because we have to not only monitor the failed messages but also resend them manually. The purpose of this patch is to move us into more automated way of handling delivery failures. This patch enables us to handle exceptions in SMS messaging. The main idea is to throw an exception from SMS::Send driver in case of a failure. The exception will be caught by C4::SMS and from here it will be forwarded to C4::Letters where instead of automatically setting the message into 'failed' status, we now can do as we wish with various exceptions. As an example I have caught Koha::Exception::ConnectionFailed in C4::Letters::_send_message_by_sms(). When we catch the said exception, we simply leave the message in 'pending' status. This way it will be resent whenever process_message_queue.pl is executed again. There are multiple other reasons of failure where Exceptions will come in handy. For example the SMS Gateway provider may return some errors at request, and with this patch we will be able to handle them better. Below is a short example for making your SMS::Send driver throw an exception in case of a connection failure in SMS/Send/MyDriver/Driver.pm. _______________________________________________________________ use Koha::Exception::ConnectionFailed; sub send_sms { #.....your implementation..... # Throw an exception in case of a connection error # $connError can be for example: ($curl->{'retcode'} == 6) # cURL code 6: CURLE_COULDNT_RESOLVE_HOST if ($connError){ Koha::Exception::ConnectionFailed->throw(error => "Connection failed"); } #.....your implementation..... } _______________________________________________________________ prerequisites: -2. Set system preference SMSSendDriver to Example::ExceptionExample -1. Enable system preference EnhancedMessagingPreferences To test: 1. Have/create some pending sms messages into message_queue 2. Go to Patrons -> Notices 3. Observe that the your message is in pending status 4. Apply patch 5. Run misc/cronjob/process_message_queue.pl 6. Observe that your message is still in pending status You can also test it with your own implementation of SMSSendDriver. What you need to do is follow the example mentioned earlier to make send_sms() subroutine throw Koha::Exception::ConnectionFailed in case of a connection failure. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 24 Apr '17

24 Apr '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #55 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Can you please camel case your module names for readability ( e.g. Koha::StockRotationItem instead of Koha::Stockrotationitem )? Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0