May 2017 - Koha-bugs - lists.koha-community.org

[Bug 18554] New: Adjust a few typos including responsability
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18554 Bug ID: 18554 Summary: Adjust a few typos including responsability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: nengard(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 18400] New: Noisy warns in opac-search.pl during itemtype sorting
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18400 Bug ID: 18400 Summary: Noisy warns in opac-search.pl during itemtype sorting Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Cannot reliably recreate, but seeing in 3.22 - 16.11 when searching in opac we get lots of: opac-search.pl: Use of uninitialized value in string comparison (cmp) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl Tracing the error it seems $itemtype can be corrupted and has keys added like this (when dumped): $VAR1 = 'MICROFORM'; $VAR2 = '1VOLTREAT'; $VAR3 = 'HASH(0x954d948)'; $VAR4 = 'HASH(0x9083428)'; etc. This filled a disk on one of our servers -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 18634] New: Missing empty line at end of opac.pref
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Bug ID: 18634 Summary: Missing empty line at end of opac.pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org The subject line says it all. When this line is missing, all Payment(PayPal) sysprefs don't show up in translated pages. -- You are receiving this mail because: You are watching all bug changes.

1 44

[Bug 18214] New: Cannot edit list permissions of a private list
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18214 Bug ID: 18214 Summary: Cannot edit list permissions of a private list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl If you have disabled the pref OpacAllowPublicListCreation, your users are not able to edit the list permissions for private/shared lists. For a private list they may only be theoretically relevant, but for a shared list they are relevant. Since we do not always know the history of a list (has it been public or shared, does it contains entries from other users) and therefore permissions are even relevant for a currently private list, we should just allow editing these permissions. Trivial change in opac-shelves template. No need to change staff side. -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 18697] New: Fix date calculations for day/week frequencies in Serials
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18697 Bug ID: 18697 Summary: Fix date calculations for day/week frequencies in Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com See also bug 18356 and 18607. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 18607] New: Fix date calculations for monthly frequencies in Serials
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18607 Bug ID: 18607 Summary: Fix date calculations for monthly frequencies in Serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Similar to bug 18356 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 21

[Bug 18356] New: Prediction pattern wrong, skips years, for some year based frequencies
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356 Bug ID: 18356 Summary: Prediction pattern wrong, skips years, for some year based frequencies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com To reproduce: Set a frequency with: Unit: Year Issues per unit: 9 Units per issue: 1 OR Unit: Year Issues per unit: 12 Units per issue: 1 Notice the prediction pattern works for about 1 cycle, then crossed to next year, then jumps a year: No. 82 03/01/2017 No. 83 03/31/2017 No. 84 04/30/2017 No. 85 05/30/2017 No. 86 06/29/2017 No. 87 07/29/2017 No. 88 08/28/2017 No. 89 09/27/2017 No. 90 10/27/2017 No. 91 11/26/2017 No. 92 12/26/2017 No. 93 01/25/2018 No. 94 03/01/2019 WRONG!! No. 95 03/31/2019 No. 96 04/30/2019 No. 97 05/30/2019 No. 98 06/29/2019 No. 99 07/29/2019 No. 100 08/28/2019 No. 101 09/27/2019 No. 102 10/27/2019 No. 103 11/26/2019 No. 104 12/26/2019 No. 105 01/25/2020 No. 106 03/01/2021 WRONG!! Seems to be a problem in some cases when we call: ($year) = Add_Delta_YM($year,$month,$day, $freqdata->{"unitsperissue"},0); As this call will always add a year, it ends up in: /usr/share/perl5/Date/Calc/PP.pm sub DateCalc_add_year_month Where we add $year + $freqdata->{"unitsperissue"} and return 1 if it is greater than 1 Suspecting the pass of $freqdata->{"unitsperissue"} is incorrect -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 17181] New: Patron card creator replaces existing image when uploading image with same name
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17181 Bug ID: 17181 Summary: Patron card creator replaces existing image when uploading image with same name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: aleishaamohia(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org If you try to upload an image into Patron Card Creator with the same file name as an image that has already been upload, the original image gets replaced, without any warning. There should be some kind of warning before replacing, i.e. "The name "filename" already exists. Upload and replace image or cancel upload?" -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 18699] New: Get rid of %%] in translation for currency.tt
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18699 Bug ID: 18699 Summary: Get rid of %%] in translation for currency.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr Translation for edi_accounts.tt exposes: [%% transport_types = [ 'FTP', 'SFTP', 'FILE' ] %%] Translators should not be confronted with such code internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 17710] New: C4::Matcher::get_matches and C4::ImportBatch:: GetBestRecordMatch should use same logic
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17710 Bug ID: 17710 Summary: C4::Matcher::get_matches and C4::ImportBatch::GetBestRecordMatch should use same logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org C4::Matcher::get_matches sorts its rows in descending order using score, while C4::ImportBatch::GetBestRecordMatch sorts its rows in descending order using score and record id. To get the best record match, C4::ImportBatch::GetBestRecordMatch takes the top result. By contrast, C4::Matcher::get_matches could easily return different rows in the top position if there are multiple rows with the same score, since its array is populated using a hash where order doesn't matter. It's an easy enough fix, although I will admit to finding the solution on StackOverflow: "Since <=> and cmp return 0 to indicate equality, and that's false, and because Perl's logical Boolean operators return the deciding value instead of just 0 or 1, sorting by multiple keys is as easy as stringing multiple comparisons together with or or ||" http://stackoverflow.com/questions/10395383/sorting-an-array-of-hash-by-mul… -- You are receiving this mail because: You are watching all bug changes.

1 12