May 2017 - Koha-bugs - lists.koha-community.org

[Bug 18682] New: Translatability: Get rid of [ %% in translation for av-build-dropbox.inc
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18682 Bug ID: 18682 Summary: Translatability: Get rid of [%% in translation for av-build-dropbox.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr File av-build-dropbox.inc has linebreaks inside template directives. This exposes the following intrenals (comments and tt code) to translations: %s [%%# Parameters: name: the name of the select element category: the authorised value category default: the default authorised value to select class: the CSS class of the select element size: the size to use for the input (generated if the authorised value category does not exist). all: add a "All" entry %%] %s [%% DEFAULT class = '' size = 20 %%] %s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 18641] New: Translatability: Get rid of template directives in translations for *reserves.tt files
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18641 Bug ID: 18641 Summary: Translatability: Get rid of template directives in translations for *reserves.tt files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 18695] New: Translatability: Get rid of [ %% INCLUDE in translation for circulation.tt
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18695 Bug ID: 18695 Summary: Translatability: Get rid of [%% INCLUDE in translation for circulation.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr The file circ/circulation.tt exposes the following line to translation: %s %s [%% INCLUDE 'blocked-fines.inc' fines = chargesamount %%] %s %s Translators should not be confronted with code internals. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11

[Bug 18648] New: Get rid of tt directives in translation for macles.tt
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18648 Bug ID: 18648 Summary: Get rid of tt directives in translation for macles.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/macles.tt contains template directives inside a div tag: <span title="[% FOREACH lib IN cell.libs %][% lib.lib |html %] - [% END %]"> This is exposed in translation tool. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 29

[Bug 18700] New: Fix ungrammatical sentence
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18700 Bug ID: 18700 Summary: Fix ungrammatical sentence Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com admin-home has an ungrammatical sentence referring to "datas". In English data can be treated as a plural (sing datum) or a mass noun but it is not a count noun. correct the grammar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 18704] New: File types limit in tools/ export.pl is causing issues with csv files generated by MS/Excel
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18704 Bug ID: 18704 Summary: File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org It seems that a file saved as csv from Excel sometimes has the mime type: application/vnd.ms-excel Bug 18087 limited the file types to: text/csv text/plain Users are complaining of a loss of functionality here. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 17974] New: Add the Koha::Item->biblio method
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974 Bug ID: 17974 Summary: Add the Koha::Item->biblio method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 18482] New: False duplicates detected on adding a batch from a stage file
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18482 Bug ID: 18482 Summary: False duplicates detected on adding a batch from a stage file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org Created attachment 62572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62572&action=ed… False duplicates detected on adding a batch from a stage file When adding a batch from a stage file with defaut matching on title/author, if a duplicate is detected, all following records treated in the batch are discarded from import even if they are not duplicates. Checking for duplicate now lies on duplinbatch value that is not reset at each loop (In the initial commit, discarding record was directly tight to FindDuplicate return). So from the point when duplinbatch is defined, all the following biblios are discarded as duplicate whatever FindDuplicate return is. This patch adds a distinct flag. Test plan : You need the 2 test attached files TestFile1.mrc and TestFile2.elc (TestFile1 includes only the title "Amilec ou La graine d'hommes" that is also included in TestFile2). To save them, right click on bugzilla link and do 'Save target as'. 1) go to “Stage MARC records for import” page, upload TestFile1, select iso 5426 encoding and stage it for Import. 2) Click again 'Stage MARC records' button and do the same for TestFile2.elc 3) Go to acquisitions module, enter a vendor name and create a new basket. 4) From your basket, click 'Add to basket', then in the “Add order to basket window/block” choose 'From a staged file'. 5) Then click ‘Add orders' button on File1. 6) Leave default matching on Title/Author, tick the title, add a location in second tag and fund in third tag and Save. 7) Make sure that the new record is indexed (depending to your indexing system and test platform). 8) Redo step 4 and step 5 this time on TestFile2. 9) Leave default matching on Title/Author, select all titles, add a location in second tag, a fund in third tag and Save. 10) A warning is displayed saying that no records have been imported because they all match an existing record. The “Import all” block is not any more visible. 11) Apply the patch 12) Refresh 'Add orders from' page (File2) and redo step 9 13) You are redirected to the basket page : a warning is displayed to tell you that some duplicates have been found and skipped. There's a link on the warning throughout you can go back to the list of remaining records and treat them individually if necesary. 14) Click the link : you fall upon the only title that is a very duplicate (record of TestFile1). 15) Be happy 16) Sign off Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 18512] New: GetAuthorisedValues.GetByCode Template plguin should return code ( not empty string) if value not found
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18512 Bug ID: 18512 Summary: GetAuthorisedValues.GetByCode Template plguin should return code (not empty string) if value not found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 18611] New: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch.
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '17

31 Jul '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18611 Bug ID: 18611 Summary: Create labels action fails in manage-marc-import.pl if an item has been deleted from the import batch. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On the manage marc import screen, clicking Import Batch on a batch containing a deleted item gives the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details.", and creates an empty PDF file. To replicate: 1) Import a marc record including items. 2) Delete one of the items in the batch. 3) In Home › Tools › Manage staged MARC records, click '(Create label batch)' on the batch in question. 4) This will show the message "Error attempting to create label batch. Please ask your system administrator to check the log for more details." The logs in /var/log/koha/INSTANCE/intranet-error.log will look like this: 123456 [Mon May 15 11:14:21.848772 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) [for Statement "INSERT INTO creator_batches (batch_id, item_number, branch_code, creator) VALUES (?,?,?,?);" with ParamValues: 0=164, 1=123456, 2="APL", 3='Labels'] at /usr/share/koha/lib/C4/Creators/Batch.pm line 69., referer: http://asdfsadf... [Mon May 15 11:14:21.849012 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: Database returned the following error on attempted INSERT: Cannot add or update a child row: a foreign key constraint fails (`koha_xyzzy`.`creator_batches`, CONSTRAINT `creator_batches_ibfk_3` FOREIGN KEY (`item_number`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE) at /usr/share/koha/lib/C4/Creators/Batch.pm line 71., referer: http://asdfsadf... [Mon May 15 11:14:21.849147 2017] [cgi:error] [pid 15635] [client a.b.c.d:xxxxx] AH01215: [Mon May 15 11:14:21 2017] manage-marc-import.pl: create_labelbatch_from_importbatch() : Error attempting to add item #123456 of import batch #11048 to label batch. at /usr/share/koha/intranet/cgi-bin/tools/manage-marc-import.pl line 198., referer: http://asdfsadf ... I think we need to have /usr/share/koha/lib/C4/Creators/Batch.pm exclude items where the itemnumber is null. -- You are receiving this mail because: You are watching all bug changes.

1 18