May 2017 - Koha-bugs - lists.koha-community.org

[Bug 12349] patron name on suggestions should be linked
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 63357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63357&action=ed… Bug 18154 - Show card number in detailled suggestion pages This patch modifies the main suggestion management page to link patron names to their details rather than with a "mailto:" link. This patch also includes the following changes: - A fix for Bug 18154, Show card number in suggestion details view. - Changes for brevity to labels in the suggestion details & edit view. - Addition of the datepicker class to date fields in the suggestion edit view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12349] patron name on suggestions should be linked
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12349 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 3534] Patron quick add form
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17847] New: Move C4::Koha::GetAuthvalueDropbox to Koha:: AuthorisedValues
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17847 Bug ID: 17847 Summary: Move C4::Koha::GetAuthvalueDropbox to Koha::AuthorisedValues Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 18568] New: blog
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18568 Bug ID: 18568 Summary: blog Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Continuous Integration Assignee: tomascohen(a)gmail.com Reporter: hamidarmy(a)gmail.com http://parsablog.com/ -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #46 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63354&action=ed… Bug 7317: Invoke `handle_commit_maybe` on custom capabilities. * ill/ill-requests.pl: Invoke `handle_commit_maybe` on custom capabilities in our controller to handle 'commit' stage. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17781] New: Improper branchcode set during renewal
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17781 Bug ID: 17781 Summary: Improper branchcode set during renewal Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com For no discernable reason, when AddIssue calls AddRenewal, it passes the branchcode generated from _GetCircControlBranch. Assume _GetCircControlBranch is set to return items.homebranch. So: 1) If an item owned by LibraryA is checked out at LibraryB, the statistic line branchcode will be LibraryB 2) If an item is renewed via the ajax datatables renewal function, the statistic line branchcode will be LibraryB 3) If an item is renewed via scanning the item into the checkout again, the statistic line branchcode will be *LibraryA* This is clearly improper behavior. The renewal is taking place at LibraryB, so the branchcode passed to AddRenewal should be LibraryB, the logged in library. This also jives with the documentation for the subroutine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 14608] HEA : add possibility of sharing usage statistics in Administration page
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #60 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.21 (required for bug 18066) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen@ptfs-e | |urope.com --- Comment #27 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Alex Arnaud from comment #25) > (In reply to Jonathan Druart from comment #24) > > This <UNCHANGED> stuff smells like a very bad codding pattern. > > Could not we use empty string and undef/NULL to handle empty values? > > Hello Jonathan, > > I don't really see how to do that. > > If you create a course item this way: > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > itype => '', > ccode => 'BOOK', > holdingbranch => '<UNCHANGED>', > location => '<UNCHANGED>', > ); > > or this way > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > ccode => 'BOOK', > holdingbranch => '<UNCHANGED>', > location => '<UNCHANGED>', > ); > > This results to the same when getting the course with GetCourseItem: itype > is undef. > Empty or null value are retrieved the same and we are unable to know if the > value has changed or not. Yeah, it looks to me like: - either you need to add a boolean column for each field that can be changed when added to course-modifier to indicate the value was changed - you add a column with a parseable string that indicates which fields were changed - you use a magic string like '<UNCHANGED>' to indicate absence of change - you add a linking table, which has an entry for each itemnumber and each changed column The latter means we would remove the ccode, holdingbranch, location, itype fields from the course_items table, and would solve the code smell but might be more work to implement. Other than that, I recon the '<UNCHANGED>' is the most workable solution. my 2¢, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Assignee|kyle(a)bywatersolutions.com |alex.arnaud(a)biblibre.com -- You are receiving this mail because: You are watching all bug changes.

1 0