May 2017 - Koha-bugs - lists.koha-community.org

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62922|0 |1 is obsolete| | --- Comment #37 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 63328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63328&action=ed… Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 18443] New: Get rid of warning 'uninitialized value $user' in C4/ Auth.pm
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Bug ID: 18443 Summary: Get rid of warning 'uninitialized value $user' in C4/Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 18429] New: Receiving an item should update the datelastseen
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18429 Bug ID: 18429 Summary: Receiving an item should update the datelastseen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 18335] New: Check in: Make patron info in hold messages obey syspref AddressFormat
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18335 Bug ID: 18335 Summary: Check in: Make patron info in hold messages obey syspref AddressFormat Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When checking in, information about patrons with a hold always display in an US style. Address information should opey the system preference AddressFormat To reproduce: - Set syspref AddressFormat to German style - Check out an item to a patron A - Put a hold on this item for patron B - Check in item using the Check in field in page header - Result: In message 'Hold found', address does not display in German style -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 18460] New: Remove itemtype-related Serials.t warnings
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18460 Bug ID: 18460 Summary: Remove itemtype-related Serials.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: gmcharlt(a)gmail.com To reproduce: - Run: $ prove t/db_dependent/Serials.t => FAIL: item-level_itypes set... warning -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice(a)biblibre.com --- Comment #22 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18423] New: Add child button not always appearing - problem in template variable
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18423 Bug ID: 18423 Summary: Add child button not always appearing - problem in template variable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com We are seeing on some sites that the 'Add child' button is not appearing on moremember.pl In these cases it seems the line: activeBorrowerRelationship => (C4::Context->preference('borrowerRelationship') ne ''), Fails to pass through the correct value -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 17911] New: Message and timeout mismatch
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17911 Bug ID: 17911 Summary: Message and timeout mismatch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Step 3 in the installer says "If this page does not redirect in 5 seconds..." but the actual number is 10 seconds (see the second line with the meta refresh content says 10). Solution: fix the meta refresh, because changing the message could be a translation mess. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 13452] Average checkout report always uses biblioitems.itemtype
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #16 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 63324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63324&action=ed… [SIGNED-OFF] Bug 13452: Fix for plack Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0