May 2017 - Koha-bugs - lists.koha-community.org

[Bug 14608] HEA : add possibility of sharing usage statistics in Administration page
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 --- Comment #60 from Julian Maurice <julian.maurice(a)biblibre.com> --- Pushed to 3.22.x for 3.22.21 (required for bug 18066) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.sassmannshausen@ptfs-e | |urope.com --- Comment #27 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Alex Arnaud from comment #25) > (In reply to Jonathan Druart from comment #24) > > This <UNCHANGED> stuff smells like a very bad codding pattern. > > Could not we use empty string and undef/NULL to handle empty values? > > Hello Jonathan, > > I don't really see how to do that. > > If you create a course item this way: > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > itype => '', > ccode => 'BOOK', > holdingbranch => '<UNCHANGED>', > location => '<UNCHANGED>', > ); > > or this way > > my $ci_id2 = ModCourseItem( > itemnumber => $itemnumber, > ccode => 'BOOK', > holdingbranch => '<UNCHANGED>', > location => '<UNCHANGED>', > ); > > This results to the same when getting the course with GetCourseItem: itype > is undef. > Empty or null value are retrieved the same and we are unable to know if the > value has changed or not. Yeah, it looks to me like: - either you need to add a boolean column for each field that can be changed when added to course-modifier to indicate the value was changed - you add a column with a parseable string that indicates which fields were changed - you use a magic string like '<UNCHANGED>' to indicate absence of change - you add a linking table, which has an entry for each itemnumber and each changed column The latter means we would remove the ccode, holdingbranch, location, itype fields from the course_items table, and would solve the code smell but might be more work to implement. Other than that, I recon the '<UNCHANGED>' is the most workable solution. my 2¢, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10382] collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Assignee|kyle(a)bywatersolutions.com |alex.arnaud(a)biblibre.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #15) > (In reply to Jonathan Druart from comment #13) > > We cannot really know the search has been truncated. > > True, but in that case we can just always warn - if we are going to have a > hardcoded limit it just needs to be announced Yes but the note is wrong, and will be hard to make it correct :) Note you added says "Note: Patron attribute searching is enabled, to avoid memory issues a limit of 100 patrons will be returned during "standard" searches" If you are searching for a pattern that is used 250x in patron attribute, and 100x in other standard fields, we will certainly get less 100 results even if the whole set would have been 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13) > We cannot really know the search has been truncated. True, but in that case we can just always warn - if we are going to have a hardcoded limit it just needs to be announced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 63335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63335&action=ed… Bug 1707 (QA Followup) Add a warning that attribute searches will be truncated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Colin Campbell from comment #21) > That should be governed by the system preference can you confirm how thats > set Both prefs below are set to 'Don't Allow' AllowItemsOnHoldCheckout AllowItemsOnHoldCheckoutSCO Before the patch, checkout is denied After the patch, checkout is successful -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)bugs.koha-c |koha-bugs(a)lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- We cannot really know the search has been truncated. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0