May 2017 - Koha-bugs - lists.koha-community.org

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #16 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Nick Clemens from comment #15) > (In reply to Jonathan Druart from comment #13) > > We cannot really know the search has been truncated. > > True, but in that case we can just always warn - if we are going to have a > hardcoded limit it just needs to be announced Yes but the note is wrong, and will be hard to make it correct :) Note you added says "Note: Patron attribute searching is enabled, to avoid memory issues a limit of 100 patrons will be returned during "standard" searches" If you are searching for a pattern that is used 250x in patron attribute, and 100x in other standard fields, we will certainly get less 100 results even if the whole set would have been 100. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #15 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13) > We cannot really know the search has been truncated. True, but in that case we can just always warn - if we are going to have a hardcoded limit it just needs to be announced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #14 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 63335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63335&action=ed… Bug 1707 (QA Followup) Add a warning that attribute searches will be truncated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Colin Campbell from comment #21) > That should be governed by the system preference can you confirm how thats > set Both prefs below are set to 'Don't Allow' AllowItemsOnHoldCheckout AllowItemsOnHoldCheckoutSCO Before the patch, checkout is denied After the patch, checkout is successful -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart(a)bugs.koha-c |koha-bugs(a)lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- We cannot really know the search has been truncated. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62922|0 |1 is obsolete| | --- Comment #37 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 63328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63328&action=ed… Bug 4460: Amazon's AssociateID tag not used in links so referred revenue lost Reworking based on output of: git grep "gp\/reader" Additionally, some changes might be in order though gp/reader works. https://affiliate-program.amazon.com/help/topic/t64/a1 suggests using dp A dp was discovered, so that part of the URL was left unchanged. The "/ref..." part was changed to just an Amazon tag ("?tag={AAT}") if defined. TEST PLAN --------- 1) Added: "100 years of Canadian foreign policy / edited by Robert Bothwell and Jean Daudelin." 2) Added a second book with the word foreign in the title. 3) Waited for reindex 4) Checked out the Canadian foreign policy book. 5) Applied patch 6) Made sure that: - AmazonAssocTag was set to TEST (easy to notice) - AmazonCoverImages was set to 'Show' - OPACAmazonCoverImages was set to 'Show' 7) Searched intranet for 'foreign' to find the detail page -- hovering over picture shows URL with ?tag=TEST in it. 8) Went to the OPAC Detail page 9) Toggling OPACURLOpenInNewWindow, confirmed that URL for the picture contained ?tag=TEST in it. 10) Logged into the OPAC 11) Confirmed the URL in the checked out list on your summary page contained ?tag=TEST in it. 12) Confirmed the URL in the checked out list on your reading history page contained ?tag=TEST in it. 13) Confirmed links worked (went to expected page) 14) run koha qa test tools Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4460] Amazon' s AssociateID tag not used in links so referred revenue lost
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 18443] New: Get rid of warning 'uninitialized value $user' in C4/ Auth.pm
by bugzilla-daemon＠bugs.koha-community.org 10 May '17

10 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18443 Bug ID: 18443 Summary: Get rid of warning 'uninitialized value $user' in C4/Auth.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org plack-error.log log and/or opac-error.log complain about 'uninitialized value $user' in C4/Auth.pm line 187. -- You are receiving this mail because: You are watching all bug changes.

1 10