May 2017 - Koha-bugs - lists.koha-community.org

[Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63237|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63243&action=ed… Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Patron's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4115] print a batch of patron cards from an import
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18555 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15108] OAI-PMH provider improvements
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #94 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 17.05, thanks Ere, Tomas! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |philippe.audet-fortin@inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7550] Self checkout: limit display of patron image to logged-in patron
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7550 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle(a)bywatersolutions.com --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan, Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58593|0 |1 is obsolete| | --- Comment #87 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- Created attachment 63239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63239&action=ed… Bug 11879: Changes to Koha's schemas -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new borrower field : main contact method.
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58592|0 |1 is obsolete| | --- Comment #86 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- Created attachment 63238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63238&action=ed… Bug 11879: Add the "Main contact method" field in borrower informations. This patch adds the "Main Contact Method" field in the borrower modification form. This field is useful for reporting purposes, or to know which contact method to use first when trying to contact a borrower. Following Nicolas' fix, removed a $branch variable from patch, since it has been suppressed in Bug 17284. Test case : * Edit a borrower's informations. The "Main Contact Method" selectbox should appear in the form and its value should be saved correctly. Sponsored-by: CCSR <http://www.ccsr.qc.ca> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula(a)jns.fi Status|Patch doesn't apply |BLOCKED --- Comment #12 from Lari Taskula <lari.taskula(a)jns.fi> --- Rebased on master, renamed occurrences of "Borrower" to "Patron", still blocked by 13995 but patches from both Bugs should apply at the time of this comment. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63236|0 |1 is obsolete| | --- Comment #11 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63237&action=ed… Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Patron's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes.

1 0