May 2017 - Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #50 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 63214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63214 ID change for jQuery listener Review of attachment 63214: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=124…) ----------------------------------------------------------------- Philippe, Please do not add unnecessary changes to your patches: blank lines, indentation changes, trailing spaces should only be fixed when you are modifying these lines. ::: koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt @@ +112,4 @@ > $("body").on("click",".select_user",function(e){ > e.preventDefault(); > var borrowernumber = $(this).data("borrowernumber"); > + var borrower_data = $("#guarantor_data"+borrowernumber).val(); You should not modify existing code without thinking about side-effects. Assume that existing code is useful and used by other scripts :) For instance with this change you break admin/add_user_search.pl when called to set the owner of a fund (from admin/aqbudgets.tt). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14536] PageObject-pattern base implementation
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #25 from Lari Taskula <lari.taskula(a)jns.fi> --- Squashed follow-ups into main patch, rebased on top of master (dependencies Bug 13906 and Bug 14495 still apply). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14536] PageObject-pattern base implementation
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41534|0 |1 is obsolete| | Attachment #41678|0 |1 is obsolete| | Attachment #42435|0 |1 is obsolete| | Attachment #42716|0 |1 is obsolete| | Attachment #44410|0 |1 is obsolete| | Attachment #47254|0 |1 is obsolete| | --- Comment #24 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63245&action=ed… Bug 14536 - PageObject-pattern base implementation This patch introduces: -PageObject base classes for OPAC and Intra, and example tests. More example tests in Buugg 14540, where setting test context is easier. -a interactive debug script to drive PageObjects more easily. ------------------ PageObjects are used to make robust and reusable integration test components to test various front-end features. PageObjects load a Selenium::Remote::Driver implementation, phantomjs by default and use this to do scripted user actions in the browser, eg. clicking HTML-elements, accepting popup dialogs, entering text to input fields. PageObjects encapsulate those very low-level operations into clear and easily usable actions or services, like doPasswordLogin(). PageObjects also seamlessly deal with navigation from one page to another, eg. my $mainpage = t::lib::Page::Mainpage->new(); $mainpage->doPasswordLogin('admin', '1234')->gotoPatrons()-> searchPatrons({keywordSearch => "Jane Doe"}); PageObjects make doing integration tests so great! You can google for the specifics of PageObject patterns and there are a ton of great tutorials explaining their function. Now PageObjects also have a debugging system where you can get the server response in a title+cookies+html-dump and a screenshot of the browser session. see t::lib::Page for more info! --------------------- Interactive debugger at misc/devel/interactiveWebDriverShell.pl loads the desired PageObject with the needed parameters to the debugger context and makes dynamic UserAgent scripting easy and fun! --------------------- Bug 14536: (follow-up) Adds polling to Page.pm and enhances navigation. This follow-up adds a subroutine poll to superclass Page.pm. Polling will execute an anonymous subroutine for as long as defined or until the subroutine is successful. --------------------- -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18518] New: The staff interface "blink" for different actions after upgrading to Firefox 53
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18518 Bug ID: 18518 Summary: The staff interface "blink" for different actions after upgrading to Firefox 53 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard(a)myacpl.org Reporter: francois.charbonnier(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org After upgrading to firefox 53 (ubuntu 14.04) I noticed the interface "blinks" when I check out an item (on Koha 16.05) I tried this with firefox 52, the interface stays still. Marc Veron reproduced the issue on the current master : - On the staff client main page, click on 'Patrons' - While loading the page, I see very shortly a yellow message "Add patrons to" (I took a video and stepped through it to be able to read the text). - Then the page refreshes and displays as expected. - I get the same when I am on the page Home > Patrons and click 'Search'. I get it with Firefox 53.0 (Windows) I do not get it with Firefox ESR 45.3.0 (Debian) Marc suggests the message "Add patrons to" should not be triggered. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin@inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

1 0

[Bug 13995] Proper Exception handling
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14536] PageObject-pattern base implementation
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13995 | CC| |lari.taskula(a)jns.fi Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 [Bug 13995] Proper Exception handling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41531|0 |1 is obsolete| | Attachment #42430|0 |1 is obsolete| | Attachment #42602|0 |1 is obsolete| | Attachment #47244|0 |1 is obsolete| | Attachment #47253|0 |1 is obsolete| | --- Comment #26 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63244&action=ed… Bug 13906 - TestObjectFactory(ies) for Koha objects. Enable easy Test object creation/deletion from HASHes. Doing tests should be easy. One biggest hindrance in doing tests is the difficulty of doing so in Koha. We use a lot of hard-coded SQL, which occasionally requires quite a bit of fiddling to get it right. Satisfying complex object dependency chains is hard. For example, testing Overdue notice sending, one must create -letters -overuderules -circulationrules -borrowers -biblios -items -issues (checkouts) ... Also one must take care to clean up the database modifications afterward to make encapsulated tests which don't leak over other tests. This is especially so for front-end testing. TestObjectFactories significantly alleviate this pain. They try to recover from errors, like when the previous test crashed and left testing objects into the DB, preventing adding them again. Also they store what object they created to 3 different levels of stashes to facilitate complex test configurations, and they have the dignity to clean-up the test contexts after testing has happened (if the script doesn't crash)! UNIT TESTS included! USAGE: use t::lib::TestObjects::PatronFactory; %#Setting up the test context my $testContext = {}; my $password = '1234'; my $patronFactory = t::lib::TestObjects::PatronFactory->new(); my $patrons = $patronFactory->createTestGroup([ {firstname => 'Olli-Antti', surname => 'Kivi', cardnumber => '1A01', branchcode => 'CPL', flags => '1', #superlibrarian, not exactly a very good way of doing permission testing? userid => 'mini_admin', password => $password, }, ], undef, $testContext); %#Test context set, starting testing: eval { ... #Run your tests here }; if ($@) { #Catch all leaking errors and gracefully terminate. warn $@; tearDown(); exit 1; } %#All tests done, tear down test context tearDown(); done_testing; sub tearDown { t::lib::TestObjects::ObjectFactory->tearDownTestContext($testContext); } -- You are receiving this mail because: You are watching all bug changes.

1 0