May 2017 - Koha-bugs - lists.koha-community.org

[Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41530|0 |1 is obsolete| | Attachment #63235|0 |1 is obsolete| | --- Comment #10 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63236&action=ed… Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Patron-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Patrons->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Borrower's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14539] Introduction to castToObject(), aka. make a Koha:: Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 --- Comment #9 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63235&action=ed… Bug 14539 - Koha::Objects->cast(). Introduction to cast() (ToObject), aka. make a Koha::Object from various input types and validate. Finds a Borrower-object (or any other type) from various different types of inputs. Also doubles as a validator function, dying if input is improper. USAGE: my $member = C4::Members::GetMember(borrowernumber => $borrowernumber); my $borrower = Koha::Borrowers->cast($member); Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Borrower's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. Unit tests included demonstrating the feature and possible pitfalls. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14495] WebDriver/ WebTester Factory for easy generation of Web testing UserAgents.
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14495 Lari Taskula <lari.taskula(a)jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41533|0 |1 is obsolete| | --- Comment #12 from Lari Taskula <lari.taskula(a)jns.fi> --- Created attachment 63234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63234&action=ed… Bug 14495 - WebDriver/WebTester Factory for easy generation of Web testing UserAgents. Has an optional dependency to Buugg 13799 Because life is short, getting test web drivers must be easy. use t::lib::WebDriverFactory; my ($firefox) = t::lib::WebDriverFactory::getUserAgentDrivers('firefox'); In Ubuntu 14.04, Selenium no longer requires a stand-alone testing Server, so running integration tests is much much more fun! This factory encapsulates all the boring bits about getting a web driver to mimic user behaviour in the GUI. And makes it super easy to get a test driver for any testing type environment. Adds support for Test::Mojo and Selenium, see t::lib::WebDriverFactory for installation and usage instructions. ---------------------------- -INSTALLATION INSTRUCTIONS:- ---------------------------- -All the WebDriver tests use the Selenium::PhantomJS-package by default. You MUST install the following dependencies: cpanm Selenium::Remote::Driver cpanm Selenium::PhantomJS apt-get install phantomjs #Minimum version acceptable is v1.09 Optionally you can install other Selenium browsers like Firefox Chrome IE But they are only useful when testing the WebDriver scripts on a graphical environment. You are better off using Selenium IDE to learn/test WebDriver scripts. run t::lib::webDriverFactory.t to see your configured capabilities. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #18 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to sandboxes(a)biblibre.com from comment #17) > Signed-off-by: Felix Hemme <felix.hemme(a)thulb.uni-jena.de> Thx -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #17 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 63233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63233&action=ed… Bug 15140: Display $i when ind2==8 See MARC specification. Note that we have a preceding text before all 776s too. Test plan: [1] Set field 776 ind2 to 8. And add text in $i. [2] Look for this text on OPAC detail and staff detail. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Felix Hemme <felix.hemme(a)thulb.uni-jena.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 --- Comment #16 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Created attachment 63232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63232&action=ed… Bug 15140: Add MARC21 776 to OPAC and staff display Adds code to opac and staff detail XSLT in order to show 776$t (or $a) and a link based on 776$w (record control number). $w should be in the form: (MARCOrgCode)Record-number For instance: (NL-AmRIJ)12345 Note: You should have enabled default opac/intranet XSLT view. Test plan: [1] Add two 776s (one with $t and $w and one with $t only) [2] Verify that you see "Additional physical formats" on opac-detail. Does the link for $w work? [3] Check intranet detail too. [4] Empty 776$t and put text in $a. Check detail page again. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Felix Hemme <felix.hemme(a)thulb.uni-jena.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15140] Add MARC21 776 to OPAC and staff display
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15140 sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes(a)biblibre.com --- Comment #15 from sandboxes(a)biblibre.com <sandboxes(a)biblibre.com> --- Patch tested with a sandbox, by Felix Hemme <felix.hemme(a)thulb.uni-jena.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14504] Add command-line script to batch delete items based on data in items table
by bugzilla-daemon＠bugs.koha-community.org 08 May '17

08 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 [Bug 18329] Batch record deletion broken -- You are receiving this mail because: You are watching all bug changes.

1 0