May 2017 - Koha-bugs - lists.koha-community.org

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #42 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Magnus Enger from comment #40) > The patches do apply cleanly, so thanks for that! There is however a problem > with userflags. The patches have this: > > installer/data/mysql/atomicupdate/ill_tables.sql > +INSERT INTO userflags (bit,flag,flagdesc,defaulton) > +VALUES (21,'ill','The Interlibrary Loans Module',0); > > But the User Clubs feature have "stolen" number 21. This *is* reflected in > installer/data/mysql/userflags.sql: > > +(22,'ill','The Interlibrary Loans Module',0) You are quite right! Thanks for pointing that out — that should now be fixed. Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #41 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63113&action=ed… Bug 7317: Followup: Update atomicupdate file. * installer/data/mysql/atomicupdate/ill_tables.sql: Set ILL permission id to 22. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only )
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18540 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #97 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- (In reply to Marcel de Rooy from comment #95) > I tested with a trival csv: > biblio.title | some_text=aqorders.quantity > > The title is not shown, the quantity is. Have the impression that the regex > might still be the cause. > What did you test? I copy paste your csv and I got some blank fields too. I try by removing white spaces and it worked. (I had not seen your comment and I signoff too early. Sorry.) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18162] New: Don't translate JSON keys
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18162 Bug ID: 18162 Summary: Don't translate JSON keys Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org Symptoms: When Swedish or Norwegian was selected as the interface language in the staff client, patron searches that were only returning a single result would redirect to /cgi-bin/koha/members/moremember.pl?borrowernumber=undefined, which of course gives the message "This patron does not exist. Find another patron?" Cause: In koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt we have this: 34 "dt_action": 35 "<a href='/cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=[% data.borrowernumber %]' class='btn btn-default btn-xs'><i class='fa fa-pencil'></i> Edit</a>", 36 "borrowernumber": 37 "[% data.borrowernumber %]" 38 }[% UNLESS loop.last %],[% END %] borrowernumber here is meant to be a key in some JSON data, but it had been translated, which means the JS in koha-tmpl/intranet-tmpl/prog/nb-NO/modules/members/member.tt that redirects when there is only one result could not find the borrowernumnber: 196 // redirect if there is only 1 result. 197 if ( json.aaData.length == 1 ) { 198 var borrowernumber = json.aaData[0].borrowernumber; 199 document.location.href="/cgi-bin/koha/members/moremember.pl?borrowernumber="+borrowernumber; 200 return false; 201 } In Pootle, the string that had been translated looks like this: ", "borrowernumber": "%s" }%s,%s %s ] } %s %s %s%s%s %s%s%s %s%s%s %s %s Quick fix: Find the relevant string in *-staff-prog.po and untranslate it. Permanent fix: Is there some way to mark a string so it does not get picked up for translation? If not, perhaps it would make sense to rename borrowernumber here to something that is more obviously not meant to be translated? Why are the other keys in the JSON prefixed with dt_? Is there some special magic to it, or could we do the same for borrowernumber? Thanks to oha on #koha for nudging me in the right direction to figure this out. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 13913] Renewal error message in OPAC is confusing
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 --- Comment #4 from Owen Leonard <oleonard(a)myacpl.org> --- I do NOT think my patch fixes this problem. It simply addresses a cosmetic issue and improves the situation until a real fix is made. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13913] Renewal error message in OPAC is confusing
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 63105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63105&action=ed… Bug 13913 - Renewal error message in OPAC is confusing This patch adds some formatting to the error message a patron receives when there are renewal failures in the OPAC. This is pretty much the least which could be done to address this problem. However, I don't think the issue can be fixed without re-thinking how renewals are processed. Sending error messages back to opac-user.pl via URL parameter isn't flexible enough. To test, apply the patch and attempt to renew multiple items in the OPAC which cannot be renewed for some reason, for instance because they have been renewed too many times. The error messages should appear in a list rather than strung together in one long block of text. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13913] Renewal error message in OPAC is confusing
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13913 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63056|0 |1 is obsolete| | --- Comment #96 from Philippe Audet-Fortin <philippe.audet-fortin(a)inlibro.com> --- Created attachment 63104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63104&action=ed… Bug 8612: QA followup - expand tests Test plan: prove t/db_dependent/Acquisition/GetBasketAsCSV.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #40 from Magnus Enger <magnus(a)libriotech.no> --- The patches do apply cleanly, so thanks for that! There is however a problem with userflags. The patches have this: installer/data/mysql/atomicupdate/ill_tables.sql +INSERT INTO userflags (bit,flag,flagdesc,defaulton) +VALUES (21,'ill','The Interlibrary Loans Module',0); But the User Clubs feature have "stolen" number 21. This *is* reflected in installer/data/mysql/userflags.sql: +(22,'ill','The Interlibrary Loans Module',0) -- You are receiving this mail because: You are watching all bug changes.

1 0