May 2017 - Koha-bugs - lists.koha-community.org

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62003|0 |1 is obsolete| | --- Comment #79 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63093&action=ed… Bug 12063 - Keep patron's requested expiration date if it is prior to the calculated one Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace(a)sub.su.se> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62002|0 |1 is obsolete| | --- Comment #78 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63092&action=ed… Bug 12063 - Remove Koha::Hold::waiting_expires_on since dateexpiration is set on database Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62001|0 |1 is obsolete| | --- Comment #77 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63091&action=ed… Bug 12063: Change date calculation for reserve expiration to skip all holiday This patch makes koha automatically set expiration date when reserves become waitting. Also it adds a new syspref "ExcludeHolidaysFromMaxPickUpDelay" that allows to take holidays into account while calculating expiration date. Test plan: - Install this patch and run updatedatabase.pl script, - allow ExpireReservesMaxPickUpDelay in system preferences, - set ReservesMaxPickUpDelay to 5. - Place an hold on a checked out item and check in this item: The hold's expiration date should be today + 5. - Allow ExcludeHolidaysFromMaxPickUpDelay in system preferences, - add holiday during this pickup delay period, - Create a new hold and make it comes waitting: The hold's expiration date should be today + 5 + number of closed day(s). Also: - Check that ExpireReservesOnHolidays syspref works again without ExcludeHolidaysFromMaxPickUpDelay. - Check that cancel fees apply again if wanted. Signed-off-by: sonia BOUIS <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #39 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- (In reply to Magnus Enger from comment #28) > It also looks like there is a missing "use Koha::Illrequests;" in > Koha/Illrequest.pm? > > When I try to use Koha::Illrequest in the Dancer-based NCIPServer I get this > error: > > [24015] error @1.447857> [hit #5]request to POST / crashed: Can't locate > object method "search" via package "Koha::Illrequests" (perhaps you forgot > to load "Koha::Illrequests"?) at /path/to/kohaclone/Koha/Illrequest.pm line > 684. in /usr/share/perl5/Dancer/Handler.pm l. 98 Hi, Thanks for pointing that out. I have now added a patch fixing this. I have also rebased and pushed up a few more patches we've been working on. Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #38 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63090&action=ed… Bug 7317: Add missing reference for `Koha::Illrequest`. * Koha/Illrequest.pm: Add missing `use` statement. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #37 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63089&action=ed… Bug 7317: Bugfix: Use correct column names in check_limits. * Koha/Illrequest.pm (check_limits): Change column names used to `branchcode` & `borrowernumber`. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #36 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63088&action=ed… Bug 7317: Allow display/hiding of arbitrary request columns Initially display a small selection of core fields, allow the user to progressively display additional metadata fields if required -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #35 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63087&action=ed… Bug 7317: Make error messages slightly more user friendly. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: Change layout of errors, don't display cancel heading on cancel error. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #34 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63086&action=ed… Bug 7317: Allow journey to 'COMP' status. * Koha/Illrequest.pm (_core_status_graph): Add 'COMP' journey, and method. (mark_completed): new procedure. * ill/ill-requests.pl: Handle mark_completed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 --- Comment #33 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 63085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63085&action=ed… Bug 7317: Bugfix: copy ill folder during installation. * Makefile.PL: Add './ill' to list of installable directories. -- You are receiving this mail because: You are watching all bug changes.

1 0