May 2017 - Koha-bugs - lists.koha-community.org

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #95 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- I tested with a trival csv: biblio.title | some_text=aqorders.quantity The title is not shown, the quantity is. Have the impression that the regex might still be the cause. What did you test? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18358] New: koha item-status.inc variable name
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18358 Bug ID: 18358 Summary: koha item-status.inc variable name Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: long_sam.tw(a)yahoo.com.tw QA Contact: testopia(a)bugs.koha-community.org http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tm… I found the item.itemnotforloan variable, but opac-course-details.tt has used this codes. 54 [% IF ( item.itemnotforloan ) %] 55 [% SET itemavailable = 0 %] 56 [% IF ( item.notforloanvalueopac ) %] 57 [% item.notforloanvalueopac %] [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 58 [% ELSE %] 59 Not for loan [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 60 [% END %] 61 [% ELSIF ( item.notforloan_per_itemtype ) %] 62 [% SET itemavailable = 0 %] 63 Not for loan [% IF ( item.restrictedopac ) %]([% item.restrictedopac %])[% END %] 64 [% END %] opac-course-details.tt line 76 76 <td>[% INCLUDE 'item-status.inc' item=cr.item issue=cr.issue %]</td> 77 <td>[% cr.issue.date_due | $KohaDates as_due_date => 1 %]</td> 78 <td>[% IF ( cr.public_note ) %] Dump opac-course-details.pl codes. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=opac/opac-course-… 47 my $course_reserves = GetCourseReserves( course_id => $course_id, include_items => 1, include_count => 1 ); $course_reserves has no item.itemnotforloan variables, but has item.notforloan variables. course_reserves -------------------- $VAR1 = [ { 'itemnumber' => '19349', 'course_item' => { 'itemnumber' => '19349', 'ccode' => undef, 'location' => undef, 'ci_id' => '18', 'course_reserves' => [ { 'timestamp' => '2017-02-22 17:16:50', 'ci_id' => '18', 'staff_note' => '', 'course_id' => '7', 'cr_id' => '18', 'public_note' => '' } ], 'holdingbranch' => undef, 'timestamp' => '2017-02-23 11:11:33', 'itype' => 'BOOKC', 'enabled' => 'yes' }, 'ci_id' => '18', 'item' => { 'withdrawn' => '0', 'coded_location_qualifier' => undef, 'marc' => '00501nam a2200157Ia 4500003000600000005001700006008004000023040000800063100006800071245009700139250000800236260004900244700001800293942001700311999001500328AOGST20161028172127.0141108s1986 ch e 000 chi d aaog1 a賀西納 Harold Vinson Synan 著/魏玉琴譯c(Vinson Synan)10a靈恩運動 c賀西納 (Vinson Synan)著 ; 魏玉琴譯b美國聖潔及五旬節運動史 a初 b教會更新研究發展中心c1986a台北1 aSynanbVinson 2AOGSTcBOOKC c6589d6589', 'url' => undef, 'isbn' => undef, 'copyrightdate' => '1986', 'itemnumber' => '19349', 'ccode' => undef, 'serial' => undef, 'cn_suffix' => undef, 'barcode' => 'B1010102217', 'cn_item' => undef, 'uri' => undef, 'marcxml' => "<?xml version=\"1.0\" encoding=\"UTF-8\"?> <record xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" xsi:schemaLocation=\"http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd\" xmlns=\"http://www.loc.gov/MARC21/slim\"> <leader>00501nam a2200157Ia 4500</leader> <controlfield tag=\"003\">AOGST</controlfield> <controlfield tag=\"005\">20161028172127.0</controlfield> <controlfield tag=\"008\">141108s1986 ch e 000 chi d</controlfield> <datafield tag=\"040\" ind1=\" \" ind2=\" \"> <subfield code=\"a\">aog</subfield> </datafield> <datafield tag=\"100\" ind1=\"1\" ind2=\" \"> <subfield code=\"a\">\x{8cc0}\x{897f}\x{7d0d} Harold Vinson Synan \x{8457}/\x{9b4f}\x{7389}\x{7434} \x{8b6f}</subfield> <subfield code=\"c\">(Vinson Synan)</subfield> </datafield> <datafield tag=\"245\" ind1=\"1\" ind2=\"0\"> <subfield code=\"a\">\x{9748}\x{6069}\x{904b}\x{52d5} </subfield> <subfield code=\"c\">\x{8cc0}\x{897f}\x{7d0d} (Vinson Synan)\x{8457} ; \x{9b4f}\x{7389}\x{7434}\x{8b6f}</subfield> <subfield code=\"b\">\x{7f8e}\x{570b}\x{8056}\x{6f54}\x{53ca}\x{4e94}\x{65ec}\x{7bc0}\x{904b}\x{52d5}\x{53f2}</subfield> </datafield> <datafield tag=\"250\" ind1=\" \" ind2=\" \"> <subfield code=\"a\">\x{521d}</subfield> </datafield> <datafield tag=\"260\" ind1=\" \" ind2=\" \"> <subfield code=\"b\">\x{6559}\x{6703}\x{66f4}\x{65b0}\x{7814}\x{7a76}\x{767c}\x{5c55}\x{4e2d}\x{5fc3}</subfield> <subfield code=\"c\">1986</subfield> <subfield code=\"a\">\x{53f0}\x{5317}</subfield> </datafield> <datafield tag=\"700\" ind1=\"1\" ind2=\" \"> <subfield code=\"a\">Synan</subfield> <subfield code=\"b\">Vinson</subfield> </datafield> <datafield tag=\"942\" ind1=\" \" ind2=\" \"> <subfield code=\"2\">AOGST</subfield> <subfield code=\"c\">BOOKC</subfield> </datafield> <datafield tag=\"999\" ind1=\" \" ind2=\" \"> <subfield code=\"c\">6589</subfield> <subfield code=\"d\">6589</subfield> </datafield> </record> ", 'materials' => undef, 'datelastseen' => '2017-02-21', 'cn_class' => undef, 'title' => "\x{9748}\x{6069}\x{904b}\x{52d5} ", 'pages' => undef, 'withdrawn_on' => undef, 'number' => undef, 'itemtype' => 'BOOKC', 'totalissues' => undef, 'author' => "\x{8cc0}\x{897f}\x{7d0d} Harold Vinson Synan \x{8457}/\x{9b4f}\x{7389}\x{7434} \x{8b6f}", 'size' => undef, 'replacementprice' => undef, 'seriestitle' => undef, 'booksellerid' => undef, 'timestamp' => '2016-10-28 17:21:27', 'new_status' => undef, 'editionstatement' => "\x{521d}", 'stocknumber' => undef, 'publishercode' => "\x{6559}\x{6703}\x{66f4}\x{65b0}\x{7814}\x{7a76}\x{767c}\x{5c55}\x{4e2d}\x{5fc3}", 'collectionvolume' => undef, 'datecreated' => '2014-11-08', 'reserves' => undef, 'editionresponsibility' => undef, 'itemnotes_nonpublic' => undef, 'enumchron' => undef, 'dateaccessioned' => '2016-10-28', 'notes' => undef, 'permanent_location' => undef, 'volumedate' => undef, 'itype' => 'CRC', 'onloan' => undef, 'illus' => undef, 'ean' => undef, 'biblioitemnumber' => '6589', 'restricted' => undef, 'agerestriction' => undef, 'itemlost_on' => undef, 'notforloan' => '1', 'replacementpricedate' => '2016-10-28', 'itemnotes' => undef, 'itemcallnumber' => '231.21 8349', 'location' => undef, 'stack' => undef, 'itemlost' => '0', 'collectionissn' => undef, 'price' => undef, 'abstract' => undef, 'collectiontitle' => undef, 'publicationyear' => undef, 'issues' => '1', 'place' => "\x{53f0}\x{5317}", 'homebranch' => 'AOGST', 'issn' => undef, 'cn_source' => 'AOGST', 'more_subfields_xml' => undef, 'holdingbranch' => 'AOGST', 'renewals' => undef, 'biblionumber' => '6589', 'damaged' => '0', 'unititle' => undef, 'cn_sort' => '', 'lccn' => undef, 'volume' => undef, 'frameworkcode' => 'M21', 'datelastborrowed' => '2017-02-06', 'volumedesc' => undef, 'copynumber' => 'c.2', 'paidfor' => undef }, 'issue' => undef, 'public_note' => '', 'reserves_count' => '1', 'timestamp' => '2017-02-22 17:16:50', 'staff_note' => '', 'course_id' => '7', 'cr_id' => '18' }, -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 11979] Display correct not for loan status description on course reserves
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11979 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |long_sam.tw(a)yahoo.com.tw --- Comment #7 from Owen Leonard <oleonard(a)myacpl.org> --- *** Bug 18358 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #86 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Final QA Comment: After a longer process, we reached Passed QA now. Added two small follow-ups. One serious problem in the db rev fixed. Still wanting to mention two points without triggering discussion again: [1] The construction around expirationdate still feels little bit unappropriate to me personally, but after some discussion we found a compromize. [2] The change in Letters.pm is still arguable. Previously, expirationdate was calculated here and could be used on a notice. Now, we do no longer need to calculate it theoretically. But take e.g. the hold slip; the notice is generated before the expiration date is set and therefore still empty. I recommend to have a look at this problem on a new report. I do not consider it as a blocker. Thanks, Alex. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #85 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63099&action=ed… Bug 12063: [QA Follow-up] Small change of two test scripts Removing dbh from one script, changing rollback in the other. Schema is leading now. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #84 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63098&action=ed… Bug 12063: [QA Follow-up] Adjustments to db revision Replace use by require. Add require Koha::Calendar (seriously needed to prevent crashing). Base expirationdate on today not on waitingdate (just as in Reserves). Remove if ( waitingdate ) construction. Not needed anymore. Remove $cancel_on_holidays. Not used. Note that the if construction around the new pref is not strictly needed at upgrade time (pref still zero). Fill the dbrev description. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63057|0 |1 is obsolete| | --- Comment #83 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63097&action=ed… Bug 12063 - Remove checking of ExpireReservesMaxPickUpDelay in CancelExpiredReserves(). Koha::Hold::set_waiting calculate expiration date from today instead of hold's waiting date. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62474|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63096&action=ed… Bug 12063 - make perl atomic update follow skeleton.perl Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62005|0 |1 is obsolete| | --- Comment #81 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63095&action=ed… Bug 12063 - Fix QA failures - Remove expiration date calculation in C4::Letter since it's done when setting the reserve waiting, - remove expiration date calculation in circ/waitingreserves.pl. Use the one in DB, - add a new atomic update that calculate expiration date for waiting reserves, - add tests for days_foward function and fix the infinite loop. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 04 May '17

04 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62004|0 |1 is obsolete| | --- Comment #80 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 63094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63094&action=ed… Bug 12063 - Fix unit tests Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0