May 2017 - Koha-bugs - lists.koha-community.org

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #70 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Alex Arnaud from comment #69) > (In reply to Marcel de Rooy from comment #68) > > sub set_waiting { > > [...] > > + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { > > + $expirationdate = $calendar->days_forward( > > dt_from_string($self->waitingdate), $max_pickup_delay ); > > + } > > This may cause something weird. If you do a second > > Is it possible that the code of set_waiting (after tranferToDo) should be > called 2 times for the same reserve ? Anyway it doesn't hurt to pass today to days_forward. So i'll fix it -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #69 from Alex Arnaud <alex.arnaud(a)biblibre.com> --- (In reply to Marcel de Rooy from comment #68) > Still working on this one now. > Preliminary results: > > sub CancelExpiredReserves { > + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); > This may have a unwanted side-effect. If we do not use the pickup delay, but > still want to cancel expired reserves. You mean: If ExpireReservesMaxPickUpDelay is set to don't allow ? If yes, this is because we don't want to cancel expired reserves right ? Or i don't understand the syspref. > > sub set_waiting { > [...] > + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { > + $expirationdate = $calendar->days_forward( > dt_from_string($self->waitingdate), $max_pickup_delay ); > + } > This may cause something weird. If you do a second Is it possible that the code of set_waiting (after tranferToDo) should be called 2 times for the same reserve ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12063] Change date calculation for reserve expiration to skip all holidays
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #68 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Still working on this one now. Preliminary results: sub CancelExpiredReserves { + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); This may have a unwanted side-effect. If we do not use the pickup delay, but still want to cancel expired reserves. It is no longer possible. (Note that patrons may have entered expiration dates too.) Not marking this as a blocker, since this is probably exceptional. Do you have an easy fix or can you open a new report for it? sub set_waiting { [...] + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { + $expirationdate = $calendar->days_forward( dt_from_string($self->waitingdate), $max_pickup_delay ); + } This may cause something weird. If you do a second checkin while the waitingdate is say yesterday, the waitingdate is set to today but the expiration date will be based upon the old waitingdate. Again probably exceptional, but still something to fix. I would opt here for basing the expiry on today, since we reset the waitingdate too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Magnus Enger <magnus(a)libriotech.no> --- It also looks like there is a missing "use Koha::Illrequests;" in Koha/Illrequest.pm? When I try to use Koha::Illrequest in the Dancer-based NCIPServer I get this error: [24015] error @1.447857> [hit #5]request to POST / crashed: Can't locate object method "search" via package "Koha::Illrequests" (perhaps you forgot to load "Koha::Illrequests"?) at /path/to/kohaclone/Koha/Illrequest.pm line 684. in /usr/share/perl5/Dancer/Handler.pm l. 98 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5456] Create a link to opac-ics.pl
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 --- Comment #14 from Magnus Enger <magnus(a)libriotech.no> --- (In reply to John Andrews from comment #13) > There's a problem with the lack of end time -- when importing this into my > outlook calendar, because there's no end time, outlook automatically creates > an hour long event. Which means that the due date reminder shows up both on > the due date, and on the day AFTER the due date. In our case, the time due > is 11:59 pm, so the appointment gets created in outlook as from 11:59 pm on > the due date until 12:59 am on the next day. Is there a way to force the > appointment to start and end at the same time? Please report this as a new bug/issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12021] SIP2 checkin should alert on transfer and use CT for return branch
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12021 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #21 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12930] Web installer does not show login errors
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12930 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com --- Comment #17 from Mason James <mtj(a)kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17872] New: Fix small error in GetBudgetHierarchy and one of its calls
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17872 Bug ID: 17872 Summary: Fix small error in GetBudgetHierarchy and one of its calls Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 17309] New: Renewing and HomeOrHoldingBranch syspref
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17309 Bug ID: 17309 Summary: Renewing and HomeOrHoldingBranch syspref Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: ed.veal(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When renewing an item the HomeOrHoldingBranch syspref is not taken into consideration and the issuing branch rules are applied. This can be a problem when the rules differ. Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 17346] New: Enable the check in option in Columns settings
by bugzilla-daemon＠bugs.koha-community.org 03 May '17

03 May '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17346 Bug ID: 17346 Summary: Enable the check in option in Columns settings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: T.Reimann95(a)gmx.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Enable the option to disable the check-in column under Columns settings. This option is under the index tab : circulation and patrons. This option should be enabled, because the check-in is not necessary at this places, so if a library want to hide it, they should get the possibility. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19