June 2017 - Koha-bugs - lists.koha-community.org

[Bug 18828] 16.05.05.000
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com Status|Needs Signoff |Failed QA --- Comment #100 from Josef Moravec <josef.moravec(a)gmail.com> --- Just tested now and have some minor comments: 1) I was able to go to Stock rotation tool even when the StockRotation preference was n't enabled... 2) All the actions buttons should be smaller - we use btn-xs class everywhere - should be consistant I think Setting failed because of 1), the 2) could be discussed - Owen, do you have same feeling? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec(a)gmail.com --- Comment #67 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #59) > I've tried testing this by applying the patches, running the database > update, regenerating the Schema. Every time I try to order from my accepted > suggestion, an internal server error is shown (running under Plack with > kohadevbox). > Without Plack the error shown is: > Template process failed: undef error - The method selected is not covered by > tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121. > > This prevents me from testing the problem I had earlier :( Filed bug 18525 > as I also see this without the patches. But would be good if someone could > confirm. I can't confirm it, it does work for me... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #66 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64465&action=ed… [SIGNED-OFF] Bug 13392 - Follow-up on terminology Standardizing a few terms - Patron sort 1/2 to match the holds statistics wizard - Patron category instead of borrower category Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #65 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64464&action=ed… [SIGNED-OFF] Bug 13392: Remove use of C4::Branch and C4::Category + fix a 'ambiguous column name' error when using borrowers table Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #64 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64463&action=ed… [SIGNED-OFF] Bug 13392 - Replace using of C4::Dates and C4::ItemType by Koha::DateUtils and Koha::ItemTypes Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #63 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64462&action=ed… [SIGNED-OFF] Bug 13392 - Fix QA failures: - Fix a perl warning in suggestions_stats.tt, - Replace term "Acquisitions" with "Suggestions", - Add POD for GetBudgetDescendantsIds. Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #62 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64461&action=ed… [SIGNED-OFF] Bug 13392: QA fixes 1/ Add tests descriptions 2/ Do not use Koha::I18N for suggestion statuses, and add statuses from SUGGEST_STATUS authorised values 3/ Use copyrightdate instead of publicationyear which seems to be unused 4/ Display free text filters if there is no values in corresponding authorised values list 5/ Rename 'Branch' to 'Library' and 'Reject reason' to 'Reason' Signed-off-by: Nicole Engard <nengard(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 --- Comment #61 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64460&action=ed… [SIGNED-OFF] Bug 13392: New statistics assistant for suggestions New sub C4::Budgets::GetBudgetDescendantsIds (with unit tests) Signed-off-by: Nicole Engard <nengard(a)bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13392] New statistics wizard for suggestions
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13392 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60956|0 |1 is obsolete| | Attachment #60957|0 |1 is obsolete| | Attachment #60958|0 |1 is obsolete| | Attachment #60959|0 |1 is obsolete| | Attachment #60960|0 |1 is obsolete| | Attachment #60961|0 |1 is obsolete| | Attachment #60962|0 |1 is obsolete| | --- Comment #60 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 64459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64459&action=ed… [SIGNED-OFF] Bug 13392: Add suggestions.ordereddate and suggestions.orderedby Those fields are updated when suggestion status is changed to 'ORDERED' and are displayed on suggestion/suggestion.pl page Signed-off-by: Nicole Engard <nengard(a)bywatersolutions.com> Patch updated: Use atomic update Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0