June 2017 - Koha-bugs - lists.koha-community.org

[Bug 18762] New: Some tests are noisy
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Bug ID: 18762 Summary: Some tests are noisy Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: gmcharlt(a)gmail.com xt/author/valid-templates.t .. 32/? Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 785. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 785. xt/author/valid-templates.t .. 47/? Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt line 49. xt/author/valid-templates.t .. 59/? # excluding template /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc because it cannot stand on its own # excluding template /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc because it cannot stand on its own xt/author/valid-templates.t .. 150/? Argument "" isn't numeric in multiplication (*) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt line 356. [SKIP CGI warnings] Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 134. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 134. t/db_dependent/Search/History.t .. 1/27 DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. t/db_dependent/Search.t .. The syspref casAuthentication was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casLogout was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casServerUrl was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref template was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #128 from David Cook <dcook(a)prosentient.com.au> --- WARNING! I just remembered that these patches won't work as expected on Debian Jessie at the moment, if you're using the RDF options. That's because there are bugs in RDF::Trine, especially in the version found in Debian Jessie. I've written fixes and the maintainer for RDF::Trine has merged them into master and included them in the latest CPAN releases. The critical fix is in version 1.017. The newest version is 1.018, which includes some additional fixes, but they're not critical. In terms of testing, there are some options. 1) You wait for Mirko to package the latest RDF::Trine and put it in Koha's Debian repositories and install it from there 2) You install the latest RDF::Trine from CPAN 3) You clone the RDF::Trine github at https://github.com/kasei/perlrdf and then run KOHA_CONF=/path/to/etc/koha-conf.xml perl -I /path/to/perlrdf/RDF-Trine/lib misc/harvesterd.pl Your best bet is probably option #3. That's what I did while I was waiting for kasei to merge and release my fixes to RDF::Trine. In that event, while I'd appreciate the sign off, I think I'd leave it as "Needs Signoff" since we haven't resolved the RDF::Trine dependency yet. But this is a way that you can test the code. Only the harvester daemon needs RDF::Trine for these patches, so you don't need to play with your Apache config or anything like that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #127 from David Cook <dcook(a)prosentient.com.au> --- That should do the trick. I just tested applying 18585, 18586, 18713, and 10662 and it applied successfully. I'm not actually 100% sure why it wasn't working before. A botched rebase at some point, although it wasn't obvious based on commit diffs. Oh well. Fixed now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64446|0 |1 is obsolete| | --- Comment #126 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 64481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64481&action=ed… Bug 10662 - Modify OAI-PMH harvester to import RDFXML Typically, the OAI-PMH harvester only imports MARCXML, but this patch allows you to also import RDFXML. This functionality was requested by Stockholm University Library, and importing RDFXML requires a parallel import of MARCXML if you want to be able to use the RDFXML. That is to say, you can download and import RDFXML using this patch, but it will probably only be useful if you're also importing MARCXML which can be linked to the RDFXML using the OAI-PMH repository and identifier as a link. This might change in the future if Koha moves away from MARCXML as the central required metadata format. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64445|0 |1 is obsolete| | --- Comment #125 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 64480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64480&action=ed… Bug 10662 - Remove workaround for pre-17710 behaviour -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64444|0 |1 is obsolete| | --- Comment #124 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 64479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64479&action=ed… Bug 10662 - Build OAI-PMH Harvesting Client This patch adds an OAI-PMH harvesting client to Koha. The client runs as a daemon in the background. Users interact with the client via the Koha web user interface, which communicates with the daemon via a unix socket using a simple JSON-based protocol. The harvester ingests MARCXML. You can harvest other metadata formats, but you must use a XSLT to transform them into MARCXML, if you want them to be imported into Koha. You can supply your own download and import modules via the oai-pmh-harvester.yaml configuration file, but the default modules supplied in this patch should be good enough for your purposes. If they're not, raise a Bugzilla issue. There is a cleanup_database.pl addition, because high volume harvesting will cause the oai_harvester_import_queue table to fill quickly. This table is not required for adding/updating records. It's mostly just for general monitoring and audit purposes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '17

21 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #123 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Magnus Enger from comment #122) > (In reply to Josef Moravec from comment #121) > > Sorry David, after applying all 3 dependencies on current master I get this > > when applying first patch of this bug: > > > > error: sha1 information is lacking or useless (debian/scripts/koha-create). > > error: could not build fake ancestor > > I get more or less the same, but with a slightly different message: > > Applying: Bug 10662 - Build OAI-PMH Harvesting Client > fatal: sha1 information is lacking or useless (debian/scripts/koha-create). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. > Patch failed at 0001 Bug 10662 - Build OAI-PMH Harvesting Client I get a different message yet again: Using index info to reconstruct a base tree... M debian/scripts/koha-create Falling back to patching base and 3-way merge... Auto-merging debian/scripts/koha-create CONFLICT (content): Merge conflict in debian/scripts/koha-create error: Failed to merge in the changes. Patch failed at 0001 Bug 10662 - Build OAI-PMH Harvesting Client The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10662---Build-OAI-PMH-Harvesting-Client-s_47Bl.patch So it looks like a merge conflict... which is interesting since my dev branch rebases just fine against master. I must've mucked up another commit locally during a rebase. I'll fix this in a sec. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64477|0 |1 is obsolete| | --- Comment #35 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 64478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64478&action=ed… Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '17

20 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61660|0 |1 is obsolete| | --- Comment #34 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 64477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64477&action=ed… Bug 14567: Add a browse interface to the OPAC This is an interface for quick and efficient browsing through records. It presents a page at /cgi-bin/koha/opac-browse.pl that allows you to enter the prefix of an author, title, or subject and it'll give you a list of the options that match that. You can then scroll through these and select the one you're after. Selecting it provides a list of records that match that particular search. To Test: 1 - Have ES running and some records in it 2 - Browse to http://localhost:8080/cgi-bin/koha/opac-browse.pl (or url for your site) 3 - Test searching for author, title, and subject 4 - Verify that results are returned in expected order 5 - Experiment with fuzziness 6 - Click any result and verify specific titles are correct 7 - Click through title to record and verify it is the correct record -- You are receiving this mail because: You are watching all bug changes.

1 0