June 2017 - Koha-bugs - lists.koha-community.org

[Bug 13895] REST API: Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '17

16 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add API routes for |REST API: Add API routes |checkouts retrieval and |for checkouts retrieval and |renewal |renewal -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add API routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '17

16 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Could not find "../x-primitives.json#/branchcode" (../x-primitives.json#/branchcode). Typo in schema "api/v1/swagger/definitions/checkout.json"? at JSON/Validator.pm line 229. # Looks like your test exited with 255 before it could output anything. This branchcode is not in api/v1/swagger/x-primitives.json ?? And a small bonus from qa tools: FAIL t/db_dependent/api/v1/checkouts.t FAIL forbidden patterns forbidden pattern: tab char (line 190) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18749] New: xt/sample notices fails with "No sample notice to delete"
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Bug ID: 18749 Summary: xt/sample notices fails with "No sample notice to delete" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: ldjamison(a)marywood.edu QA Contact: gmcharlt(a)gmail.com Testing xt/sample_notices.t results in 11 test failures of "No sample notice to delete". -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 17367] New: Showing all items must keep show holdings tab in OPAC details
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17367 Bug ID: 17367 Summary: Showing all items must keep show holdings tab in OPAC details Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: fridolin.somers(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #366 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- There are some things very wrong here: 1/ last author in doc/history.txt is Patricio Marrone But I do not see it on about.pl 2/ `grep git log v16.11.00..origin/master --format="%aN" --reverse|sort|uniq` returns authors since 16.11.00, I picked one randomly and found "Oliver Bock", he is not in author list (history.txt or about.tt) Could someone write a script to fix everything please? I have already a RM script to alert me when a new author will have a patch pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13452] Average checkout report always uses biblioitems.itemtype
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Attachment #63322|0 |1 is obsolete| | Attachment #63323|0 |1 is obsolete| | Attachment #63324|0 |1 is obsolete| | Attachment #64304|0 |1 is obsolete| | Attachment #64305|0 |1 is obsolete| | Attachment #64306|0 |1 is obsolete| | Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64304&action=ed… Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64305&action=ed… Bug 13452: Fix for plack Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64306&action=ed… Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64307&action=ed… Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg(a)gmail.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64308&action=ed… Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) Signed-off-by: Srdjan <srdjan(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #23 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64309&action=ed… Bug 13452: Fix for plack Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #24 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11235] Names for reports and dictionary are cut off when quotes are used
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11235 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64164|0 |1 is obsolete| | Status|Signed Off |Passed QA CC| |kyle(a)bywatersolutions.com Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 64324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64324&action=ed… Bug 11235: Names for reports and dictionary are cut off when quotes are used To reproduce for saved reports: - Go to Home > Reports > Guided reports wizard - Create a report with double quotes in it's name, e.g. 'My "double quoted" report' - Go to "Saved reports", locate in the list the new report (name is correct here, is correct in database as well) - From the selection button at the right choose "Edit" - Result: Content of edit field for the report name is truncated (displays only: 'My') To reproduce for Reports dictionary: - Go to Home > Reports > Guided reports wizard - Create a new definition, give it the name 'The "double quoted" definition' and enter a text with double quotes for "Description" - Save - Verify that in the list of definitions both name and descriptions are truncated (in database as well) To test: - Apply patch - Verify that issues described above can no longer be reproduced Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5471] Quotes in tags cause moderation approval/rejection to fail
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5471 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Passed QA |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, did you forget to attach your signoff patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison <ldjamison(a)marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64346|0 |1 is obsolete| | --- Comment #21 from Lee Jamison <ldjamison(a)marywood.edu> --- Created attachment 64350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64350&action=ed… [SIGNED-OFF] Bug 2696 - Fine Payments Should Show What Was Paid For Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Running updatedatabase.pl after patch application makes dependencies happy. Passes QA Tools and works as intended. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '17

15 Jun '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Lee Jamison <ldjamison(a)marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64345|0 |1 is obsolete| | --- Comment #20 from Lee Jamison <ldjamison(a)marywood.edu> --- Created attachment 64346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64346&action=ed… [SIGNED-OFF]Bug 2696: Payments Shows What Paid For Test Plan: 1) Apply this patch and its' dependencies 2) Create and pay some various fees and fines 3) View the payments for fees, and fees paid by payments by using the new 'Details' button available on boraccount.pl Signed-off-by: Lee Jamison <ldjamison(a)marywood.edu> Running updatedatabase.pl after patch application makes dependencies happy. Passes QA Tools and works as intended. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0