August 2017 - Koha-bugs - lists.koha-community.org

[Bug 19013] New: sample_data.sql inserts patrons with guarantorid that do not exist
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19013 Bug ID: 19013 Summary: sample_data.sql inserts patrons with guarantorid that do not exist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org MariaDB [koha_kohadev]> select borrowernumber, guarantorid from borrowers where guarantorid is not null; +----------------+-------------+ | borrowernumber | guarantorid | +----------------+-------------+ | 6 | 102 | | 7 | 104 | | 8 | 112 | | 15 | 131 | | 18 | 160 | | 21 | 177 | | 30 | 254 | | 35 | 287 | | 36 | 288 | | 37 | 289 | | 40 | 320 | | 42 | 337 | +----------------+-------------+ MariaDB [koha_kohadev]> select max(borrowernumber) from borrowers; +---------------------+ | max(borrowernumber) | +---------------------+ | 50 | +---------------------+ That breaks randomly tests on Jenkins (Koha/Patrons.t) # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 85. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 0 guarantee' # at t/db_dependent/Koha/Patrons.t line 88. # got: '1' # expected: '0' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 95. # got: '3' # expected: '2' # Failed test 'new_patron_1 should have 2 guarantees' # at t/db_dependent/Koha/Patrons.t line 98. # got: '3' # expected: '2' # Looks like you failed 4 tests of 8. # Failed test 'guarantees' # at t/db_dependent/Koha/Patrons.t line 100. # Failed test 'Delete should have deleted the patron' # at t/db_dependent/Koha/Patrons.t line 905. # got: '51' # expected: '52' # Looks like you failed 2 tests of 22. [16:26:26] t/db_dependent/Koha/Patrons.t ................................ -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 17940] New: Holds not going to waiting state after having been transferred
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17940 Bug ID: 17940 Summary: Holds not going to waiting state after having been transferred Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: stefan.berndtsson(a)ub.gu.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com We seem to have found an issue with holds after transfers. Steps to reproduce (everything done by staff): Allow for On shelf holds. Have library branch A and B. Have one biblio with one item located at library A. Have one patron able to have holds placed on them. 1. Place a hold on biblio for patron, select pickup at library B. 2. Check in item on library A (get a transfer notice). 3. Check in item on library B (another transfer notice). 4. Item is not waiting properly on pickup location. If pickup was set to library A (same as item), it would be properly set to waiting. Expected outcome would be that the item is set to waiting at library B. After step 1, the reserves table contains "NULL" in "found" column. After step 2, "found" contains "T" After step 3, "found" still contains "T", where it should really contain "W". This has been tested with both 16.11.00 and 16.11.01. Thank you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 22

[Bug 18438] New: Check in: Modal about holds hides important check in messages
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438 Bug ID: 18438 Summary: Check in: Modal about holds hides important check in messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com To reproduce: - Have a patron X who has an item checked out where an other patron has a hold on it - Make sure patron X triggers a message while checking in (e.g. add a manual fine, add a manual restriction) - Check the item in on Home > Circulation > Check in (/koha/circ/circulation.pl) Result: A modal window appears that hides the messages about fines, restriction. 'Confirm hold' triggers the check-in; librarians have noch chance to see the other messages. Introduced by Bug 11360. See also comment #20 on Bug 11360 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360#c20 "If a checkin triggers the modal, any messages or alerts which were also triggered by the checkin will be hidden by the modal and will disappear after clearing the modal. For instance: A warning that the item was not checked out, or a checkin message which has been configured for that particular item type." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 54

[Bug 16911] New: Koha::Patrons - Move ExtendMemberSubscriptionTo to -> extend_subscription
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '17

24 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911 Bug ID: 16911 Summary: Koha::Patrons - Move ExtendMemberSubscriptionTo to ->extend_subscription Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The goal of these patches will be to move the 2 subroutines GetExpiryDate and ExtendMemberSubscriptionTo to the 2 methods of Koha::Patron::Category->get_expiry_date and Koha::Patron->get_expiry_date This way, we will have a nice code like my $patron = Koha::Patrons->find( 42 ); $patron->move_to_deleted; # From bug 16907 $patron->delete; # Which will handle the different deletion to do before deleting a patron -- You are receiving this mail because: You are watching all bug changes.

1 52

[Bug 18721] New: C4::Installer uses Koha::Database instead
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18721 Bug ID: 18721 Summary: C4::Installer uses Koha::Database instead Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org C4::Installer->new() duplicates code from Koha::Database->_new_schema() Fixing by making C4::Installer get the db connection the normal way. TEST PLAN: use misc/devel/populate_db.pl or installer/install_automatic.pl whichever you have to deploy the default database. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 18541] New: Bug 18465 - Patron card creator: Add a grid to support layout design
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18541 Bug ID: 18541 Summary: Bug 18465 - Patron card creator: Add a grid to support layout design Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org In patron card creator, the layout tool has already a guide box that shows the position of a card on the page. The aim of this enhancement is to support the design process with an additonal layout grid to figure out the positions of text fields, barcode and images. -- You are receiving this mail because: You are watching all bug changes.

1 43

[Bug 18739] New: Add SVG version of staff-home-icons-sprite image
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18739 Bug ID: 18739 Summary: Add SVG version of staff-home-icons-sprite image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org In misc/interface_customization we have a Photoshop file from which staff-home-icons-sprite.png was generated. It would be better to provide an SVG file. SVG is more flexible and non-proprietary. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 18149] New: Move CountUsage calls to Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18149 Bug ID: 18149 Summary: Move CountUsage calls to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Built on top of bug 9988, that introduces Koha::Authority::get_usage_count. -- You are receiving this mail because: You are watching all bug changes.

1 22

[Bug 18810] New: Update Font Awesome to 4.7.0
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18810 Bug ID: 18810 Summary: Update Font Awesome to 4.7.0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: Needs Signoff Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Patch complexity: Small patch Status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19059] New: Move C4::Reserves::CancelReserve to the Koha::Hold-> cancel
by bugzilla-daemon＠bugs.koha-community.org 23 Oct '17

23 Oct '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19059 Bug ID: 19059 Summary: Move C4::Reserves::CancelReserve to the Koha::Hold->cancel Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19058 Blocks: 17728 Let's move C4::Reserves::CancelReserve code to Koha::Hold->cancel Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19058 [Bug 19058] Move C4::Reserves::GetReserveId to Koha::Holds -- You are receiving this mail because: You are watching all bug changes.

1 37