August 2017 - Koha-bugs - lists.koha-community.org

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65645|0 |1 is obsolete| | --- Comment #83 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 66390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66390&action=ed… Bug 14826 - Unit Tests Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65644|0 |1 is obsolete| | --- Comment #82 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 66389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66389&action=ed… Bug 14826 - Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65643|0 |1 is obsolete| | --- Comment #81 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 66388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66388&action=ed… Bug 14826 - Add Koha modules for offsets Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14826] Resurrect account offsets table
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65642|0 |1 is obsolete| | --- Comment #80 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 66387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66387&action=ed… Bug 14826 - Update database Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don' t work as expected
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 John Sterbenz <jsterben(a)umich.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsterben(a)umich.edu -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15239] Add multiple items fail on barcode
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Ruben Norori <kachomanic(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Ruben Norori <kachomanic(a)gmail.com> --- Hi Tomás. Thank for your suggestion, try the long way because I didn't know another solution, but I will try your recomendation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #152 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Hi Tomás, (In reply to Tomás Cohen Arazi from comment #150) > Hi guys, I've been looking at this patchset without trying it yet. > Everything looks as expected :-D > The only thing I would like to mention is that the auth chain added a check > for maintenance mode (usually on upgrades) that requires some more error > codes to be added to the spec. Can you please take a look at (say) > patrons.json from bug 18137? It's pretty straightforward. I believe I have added a patch now that implements what you requested. Feel free to let me know if you think I missed something! Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #151 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 66381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66381&action=ed… Bug 11897: Follow up: Add more error conditions. * api/v1/swagger/paths/rotas.json: Add 401, 500 & 503 error conditions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15239] Add multiple items fail on barcode
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Hi Ruben, (In reply to Ruben Norori from comment #9) > I have the definitive solution: > First we must add two new procedures, functions, methods, which consult in > the database the registry homebranch. I didn't go deep into the problem you're trying to solve, but I suggest you don't introduce new subs, but use the current api instead. We have a (sort of) DAO class called Koha::Items that exposes a ->search method, which returns Koha::Item objects. So you can simply do something like this: use Koha::Items; my $item = Koha::Items->find( $barcode ); ->find gets an id column to find the row and create the object. 'barcode' is a unique key, so this works. Now you have a Koha::Item object, representing the item with the passed barcode. You can then use it like: my $homebranch = $item->homebranch; Hope it clarifies! This conversations are easier on the koha-devel list or on the IRC channel. -- You are receiving this mail because: You are watching all bug changes.

1 0