August 2017 - Koha-bugs - lists.koha-community.org

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #64 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Well did not think of that... It should be limited by resources available, not the application itself. It should... I'm quite sure this will never see the light of day (although I did get it going), just too hard. However, I want to keep it alive for various reasons. The main one is: the fact that this *is* too hard tells that we are doing some things fundamentally wrong. Workarounds devised here (and most of it is exactly that - workarounds) should help understanding the problems better. Koha is being heavily optimised for the container per site scenario, but "abstractly thinking" I don't see why we should not be able to share the code. In a real world scenario you could imagine a cluster of small poor schools benefiting from that. One day we will get rid of C4 and re-engineer Context, no CGI .pl... Maybe even move to static pages and API... Then this will become obsolete. But good to have it as a reference, until that happens. And thanks for your wishes :) Public transport is useful even when it's horrible. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #63 from David Cook <dcook(a)prosentient.com.au> --- I keep thinking about this abstractly when I'm waiting for public transport, and still wishing you all the best Srdjan. I keep wondering what the threshold is for number of Koha sites on a single Plack server... I suppose a person would use Apache or Nginx as the reverse proxy (so many virtual hosts configured there) and have them funneling traffic to a particular Plack server (or servers I suppose if we wanted to scale up)? Anyway, Srdjan++. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60726|0 |1 is obsolete| | --- Comment #62 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66377&action=ed… bug_15562: Removed Koha::Caches->get_instance() There should be no cache singletons, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Caches->get_instance() is replaced with C4::Context->cache. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60725|0 |1 is obsolete| | --- Comment #61 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66376&action=ed… bug_15562: Multi-host helper for plack installations Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context() and restore_context() are synched with database set_schema() and restore_schema(). Created run_within_context() that wraps set_context() and restore_context() around code. * Created Koha::Handler::Plack* to facilitate running same code within different (database) contexts. * This initial version does not run with memcached turned on. Next patch will correct that. https://bugs.koha-community.org/show_bug.cgi?id=15562 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60724|0 |1 is obsolete| | --- Comment #60 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66375&action=ed… [SIGNED-OFF] bug_15562: Revert "Bug 13690: use Koha::Schema only when it's needed" This reverts commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc. I don't see any place where we would use KOha::Database without wanting Koha::Schema. require Koha::Schema interferes with some plack setups - for some reason it calls C4::Context->import() even when C4::Context is already used. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60723|0 |1 is obsolete| | --- Comment #59 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66374&action=ed… [SIGNED-OFF] bug_15562: Use do() rather than system() to execute updatedatabase.pl from installer.pl That way: * no external process is spawned * code executes in the same perl process, which is required for plack multi-site I have a dream. A dream that one day all code from .pl's will be in some .pm's. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #109 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66372&action=ed… Bug 14385: Corrected opac-details searchResult call -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15239] Add multiple items fail on barcode
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Ruben Norori <kachomanic(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15239] Add multiple items fail on barcode
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 --- Comment #9 from Ruben Norori <kachomanic(a)gmail.com> --- I have the definitive solution: First we must add two new procedures, functions, methods, which consult in the database the registry homebranch. #Original function sub get_item_from_barcode { my ($barcode)=@_; my $dbh=C4::Context->dbh; my $result; my $rq=$dbh->prepare("SELECT itemnumber from items where items.barcode=?"); $rq->execute($barcode); ($result)=$rq->fetchrow; return($result); } #New function sub get_home_from_barcode { my ($barcode)=@_; my $dbh=C4::Context->dbh; my $result; my $rq=$dbh->prepare("SELECT homebranch from items where items.barcode=?"); $rq->execute($barcode); ($result)=$rq->fetchrow; return($result); } #New function sub get_home_from_item { my ($barcode)=@_; my $dbh=C4::Context->dbh; my $result; my $rq=$dbh->prepare("SELECT homebranch from items where items.itemnumber=?"); $rq->execute($barcode); ($result)=$rq->fetchrow; return($result); } Then call the functions and save the result in a variable that we concate at the final result, also add an "if" to use one function in the first iteration and the other function executes it in the "else". for (my $i = 0; $i < $number_of_copies;) { # If there is a barcode if ($barcodevalue) { # Getting a new barcode (if it is not the first iteration or the barcode we tried already exists) # For execute only in the first iteration if($i<1){ # Call new function my $newv = get_home_from_item($exist_itemnumber); $barcodevalue = $newv.$barcodeobj->next_value($oldbarcode) if ($i > 0 || $exist_itemnumber); }else{ # Call new function my $exin = get_home_from_barcode($barcodevalue); $barcodevalue = $exin.$barcodeobj->next_value($oldbarcode) if ($i > 0 || $exist_itemnumber); } # Putting it into the record if ($barcodevalue) { $record->field($tagfield)->update($tagsubfield => $barcodevalue); } -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |tomascohen(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0