August 2017 - Koha-bugs - lists.koha-community.org

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18947 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #66 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- > but then we're also keeping all the data for all the > different sites accessible in memory by the same process which could allow > things to leak across if we're not careful (booo). That was exactly my point with Context. There should be no references to *anything* external (db, cache etc handles) outside Context. Now because we are still in this CGI frame of mind, we have all this horrible singletons. Once we are able to instantiate contexts and keep them in app containers, and pass them to request handlers we will be safe. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #65 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Srdjan Jankovic from comment #64) > Well did not think of that... It should be limited by resources available, > not the application itself. It should... > I suppose I was just thinking in terms of any leaks, but hopefully it won't leak anywhere! > I'm quite sure this will never see the light of day (although I did get it > going), just too hard. However, I want to keep it alive for various reasons. > The main one is: the fact that this *is* too hard tells that we are doing > some things fundamentally wrong. Workarounds devised here (and most of it is > exactly that - workarounds) should help understanding the problems better. > Koha is being heavily optimised for the container per site scenario, but > "abstractly thinking" I don't see why we should not be able to share the > code. In a real world scenario you could imagine a cluster of small poor > schools benefiting from that. > Well, I was thinking about that from a security perspective. At the moment, we're already sharing the code, but since it's CGI it loads it up in separate processes on the fly. If we're using multiple sites with Plack managed by a single process, then we're loading the code into memory once (yay for efficiency!) but then we're also keeping all the data for all the different sites accessible in memory by the same process which could allow things to leak across if we're not careful (booo). It would be too bad if this didn't see the light of day since I imagine there would be lots of people wanting to host multiple Koha instances with the same Plack instance, but I do wonder a bit how feasible it would be, although surely people do it with other apps or URLMap wouldn't exist, yeah? Actually, I've been thinking about Tomcat a bit lately as well. I reckon it would work similarly to Plack. You define a number of URL routes and then specify the code that you want to run for each route. So you can have lots of Java apps running under the same single Tomcat instance. I don't know how it separates them so that they don't overlap of course. I suppose Tomcat might do it by virtue of Java apps being written to be run on Tomcat whereas we've been shoehorning Koha to work with Plack. > One day we will get rid of C4 and re-engineer Context, no CGI .pl... Maybe > even move to static pages and API... Then this will become obsolete. But > good to have it as a reference, until that happens. > > And thanks for your wishes :) Public transport is useful even when it's > horrible. I've been thinking for a while how nice it would be to separate the staff client and the OPAC. If I'm not mistaken, there are far fewer OPAC scripts than Staff Client scripts, so in theory writing a new OPAC would be easier than writing a new staff client. So we could build a new OPAC from the ground up that works with Plack natively. I figure library patrons should probably be the ones that demand the best performance, so why not start there, yeah? (Alternatively, if a separate OPAC is possible, it wouldn't even necessarily have to be written in Perl. Also, if we used APIs, we could use static pages with Javascript or people could access the APIs from their own websites and then we don't even have to worry about providing an OPAC - just maintaining the API.) Then maybe once the OPAC is separated out, we could work on overhauling the staff client bit by bit. That's my pie in the sky dream ;). Alas, I have too much other work to do, but it's a dream I have nonetheless... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #64 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Well did not think of that... It should be limited by resources available, not the application itself. It should... I'm quite sure this will never see the light of day (although I did get it going), just too hard. However, I want to keep it alive for various reasons. The main one is: the fact that this *is* too hard tells that we are doing some things fundamentally wrong. Workarounds devised here (and most of it is exactly that - workarounds) should help understanding the problems better. Koha is being heavily optimised for the container per site scenario, but "abstractly thinking" I don't see why we should not be able to share the code. In a real world scenario you could imagine a cluster of small poor schools benefiting from that. One day we will get rid of C4 and re-engineer Context, no CGI .pl... Maybe even move to static pages and API... Then this will become obsolete. But good to have it as a reference, until that happens. And thanks for your wishes :) Public transport is useful even when it's horrible. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 --- Comment #63 from David Cook <dcook(a)prosentient.com.au> --- I keep thinking about this abstractly when I'm waiting for public transport, and still wishing you all the best Srdjan. I keep wondering what the threshold is for number of Koha sites on a single Plack server... I suppose a person would use Apache or Nginx as the reverse proxy (so many virtual hosts configured there) and have them funneling traffic to a particular Plack server (or servers I suppose if we wanted to scale up)? Anyway, Srdjan++. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60726|0 |1 is obsolete| | --- Comment #62 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66377&action=ed… bug_15562: Removed Koha::Caches->get_instance() There should be no cache singletons, full stop. If Koha is to move away from .pl scripts that is. As an interim measure Koha::Caches->get_instance() is replaced with C4::Context->cache. In that respect it will continue to work in the singleton-ish way if context is used as a singleton, but supports cache-per-context. Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60725|0 |1 is obsolete| | --- Comment #61 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66376&action=ed… bug_15562: Multi-host helper for plack installations Sort of an apocalypse * C4::Context->new() must be called with at least config file param. If you want current context, call C4::Context->current(). C4::Context->some_method() will still work as is. * Koha::Database->new_schema() now takes optional context param. * C4::Context->set_context() and restore_context() are synched with database set_schema() and restore_schema(). Created run_within_context() that wraps set_context() and restore_context() around code. * Created Koha::Handler::Plack* to facilitate running same code within different (database) contexts. * This initial version does not run with memcached turned on. Next patch will correct that. https://bugs.koha-community.org/show_bug.cgi?id=15562 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60724|0 |1 is obsolete| | --- Comment #60 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66375&action=ed… [SIGNED-OFF] bug_15562: Revert "Bug 13690: use Koha::Schema only when it's needed" This reverts commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc. I don't see any place where we would use KOha::Database without wanting Koha::Schema. require Koha::Schema interferes with some plack setups - for some reason it calls C4::Context->import() even when C4::Context is already used. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15562] Make Koha more suitable for shared hosting with plack
by bugzilla-daemon＠bugs.koha-community.org 23 Aug '17

23 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562 Srdjan Jankovic <srdjan(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60723|0 |1 is obsolete| | --- Comment #59 from Srdjan Jankovic <srdjan(a)catalyst.net.nz> --- Created attachment 66374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66374&action=ed… [SIGNED-OFF] bug_15562: Use do() rather than system() to execute updatedatabase.pl from installer.pl That way: * no external process is spawned * code executes in the same perl process, which is required for plack multi-site I have a dream. A dream that one day all code from .pl's will be in some .pm's. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 22 Aug '17

22 Aug '17

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #109 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 66372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66372&action=ed… Bug 14385: Corrected opac-details searchResult call -- You are receiving this mail because: You are watching all bug changes.

1 0