January 2018 - Koha-bugs - lists.koha-community.org

[Bug 19820] New: Add unsafe param to GetMarcSubfieldStructure
by bugzilla-daemon＠bugs.koha-community.org 27 Jun '18

27 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19820 Bug ID: 19820 Summary: Add unsafe param to GetMarcSubfieldStructure Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org GetMarcStructure has an "unsafe" param for faster cache retrieval, I have looked through all the instances where GetMarcSubfieldStructure is called, and seems to me it's safe to call get_from_cache with the "unsafe" option also in those cases. While profiling Koha I found that quite some time was actually spent deserializing MarcSubfieldStructure-hashes (that are usually pretty big), actually around 7% of total time while indexing biblios for example. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 28

[Bug 19921] New: Error when updating child to adult patron on system with only one adult patron category
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '18

26 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Bug ID: 19921 Summary: Error when updating child to adult patron on system with only one adult patron category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Blocks: 19641 To reproduce this bug you must test in a system which has only one patron category of the "adult" type. View the details of a patron with a child-type patron category and choose More -> Update child to adult patron. This results in an error: Can't call method "category_type" on an undefined value at /home/vagrant/kohaclone/members/update-child.pl line 84. The URL of the error page shows a problem with the parameters being passed: members/update-child.pl?op=update&borrowernumber=12345&catcode=Koha::Patron::Category=HASH(0xa168a18)&catcode_multi= Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 17685] New: Allow to receive double issues in serials
by bugzilla-daemon＠bugs.koha-community.org 21 Jun '18

21 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17685 Bug ID: 17685 Summary: Allow to receive double issues in serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: rbit(a)rbit.cz QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Sometimes we need to receive double issues of serials. In fact it results in a changed numbering of the first issue from "10/2016" to "10-11/2016". The other issue "11/2016" should get "not available" status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 15771] New: CGI::escapeHTML should not be used anymore
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 Bug ID: 15771 Summary: CGI::escapeHTML should not be used anymore Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 13618 In admin/auth_subfields_structure.pl, admin/marc_subfields_structure.pl and catalogue/image.pl, the pl script escapes html characters. Since bug 13618 has been pushed, this method should not be used anymore. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 15773] New: Checkboxes does not work correctly when creating a new subfield for an authority framework
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15773 Bug ID: 15773 Summary: Checkboxes does not work correctly when creating a new subfield for an authority framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Depends on: 15771 When creating a new subfield for an authority framework, the checkboxes don't behave as they should. If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's label, the checkbox from the second tab will be checked/unchecked. This is caused by a non-unique id of the input element. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15771 [Bug 15771] CGI::escapeHTML should not be used anymore -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 18268] New: Notices no longer sent; resending when Patron Messaging Preference changed
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '18

20 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18268 Bug ID: 18268 Summary: Notices no longer sent; resending when Patron Messaging Preference changed Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: cgdavis(a)uintah.utah.gov QA Contact: testopia(a)bugs.koha-community.org A patron’s Koha account had a address within its primary email address field and all patron messaging preferences were enabled (including the “Digests only” preferences), and yet, after a time, Koha failed to send notices to the patron’s email address. It was confirmed when checking the “Notices sent for [patron name] ([patron barcode])” tab on the patron’s account that Koha stopped sending notices to the patron’s email address. The email addresses of another patron account with the same patron messaging preference within this Koha system received notices from Koha. Koha began re-sending notices to the patron email address when the “Item checkout” patron messaging preference was disabled and then re-enabled. This is on Koha 3.22.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 16767] New: OPAC suggestions, existing suggestions don't show after placing a suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Jun '18

16 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767 Bug ID: 16767 Summary: OPAC suggestions, existing suggestions don't show after placing a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org After placing a purchase suggestion on the opac the confirmation screen reads: "Your suggestion has been submitted. There are no pending purchase suggestions." Place another, same result. These lines in opac-suggestions.pl don't seem to be working as intended: 136 ^I^I$$suggestion{$_}='' foreach qw<title author publishercode copyrightdate place collectiontitle isbn STATUS>; 137 ^I^I$suggestions_loop = 138 ^I^I &SearchSuggestion( $suggestion ); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 8

[Bug 19956] New: Adjusting fine block on SIP connected self-check - Coffeyville
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '18

15 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19956 Bug ID: 19956 Summary: Adjusting fine block on SIP connected self-check - Coffeyville Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse(a)bywatersolutions.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org 1) Add a new parameter "ignore_AllFinesNeedOverride" to SIP2 config on a per-account basis -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 18850] New: Clone as dependency?
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '18

15 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18850 Bug ID: 18850 Summary: Clone as dependency? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: veron(a)veron.ch QA Contact: testopia(a)bugs.koha-community.org Clone is used by Koha but does not appear on the dependencies list (Home > About Koha >Perl modules) $ git grep 'use Clone' C4/SIP/t/02patron_info.t:use Clone qw(clone); C4/SIP/t/03checkout.t:use Clone qw(clone); C4/SIP/t/04patron_status.t:use Clone qw(clone); C4/SIP/t/05block_patron.t:use Clone qw(clone); C4/SIP/t/06patron_enable.t:use Clone qw(clone); C4/SIP/t/07hold.t:use Clone qw(clone); C4/SIP/t/08checkin.t:use Clone qw(clone); C4/SIP/t/09renew.t:use Clone qw(clone); C4/SIP/t/10renew_all.t:use Clone qw(clone); C4/SIP/t/11item_info.t:use Clone qw(clone); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 18497] New: Downloading a report passes the constructed SQL as a parameter
by bugzilla-daemon＠bugs.koha-community.org 15 Jun '18

15 Jun '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18497 Bug ID: 18497 Summary: Downloading a report passes the constructed SQL as a parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This is not ideal, long queries can cause broken links and is a very messy link. report/guided_reports.pl line 816: my $sql = $input->param('sql'); # FIXME: use sql from saved report ID#, not new user-supplied SQL! We use execute_query, so input is sanitized but links look awful http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phas… -- You are receiving this mail because: You are watching all bug changes.

1 26