October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #117 from David Gustafsson <glasklas(a)gmail.com> --- Pushed the schema changes and followed the convention in Bug 19482. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #116 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 81621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81621&action=ed… Bug 14957: DO NOT PUSH Schema changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #115 from David Gustafsson <glasklas(a)gmail.com> --- (In reply to Cori Lynn Arnold from comment #114) > Applied fine, but there were runtime errors: > > 5. You should see a new link "MARC field permissions" in the "Catalog" > section under "Koha administrtion". > --> Link Changed to "MARCMergeRules" > > 7. Next to the page heading ("Manage MARC field permissions") there is a > button with a question mark, click this r more information about the > rule system. > --> Link labeled "MARC merge rules" > --> Page throws error > "DBIx::Class::Schema::source(): Can't find source for MarcMergeRule at > /home/vagrant/kohaclone/Koha/Objects.pm line 341 > at /usr/share/perl5/DBIx/Class/Exception.pm line 77" > > --cori lynn Regarding the commit message I'm a little bit confused about how to handle. If I edit the commit message for the first commit it no longer reflect the changes for that commit, on the other hand the "To test" is partly outdated, so perhaps it should have been rewritten in the "Bug 14957 - Refactor and fix tests and documentation"-patch. It seems the local help feature has been removed in Bug 19817, so work is needed to move it into the manual instead? Regarding the "DBIx::Class::Schema::source()" I think you need to run the "misc/devel/update_dbix_class_files.pl" script to regenerate the Schema-files, as those are not to be included in the patch. Perhaps there is a convention to include them an attachment anyway, see if I can find an example of such a bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Cori Lynn Arnold <carnold(a)dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #114 from Cori Lynn Arnold <carnold(a)dgiinc.com> --- Applied fine, but there were runtime errors: 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". --> Link Changed to "MARCMergeRules" 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this r more information about the rule system. --> Link labeled "MARC merge rules" --> Page throws error "DBIx::Class::Schema::source(): Can't find source for MarcMergeRule at /home/vagrant/kohaclone/Koha/Objects.pm line 341 at /usr/share/perl5/DBIx/Class/Exception.pm line 77" --cori lynn -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #36 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to David Cook from comment #35) > (In reply to Tomás Cohen Arazi from comment #34) > > This is worth discussing in koha-devel, and IRC meeting or Marseille, but I > > think we should have a job queue in the lines of what David proposes. And I > > would add maybe the use of ZeroMQ to possibly notify other services. > > I agree about opening up the discussion in another forum like koha-devel, > IRC, or Marseille. > > I'm intrigued by the use of ZeroMQ. How do you see that working, Tomás? When > I first started thinking about background processing, I thought using a > message queue would be a good idea. Since then, I've used an embedded > ActiveMQ with the Fedora repository a bit, but that publishes notifications > about record changes. Celery uses a message queue for sending out tasks and > then it can use a backend like Redis for storing task results. > > I think if we use a database for a job queue, that would replace the message > queue? Or are you meaning using a message queue for notifying other services > like an indexer that there are imported records to index? I need to implement a way to hook record/item updates so changes are pushed to an external service. Ideally through the use of plugins so a more generic job queue was the first thing to consider. Then if we replace (say) rebuild_zebra.pl -d with this, we should add a way to inject new 'tasks' derived from this events (so a record update should trigger a zebra/ES indexing step, and also look for things (plugins) that would require actions. It felt simpler if it just sent broadcast messages through a socket to any service listening there. I like ZeroMQ because it doesn't need a server, you just use your own service. So, one event => multiple actions. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78413|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- Created attachment 81615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81615&action=ed… Bug 10442: Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. Signed-off-by: Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18927] New: koha-rebuild-zebra -f -v koha
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18927 Bug ID: 18927 Summary: koha-rebuild-zebra -f -v koha Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: jef(a)dias.ie QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Using Debian packages: koha:~# dpkg -l | grep koha ii koha-common 17.05.01-1 all integrated (physical) library management system ii libcgi-session-driver-memcached-perl 0.04-1koha2 all Perl module to allow CGI sessions to be stored in memcache ii libconvert-basen-perl 0.01-1koha1 all perl module for encoding and decoding of base{2,4,8,16,32,64} strings ii libdbix-runsql-perl 0.14-1~koha1 all module to run an SQL file via a DBI handle ii libjson-validator-perl 0.67+dfsg-1~koha1 all module to validate data against a JSON schema ii libmarc-record-perl 2.0.6-1koha1 all Perl extension for handling MARC records ii libmojolicious-perl 6.15+dfsg-1~koha1 all simple, yet powerful, Web Application Framework ii libpdf-fromhtml-perl 0.31-1~koha1 all module to convert HTML documents to PDF ii libpdf-reuse-perl 0.36-1koha1 all Reuse and mass produce PDF documents ii libpdf-writer-perl 0.06-1~koha1 all PDF writer abstraction layer ii libswagger2-perl 0.77-1~koha1 all Perl module for generating, parsing and transforming swagger API documentation ii libtemplate-plugin-htmltotext-perl 0.03-1koha1 all Plugin interface to HTML::FormatText ii libtemplate-plugin-json-escape-perl 0.2-1koha1 all module for embedding JSON strings in Template Toolkit ii libtemplate-plugin-stash-perl 1.006-1~koha1 all Template::Toolkit plugin that exposes the template's stash # koha-rebuild-zebra -f -v koha returns a lot of errors: [...] error retrieving biblio 94540 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94541 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94542 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94543 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94544 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94545 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94546 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94547 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94548 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. error retrieving biblio 94549 at /usr/share/koha/bin/migration_tools/rebuild_zebra.pl line 683, <DATA> line 751. [...] Although the 'use' is clearly defined: use C4::Biblio; specifying the full perl library/function name in those 2 files fixes it: for p in /usr/share/koha/bin/migration_tools/rebuild_zebra.pl /usr/share/koha/lib/C4/Items.pm; do for f in GetMarcFromKohaField GetMarcBiblio GetBiblionumberFromItemnumber TransformKohaToMarc GetFrameworkCode; do sed -i -e "s/$f/C4::Biblio::$f/g" $p done done -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 14716] Correctly URI-encode URLs in XSLT result lists and detail pages
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #72 from David Cook <dcook(a)prosentient.com.au> --- Cheers for working on this Ere! I was going to suggest using XML::LibXSLT::register_function() to solve this problem, which I've done locally for years, but your comment reminded me of EXSLT! That seems like an easier way to do it. A while ago, I actually ended up using EXSLT in DSpace since Apache Xalan supports it and I needed some extension features. It's a very interesting read: http://exslt.org/. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13812] Facet links broken because double-quotes are not URL encoded
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21526 -- You are receiving this mail because: You are watching all bug changes.

1 0