October 2018 - Koha-bugs - lists.koha-community.org

[Bug 7046] subscription renewal period should be a pull down
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7046 --- Comment #12 from Josef Moravec <josef.moravec(a)gmail.com> --- When you click on the button "Renew subscription", there is warning: Use of uninitialized value $subtype in string eq at /home/vagrant/kohaclone/C4/Serials.pm line 1468 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15395] Internationalization: plural forms, context, and more
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #129 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- > I don't love the sound of these patches... (or the implementation of Koha::I18N). What do you mean? > What's performance like for handling all the translations at run time? (Might not be a huge issue with template caching?) See this section and if you can, try on your machine so we have more data about performance impact. https://wiki.koha-community.org/wiki/Internationalization,_plural_forms,_co… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #59 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Thx for your patience and the quick rebase! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81606|0 |1 is obsolete| | --- Comment #58 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81650&action=ed… Bug 12365: (follow-up) Fixing broken circ rules table Adding filters to note to satisfy qa test tools Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81605|0 |1 is obsolete| | --- Comment #57 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81649&action=ed… Bug 12365: (follow-up) Putting backticks in atomicupdate Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81604|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81648&action=ed… Bug 12365: (follow-up) Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'View note' and the popover correctly displays note. View the note by hovering over the link I've moved the Note column so the popover displays nicely and doesn't cover the buttons. I've also changed the placement so that it doesn't cover information in the row. Update: Test that you can edit the note when clicking 'Edit' and that behaviour is the same for editing all other fields Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81603|0 |1 is obsolete| | --- Comment #55 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81647&action=ed… Bug 12365: Notes for rules This patch adds a note column to the circ and fine rules to act as a description line for the rule. To test: 1) Apply patch, update database (may have to also update schema) 2) Go to Admin -> Circ and fine rules 3) Scroll to the right, notice new Note column 4) Confirm it works to create a brand new rule with a Note 5) Confirm it works to modify an existing rule with a Note Sponsored-by: Catalyst IT Lee Jamison <ldjamison(a)marywood.edu> rescued this patch. It is a clean re-build of attachments 61865 and 63902 to fix the merge conflict introduced during application of both attachments. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: macon lauren KohaCon17 <caballeromaricon(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |katrin.fischer(a)bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 31 Oct '18

31 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81615|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81646&action=ed… Bug 10442: Remove references to non-standard "error" class The CSS for <div class="error"> is obsolete and should not be used. This patch removes the definition from the main CSS file and corrects instances of its use in the templates to the standard <div class="dialog alert">. To test: - In Acquisitions -> Late orders, locate an order from a vendor which doesn't have an email address. Selecting that order and clicking "Claim" should trigger an error dialog, "This vendor has no email." It should be styled correctly. - With AcqCreateItem set to "when placing an order," add to an existing order using the "From a new (empty) record" option. Add two items with identical barcodes and submit the form. A error should show at the top of the page. - With AcqCreateItem set to "when receiving an order," receive an order and add two items with identical barcodes. Submitting the form should trigger an error message at the top of the page. With the remaining cases I don't know how to trigger the errors in question, so a visual check of the changes may be required: - Administration -> Funds -> "You are not authorized to modify this fund" - Administration -> Search engine configuration (/admin/searchengine/elasticsearch/mappgings.pl) -> Various modification errors. - With the AutoEmailOpacUser preference set to "send," adding a patron without an email address can trigger an error, "This member has no email." - With plugins enabled, and installed, there are error messages displayed under various circumstances. Signed-off-by: Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0