October 2018 - Koha-bugs - lists.koha-community.org

[Bug 13812] Facet links broken because double-quotes are not URL encoded
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #11 from David Cook <dcook(a)prosentient.com.au> --- Ah Jonathan is all over this at #21526 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13812] Facet links broken because double-quotes are not URL encoded
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #10 from David Cook <dcook(a)prosentient.com.au> --- Just realized that Katrin's comment is from February 2017. I see there is a html filter on the OPAC template: <span class="facet-label"><a href="[% local_url | html %]" title="[% facet.facet_title_value | html %]">[% facet.facet_label_value | html %]</a></span> I have no idea why we're html escaping the URL... But it does seem to work... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13812] Facet links broken because double-quotes are not URL encoded
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #9 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #7) > I think we see this happen with single quotes in an author name in facets. > The name is: Kum'a N'dumbe. A keyword search for the name works, but when > you search au:Kum'a N'dumbe - no results. Same when you click on the facet > with this name: > > > /cgi-bin/koha/catalogue/search. > pl?idx=kw&q=kamerun&sort_by=relevance_dsc&limit=au:Kum'a N'dumbe, Alexandre This is the URL that appears for my facets in master: /cgi-bin/koha/opac-search.pl?idx=kw&q=test&sort_by=relevance_dsc&limit=au:Kum%27a%20N%27dumbe,%20Alexandre The URL works although it does look like the ampersands are being erroneously escaped as well... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13812] Facet links broken because double-quotes are not URL encoded
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812 --- Comment #8 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #7) > I think we see this happen with single quotes in an author name in facets. > The name is: Kum'a N'dumbe. A keyword search for the name works, but when > you search au:Kum'a N'dumbe - no results. Same when you click on the facet > with this name: > > > /cgi-bin/koha/catalogue/search. > pl?idx=kw&q=kamerun&sort_by=relevance_dsc&limit=au:Kum'a N'dumbe, Alexandre Thanks for that info. I'll try to reproduce this one, and see about writing a quick patch... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #35 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #34) > This is worth discussing in koha-devel, and IRC meeting or Marseille, but I > think we should have a job queue in the lines of what David proposes. And I > would add maybe the use of ZeroMQ to possibly notify other services. I agree about opening up the discussion in another forum like koha-devel, IRC, or Marseille. I'm intrigued by the use of ZeroMQ. How do you see that working, Tomás? When I first started thinking about background processing, I thought using a message queue would be a good idea. Since then, I've used an embedded ActiveMQ with the Fedora repository a bit, but that publishes notifications about record changes. Celery uses a message queue for sending out tasks and then it can use a backend like Redis for storing task results. I think if we use a database for a job queue, that would replace the message queue? Or are you meaning using a message queue for notifying other services like an indexer that there are imported records to index? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14420] bulkmarcimport.pl - Some problems
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley(a)catalyst.net.nz --- Comment #7 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Can you please rebase your patch it is currently not applying cleanly on master, as the below output shows: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14420 : bulkmarcimport.pl - Some problems Using index info to reconstruct a base tree... M misc/migration_tools/bulkmarcimport.pl Falling back to patching base and 3-way merge... Auto-merging misc/migration_tools/bulkmarcimport.pl CONFLICT (content): Merge conflict in misc/migration_tools/bulkmarcimport.pl Failed to merge in the changes. Patch failed at 0001 Bug 14420 : bulkmarcimport.pl - Some problems The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14420--bulkmarcimportpl---Some-problems-T8e2dA.patch You have new mail in /var/mail/vagrant -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #54 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Rebased. Setting back to signed off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80998|0 |1 is obsolete| | --- Comment #53 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 81606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81606&action=ed… Bug 12365: (follow-up) Fixing broken circ rules table Adding filters to note to satisfy qa test tools -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80958|0 |1 is obsolete| | --- Comment #52 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 81605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81605&action=ed… Bug 12365: (follow-up) Putting backticks in atomicupdate Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '18

30 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80957|0 |1 is obsolete| | --- Comment #51 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 81604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81604&action=ed… Bug 12365: (follow-up) Adding maxlength attribute and popover Test that you can't add a note of more than 100 characters. Test notes with rules, notes are hidden by 'View note' and the popover correctly displays note. View the note by hovering over the link I've moved the Note column so the popover displays nicely and doesn't cover the buttons. I've also changed the placement so that it doesn't cover information in the row. Update: Test that you can edit the note when clicking 'Edit' and that behaviour is the same for editing all other fields Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0