October 2018 - Koha-bugs - lists.koha-community.org

[Bug 21616] New: Translation toolchain has no tests
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '18

19 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21616 Bug ID: 21616 Summary: Translation toolchain has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: pasi.kallinen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org There are no tests for the translation toolchain. At minimum, there should be tests for extracting translatable strings from TT files, possible tests for creating and updating po-files. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '18

19 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #91 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Applying: Bug 14576: Allow arbitrary automatic update of location on checkin Using index info to reconstruct a base tree... M C4/Items.pm M C4/Reserves.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Reserves.pm Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm Failed to merge in the changes. Patch failed at 0001 Bug 14576: Allow arbitrary automatic update of location on checkin The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14576-Allow-arbitrary-automatic-update-of-loca-FkmjWf.patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '18

19 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #90 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Nick Can you please rebase? The conflict against master to be resolved is only small but git-bz fails to merge it automatically. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21601] New: Cannot create lists
by bugzilla-daemon＠bugs.koha-community.org 19 Oct '18

19 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21601 Bug ID: 21601 Summary: Cannot create lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Lists Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: '' for column 'allow_change_from_others' at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 125 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #7 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80864&action=ed… Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #6 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80863&action=ed… Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #5 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80862&action=ed… Bug 13098: Add Koha::Account::Offsets->total This patch introduces this trivial method for returning the sum0 result of the amount columns of a Koha::Account::Offsets set. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Offsets.t - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 [Bug 21584] Wrong offset type for Lost Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '18

18 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 [Bug 21607] Koha::Account::Line->apply should store credit offsets as negative amounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0