October 2018 - Koha-bugs - lists.koha-community.org

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard(a)myacpl.org --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Next time as a separate follow-up patch please! ;) Looking at this again I have some issues, I am sorry to come up with this a little lately :( 1) Usability There is visual indicator to tell apart an already stored from a changed/unsafed note. It's really easy to forget to press the button. If you happen to end your note with pressing "Enter" you trigger the error message "No order selected" It really doen't work well for notes that are longer than the input field is. They don't display in full and it's hard to move around in the input field. I think I'd like this much better following the existing design pattern with links and a modal (see basket summary). I am adding Owen in hope he has time to take a look. 2) Search Searching on the notes column doesn't work. 3) Export The notes are not exported, neither using the "Export as CSV" nor the new "Excel" export at the bottom of the table. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, please make sure you always run the latest version of the QA tools from the gitlab repository on your patches: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL filters missing_filter at line 125 ( <a name="viewnote" data-toggle="popover" title="Note" data-content="[% rule.note %]" data-placement="top" data-trigger="hover">View note</a>) I'd have fixed that, but there is another issue: The layout of the issuing rule table is broken with this patch. The buttons at the end of the table are misaligned. My entered note shows up in the last column labelled "Actions" as well, pushing the buttons into another non-existing column... (looking at it this will hopefully make more sense) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org --- Comment #257 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patches apply, QA script is clean. I am wondering about the changes to koha-tmpl/intranet-tmpl/prog/js/datatables.js as well. Adding Owen, maybe he has a moment to take a look at the datatables question here. Jonathan, could you have another look at Julian's answers in comment#249? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry for all the comments, I am just getting warmed up today it seems. I've decided to pass QA since the behaviour makes sense to me. I've tested an acquisition order. When it's not yet received the amounts show in Ordered and when you receive, the actual cost is shown in Spent. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80704|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 80966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80966&action=ed… Bug 9775: Unitprice should be hidden when creating an order The actual cost box is effectively hidden from the order page. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 --- Comment #15 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #11) > Do not we want to keep the value from the "last order received" for > subscription? > > - $data->{unitprice} = $lastOrderReceived->{unitprice}; > > > You do not hide it, you removed it. Is it really what we want? Martin, can you check this specific line? I agree with you on the workflow - actual cost is supposed to be set on receiving/processing the invoice. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hm, checking the GUI it looks like I imagined the option to view? *scratches head* So the change makes sense. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9775] unitprice should be hidden when creating an order
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '18

21 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- We have the option to view an already received order. I think it still makes sense to display the value there to have complete information. I agree that entering it at ordering time doesn't make sense with the current workflow. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10903] limit who has access to certain report groups
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '18

20 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10903 Cab Vinton <bibliwho(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho(a)gmail.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Cab Vinton <bibliwho(a)gmail.com> --- *** This bug has been marked as a duplicate of bug 16631 *** -- You are receiving this mail because: You are watching all bug changes.

1 0