October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #183 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Just a few minor question written down during code review without exploring them further: TODO why change for $oldbiblio->{'authorised_value_images'} TODO $search_context->{category} => ADD to POD TODO Waarom addbooks: if ( not exists $line->{'size'} ) { $line->{'size'} = "" } TODO Why add use Koha::Libraries; to opac-search ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78827|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #182 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467&action=ed… Bug 14385: (QA follow-up) Additional changes and fixes [1] searchResults: second my $interface can be removed: unused [2] call of getitemtypeimagelocation on L2119 needs interface key [3] ISBDdetail: No need to find patron again (line 182 vs 84) [4] opac-search: No need to find patron twice (657 and 631) [5] tabs on line 2220 of C4/Search.pm (qa tools warn) [6] Ugly hack to overcome "Undefined subroutine &C4::Items::ModZebra" by loading C4::Items before C4::Biblio when running tests Koha/BiblioUtils/Iterator.t and Labels/t_Label.t. This is a more general problem that needs attention somewhere else. It seems that Biblio.pm is one of the suspects. [7] This patch set makes Search.t crash/fail with me. Note that without these patches Search.t still passed! Why o why.. A little debugging pointed me to a missing MPL branch (aarg). Adding the simple test on the result of Libraries->find in C4::Biblio::GetAuthorisedValueDesc made the test continue. [8] Resolve: Variable "$borcat" is not available at opac-detail.pl line 246 Lexical $borcat cannot be used in sub searchAgain in opac-detail.pl under Plack. Must be defined with our (or passed as argument). [9] Resolve crash on TWO serious typos in opac-basket on ONE line: Koha::Patron->find({ borrowernumber -> $borrowernumber }) Yeah: find is in Koha::Patrons and we need => !! No need to pass a hash to find method btw for a pk value. [10] Serious bugfixing here. Add List::Util to opac-basket. Can't locate object method "none" via package "1". You can't test everything :) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> After this longer list I renamed Final to Additional in the patch title :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80411|0 |1 is obsolete| | --- Comment #181 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80466&action=ed… Bug 14385: Squash of a lot of patches rebased - Added missing GetHiddenItems parameter change case Without this prove t had a failure. - Always use mocks, not set_preference - Tweaks so t/db_dependent/00-strict.t passes There was a typo botcat vs borcat and borrowernumber was never defined. Grabbing from userenv, like other code does. - Tweak t/db_dependent/Items.t to fully test changes This will test all the if structures fully in GetHiddenItemnumbers. prove t/db_dependent/Items.t - Tweak borrower category code $borrower->{categorycode} on a Koha::Patron is not the same as $borrower->categorycode. Fixed error. - Search was returning URLS for wrong interface There was one search context place wrong. Changed it to $is_opac as the logic for setting $is_opac was modified correctly. - Corrected issues with category code. When a user isn't logged in, $borrower is undef and causes error when determining category code. Added conditional check. - Properly trigger all changes in C4/Search.pm - Fix QA Test tool failures C4/Search.pm had some tabs. - Add some commenting to make sense of logic - Refactor EmbedItemsInMarcBiblio parameters to hashref - Trigger GetMarcBiblio's EmbedItemsInMarcBiblio call. prove t/db_dependent/Items.t - Add missing test to trigger Koha/BiblioUtils/Iterator change - Add borrower category overrides These files generally add borcat parameter to GetMarcBiblio. Others might include correction of filtering of items (opac-basket), or a comment as to why no changes were done (opac-search). In the case of opac-search, correcting the first FIXME will likely correct the OpacHiddenItems issues on tags. As such, that is beyond this bugs scope. Some code had loop optimizations and fixes made, like a 'next unless $record' when the biblio shouldn't even be in the list. - Modify opac-ISBDdetail and opac-MARCdetail Both files had similar logic. They were rearranged and optimized, so that both files would have practically identical initial blocks of code. Optimizations were possible, because GetMarcBiblio returns a filtered record, so that there is no double call (once in the opac-### file and once in GetMarcBiblio) to GetHiddenItemnumbers. - Fix hiding in opac-tags opac/opac-tags.pl was not properly hiding. There is currently one known bug associated with tags left. If you have two biblios tagged by different people with the same tag, the opac-search will show the one you tagged that is supposed to be hidden, because tag searches work differently than regular searches. This is beyond the scope of this bug. See the FIXME's in opac/opac-search.pl - Trigger the C4::ILSDI::Services changes prove t/db_dependent/ILSDI_Services.t - Added missing 'my' - Test C4/Labels/Label.pm changes - Improve C4::Record::marcrecord2csv test cases - Corrected opac-details searchResult call - Fix breaking issues constraint in ITerator test - Fix ILSDI_Services test when clubs with branch exist - Rebased again! - Rebased t/db_dependent/Items.t conflict. The test plan is in comment #112 last I checked. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #180 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80465&action=ed… Bug 14385: (follow-up) Changes to sysprefs.sql and atomicupdate Run updatedatabase.pl when testing Sponsored-by: Catalyst IT Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #179 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80464&action=ed… Bug 14385: (follow-up) C4::Borrowers not found GetMember is in C4::Members, not C4::Borrowers Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78825|0 |1 is obsolete| | --- Comment #178 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 80463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80463&action=ed… Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Edit: Fixing merge conflicts in - t/db_dependent/Items.t - t/db_dependent/Search.t - C4/Search.pm Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in. Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems To test: 1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions) 2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions 3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library). 4) Log in as the borrower that should only see certain things (Adult - exception) 5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them. 6) Log in as the borrower that should see everything (Adult) 7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items Signed-off-by: Claire Gravely <c.gravely(a)arts.ac.uk> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16662] New: Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances)
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16662 Bug ID: 16662 Summary: Letsencrypt II: Return of the cryptosaurus. (make it work for existing instances) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17