October 2018 - Koha-bugs - lists.koha-community.org

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #84 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 80481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80481&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #83 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 80480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80480&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #82 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 80479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80479&action=ed… Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79696|0 |1 is obsolete| | Attachment #79697|0 |1 is obsolete| | Attachment #79698|0 |1 is obsolete| | Attachment #79699|0 |1 is obsolete| | Attachment #79700|0 |1 is obsolete| | Attachment #79701|0 |1 is obsolete| | Attachment #79702|0 |1 is obsolete| | --- Comment #81 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 80478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80478&action=ed… Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12710] Import/export reports
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Will it also be possible to export without sharing? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11679] Add an ods export choice for reports
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11679 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 [Bug 21560] report ODS export optimization -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12710] Import/export reports
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- *** This bug has been marked as a duplicate of bug 17047 *** -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12710] Import/export reports
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17047 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12710] Import/export reports
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12710 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m Depends on| |17047 --- Comment #1 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Will be in Mana Knowledge Base Bug 17047 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #184 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Great work. Spent whole morning on it so there will be comments (see also follow-up): Since you adjust EmbedItemsInMarcBiblio more fundamentally and add a borcat parameter, I would have at least expected the borcat parameter in the subtest for this routine. Bad luck however. Considering the history of this report, and the demonstrated attention for other tests here, I will not be too strict on that. Knowing that you will submit them on a new report :) No blocker but something worth fixing / feature extending ? Have a book with two items. One item must be hidden. In the OPAC I see: Availability: Items available for loan: RMA [Call number: 200 P 1] (2). This line on opac-search or opac-shelves.pl shows me (in this case) the call number of the hidden item ! Also the number 2 reveals that there are more items than shown on opac-detail. Could imagine that these "hidden books" may stand on a shelf number that you do not want to display either.. When I put the book in the cart and email the cart, I will see both items in the cart. How about hiding that one ? Similar point. Although you could argue that you have a special circ rule for these hidden items, without such a rule opac-reserve shows me the hidden items if I allow item holds. Which it should not imo. Not a blocker for me now, but it feels even a bit more serious than the former point. And thinking further: In the staff client the hidden item pops up even if I do not put the staff category in the new pref. OK, I understand that. But if I export a biblio with Save to marcxml or export data under tools etc. the item also pops up everywhere. Certainly not a blocker, but should the feature of hiding items not have some impact in such things too ? Same for SRU/Z39.50 output (item just there). Etc. In conclusion: This patch set looks good enough to me. The feature has been developed (before) picking mostly low fruit. Looking a bit further, items are not that hidden after all.. -- You are receiving this mail because: You are watching all bug changes.

1 0