October 2018 - Koha-bugs - lists.koha-community.org

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #185 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 80467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80467 Bug 14385: (QA follow-up) Additional changes and fixes Review of attachment 80467: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=143…) ----------------------------------------------------------------- Thank you very much for a Passed QA. Just had one question about one optimization you made in opac/opac-search.pl as I eyeball'd through the patch. The other things are just comments as I was looking through it. Regarding the leak via counting being off. This counting problem already leaks and is an issue. Fixing the counting problem is a complex problem, which has had recent comments on the mailing list. Given the size and scope of testing for this patch, I did not want to keep coding for perfection. Perfection is the enemy of good, or some variation thereof. :) ::: C4/Search.pm @@ +2215,5 @@ > else { > $can_place_holds = 1; > $available_count++; > + $available_items->{$prefix}->{count}++ if $item->{$hbranch}; > + foreach (qw(branchname itemcallnumber description)) { White space fix. ::: opac/opac-ISBDdetail.pl @@ +82,3 @@ > my $borcat = q{}; > +if ( $patron && C4::Context->preference('OpacHiddenItemsExceptions') ) { > + $borcat = $patron->categorycode; Nice optimization. ::: opac/opac-basket.pl @@ -59,4 @@ > my $borcat = q{}; > if ( C4::Context->preference('OpacHiddenItemsExceptions') ) { > # we need to fetch the borrower info here, so we can pass the category > - my $borrower = Koha::Patron->find( { borrowernumber -> $borrowernumber } ); Oops... should have been => good catch. ::: opac/opac-detail.pl @@ +85,4 @@ > my @all_items = GetItemsInfo($biblionumber); > my @hiddenitems; > my $patron = Koha::Patrons->find( $borrowernumber ); > +our $borcat= q{}; I would have preferred passing, rather than changing to our. ::: opac/opac-search.pl @@ +125,4 @@ > authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), > } > ); > +my $patron = Koha::Patrons->find( $borrowernumber ); Not an exact copy of 658 during the optimization. Will this affect things? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #2 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80507&action=ed… Bug 13098: Tests for _FixAccountForLostAndReturned on writeoff When a a write off is done on lost fees, but then the item is returned, the current behaviour is that a credit is added to the patron, for the amount the original lost fee was. This behaviour is wrong and this tests reproduce the situation. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because a credit (CR) is added for the original amount, without taking into account the fact the amount was not payed, but written off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia(a)bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #36 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I never did manage to apply this, but I think it's just a peculiarity with my own git repository. Setting back to Signed Off.. hopefully we can get some more eyes on this again now.. I certainly agree with the principal, though Jonathan raised an alternative approach I hadn't considered. Pondering. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #90 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- I must admit, this isn't an area of the codebase I have deep dived into for a long time.. but, the code does look sound, doesn't appear to cause any regressions I could see and passes the qa scripts. Passing QA. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80372|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80499&action=ed… Bug 11297: (follow-up) Add html filter to new input field Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78296|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80498&action=ed… Bug 11297: Modify Z3950server schema file Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78295|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80497&action=ed… Bug 11297: Add atomicupdate patch and modify kohastructure.sql Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '18

12 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78294|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 80496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80496&action=ed… Bug 11297: Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0