October 2018 - Koha-bugs - lists.koha-community.org

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80299|0 |1 is obsolete| | --- Comment #364 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 80300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80300&action=ed… Bug 11897: Add mising semi-colon to user*.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #363 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 80299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80299&action=ed… Bug 11897: Add mising semi-colon to userflags.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 --- Comment #362 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 80298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80298&action=ed… Bug 11897: (follow-up) Add Stock Rotation atomic update schema Remove the duplicate entry for RoutingListAddReserves I guess it has been caused by a bad merge resolution conflict -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Should not Koha::Util::SystemPreferences->get_yaml_pref_hash be a method of Koha::Config::SysPref instead? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #361 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! (We miss you Alex!) Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9968] Fix Standard number search to use correct index
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9968 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11897] Stock Rotation for Koha
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80275|0 |1 is obsolete| | --- Comment #360 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 80289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80289&action=ed… Bug 11897: (QA follow-up) Convert atomic update to perl Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #35 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #33) > Hmm.. on second thoughts I think this needs a bit more thought around how it > may need to handle the 'type' argument that can be passed to the script.. I > can see cases where one would want multiple runs of the script running side > by side with distinct caller options. > > I'll ponder that a little and perhaps add it as a qa followup. Yes I agree, we should have a more flexible and generic approach. We already handle similar race conditions for circulation notices (CHECKIN/OUT) in C4::Circulation::SendCirculationAlert The algorithm would be: Get the notices to send for each notice: start a transaction lock the table if the notice needs to be send (fetch the status): send the notice update the status release the lock commit the transaction else: # We certainly faced a race release the lock rollback # certainly useless as we did not modify anything -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15494] Block renewals by arbitrary item values
by bugzilla-daemon＠bugs.koha-community.org 09 Oct '18

09 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #52 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Nick Clemens from comment #50) > (In reply to Jonathan Druart from comment #39) > > 1. In tests, prefer > > Koha::IssuingRules->search->update($what_you_need_to_be_set); > > instead of the DELETE then INSERT. It makes the changes more readable in my > > opinion. > > I generally agree, but circ rules are messy and this file has the same code > existing. Should be refactored as a whole > okay, found an easy way to fix, updated. -- You are receiving this mail because: You are watching all bug changes.

1 0