November 2018 - Koha-bugs - lists.koha-community.org

[Bug 21753] New: issuingrules.chargename is unused and should be removed
by bugzilla-daemon＠bugs.koha-community.org 20 Feb '19

20 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21753 Bug ID: 21753 Summary: issuingrules.chargename is unused and should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org There is no way to set the chargename field in the issuingrules table and there is at least one FIXME (in C4::Overdues::CalcFine) stating that it is never set. A decade has passed since the FIXME was added to C4::Overdues, and nothing has changed. We should remove the field now ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 26

[Bug 18383] New: items.onloan schema comment seems to be incorrect.
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '19

19 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18383 Bug ID: 18383 Summary: items.onloan schema comment seems to be incorrect. Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: pongtawat(a)punsarn.asia QA Contact: testopia(a)bugs.koha-community.org Currently the items.onloan schema comment (in SQL and hence on schema.koha-community.org too) is like this: defines if item is checked out (NULL for not checked out, and checkout date for checked out) However, on my installation (16.11.06), the date that Koha put into items.onloan column seems to be due date. So, probably the comment should be changed to: defines if item is checked out (NULL for not checked out, and due date for checked out) -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 19731] New: Notify when you add new item with reservations
by bugzilla-daemon＠bugs.koha-community.org 19 Feb '19

19 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19731 Bug ID: 19731 Summary: Notify when you add new item with reservations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: patrick.robitaille(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hi, It would be nice in Koha when you add a new item to have a notification or a pop-uo when all the items for this record are on loan and there are reservations for this record. That could be usefull to have this notification for the person who has added the new item to be niticed that it should be put on hold to satisfy reservations and not shelved with available status. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 21691] New: Koha::Account->non_issues_charges has no tests
by bugzilla-daemon＠bugs.koha-community.org 18 Feb '19

18 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21691 Bug ID: 21691 Summary: Koha::Account->non_issues_charges has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Everything in the Koha namespace should be properly tested.. but Koha::Account has a number of methods that are missing corresponding tests. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 16714] New: Unexpected logout with "IP address change"
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 21363] New: Unwanted margin between checkout form and last checked out information
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21363 Bug ID: 21363 Summary: Unwanted margin between checkout form and last checked out information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19474 Created attachment 78992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78992&action=ed… Screenshot showing the problem Probably caused by Bug 19474. See attached screenshot. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 20461] New: New subscription form: "Item type" and "item type for older issues" are ignored
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20461 Bug ID: 20461 Summary: New subscription form: "Item type" and "item type for older issues" are ignored Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: victor.grousset(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Impacts also 16.11.x == Cause == In subscription-add.pl, the two params aren't passed to NewSubscription() but they are to ModSubscription() == Workaround == Modify the newly created subscription to set these two values. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 25

[Bug 21621] New: Incorrect GROUP BY in tools/letter.pl
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21621 Bug ID: 21621 Summary: Incorrect GROUP BY in tools/letter.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname FROM letter LEFT OUTER JOIN branches USING (branchcode) GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 19701] New: Modify patron loses password in Microsoft Edge
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19701 Bug ID: 19701 Summary: Modify patron loses password in Microsoft Edge Change sponsored?: --- Product: Koha Version: 16.05 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Browser compatibility Assignee: oleonard(a)myacpl.org Reporter: emma.perks(a)heartofengland.nhs.uk QA Contact: testopia(a)bugs.koha-community.org In Microsoft Edge editing a patron record takes away the password and you have to add it back in before you can save the record. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 21907] New: Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled
by bugzilla-daemon＠bugs.koha-community.org 15 Feb '19

15 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21907 Bug ID: 21907 Summary: Error from mainpage when Article requests enabled and either IndependentBranches or IndependentBranchesPatronModifications is enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org DBD::mysql::st execute failed: Column 'branchcode' in where clause is ambiguous [for Statement "SELECT COUNT( * ) FROM `article_requests` `me` JOIN `borrowers` `borrowernumber` ON `borrowernumber`.`borrowernumber` = `me`.`borrowernumber` WHERE ( ( `branchcode` = ? AND `status` = ? ) )" with ParamValues: 0="LIBRARY", 1='PENDING'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. No method count found for Koha::ArticleRequests DBIx::Class::Storage::DBI::_dbh_execute(): Column 'branchcode' in where clause is ambiguous at /usr/share/koha/lib/Koha/Objects.pm line 395 at /usr/share/koha/intranet/cgi-bin/mainpage.pl line 71. To recreate: 1 - Enable 'IndependentBranchesPatronModifications' and article requests 2 - Sign in as non-superlibrarian 3 - View plack log 4 - Refresh mainpage, see error in logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14