November 2018 - Koha-bugs - lists.koha-community.org

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #136 from David Gustafsson <glasklas(a)gmail.com> --- Rebased against master and added granular permission in accordance with Bug 14391. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82030|0 |1 is obsolete| | --- Comment #135 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 82775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82775&action=ed… Bug 14957: Merge rules system for merging of MARC records Add a rule based system for merging MARC records to for example prevent field data from being overwritten. To test: 1. Apply this patch. 2. Log in to staff client. 3. Enable new syspref MARCMergeRules. 4. Click the new link "MARC merge rules" in the "Catalog" section of the Koha administration page. 5. Create a new rule: Module: source, Filter: *, Tag: 245, Preset: Protect. 6. Clicking "Edit" should allow you to edit corresponding rule. 7. Clicking "Delete" should remove corresponding rule after confirmation. 8. Selecting one or more rules followed by clicking "Delete selected" should remove all selected rules after confirmation. 9. Try creating a rule with tag set to "**", the other options does not matter. Verify that saving this rule produces an error message complaining about invalid tag regular expression. 10. Try creating a rule with tag set to "008" (or other control field) and set Appended: Append and Removed: Skip, the other options does not matter. Verify that saving this rule produces an error message complaining about invalid combination of actions for control field. 11. With the 245 rule in step 5 in place, edit a bibliographic record, change 245a for example (which should be Title for MARC21) and save. 12. Verify that the changes has not been saved. 13. Create a new rule: Module: source, Filter: intranet, Tag: 245, Preset: Overwrite. 14. Repeat step 12, and verify that the changes has now been saved. 15. Run tests in t/db_dependent/Biblio/MarcMergeRules.t and very that all tests pass. Sponsored-by: Halland County Library Sponsored-by: Catalyst IT Sponsored-by: Gothenbug University Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #34 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Comment on attachment 74947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74947 Bug 15253: Add Koha::Logger based logging for SIP2 Review of attachment 74947: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=152…) ----------------------------------------------------------------- ::: C4/SIP/Sip.pm @@ +203,5 @@ > + : 'error'; > + > + my $message = @args ? sprintf($mask, @args) : $mask; > + > + C4::SIP::SIPServer::get_logger()->$method($message); I think C4::SIP::SIPServer::get_logger() should not be hard coded here because if the C4::SIP code is used from other parts of Koha like the intranet (yeah, I know this should not happen but think the same situation with some things in C4 being either just for OPAC or intranet) then instead of the log going to the intranet log it will go the sip server log. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Chris Slone <cslone(a)camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #439 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Devinim from comment #438) > Created attachment 82744 [details] [review] > Bug 7143: Update about page for Nazlı Last two patches pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 14862] Upgrade jQuery from 1.7 to 1.8.x (or higher) in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10659 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 [Bug 10659] Upgrade jQuery star ratings plugin -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14862 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14862 [Bug 14862] Upgrade jQuery from 1.7 to 1.8.x (or higher) in OPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77740|0 |1 is obsolete| | Attachment #77741|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 82760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82760&action=ed… Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. - Confirm that information about the plugin appears on the About page in the staff client, replacing the old star ratings plugin information. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '18

29 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 --- Comment #2 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 82749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82749&action=ed… Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template. To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be enabled. - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings disabled. -- You are receiving this mail because: You are watching all bug changes.

1 0