November 2018 - Koha-bugs - lists.koha-community.org

[Bug 21377] New: Variable declarations erroneously filtered
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Bug ID: 21377 Summary: Variable declarations erroneously filtered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com In the main ILL template file ill-requests.tt a few variable declarations that are not strings have the "html" filter applied to them, this breaks them. These filters should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 21418] New: Incorrectly filtered markup in staff client lists
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21418 Bug ID: 21418 Summary: Incorrectly filtered markup in staff client lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Staff Client Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: bgkriegel(a)gmail.com, brendan(a)bywatersolutions.com, chris(a)bigballofwax.co.nz, dcook(a)prosentient.com.au, ere.maijala(a)helsinki.fi, fridolin.somers(a)biblibre.com, george(a)nekls.org, gmcharlt(a)gmail.com, j.kylmala(a)gmail.com, jonathan.druart(a)bugs.koha-community.org, julian.maurice(a)biblibre.com, katrin.fischer(a)bsz-bw.de, kohadevinim(a)devinim.com.tr, kyle(a)bywatersolutions.com, liz(a)catalyst.net.nz, m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, mirko(a)abunchofthings.net, mtompset(a)hotmail.com, nick(a)bywatersolutions.com, testopia(a)bugs.koha-community.org, tomascohen(a)gmail.com, veron(a)veron.ch Depends on: 13618 The AJAX DataTable of existing lists is broken because the action buttons are incorrectly rendered. The "| html" filter should be removed from the action_block declarations. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 15754] New: html tags displayed when editing frameworks
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15754 Bug ID: 15754 Summary: html tags displayed when editing frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 When editing subfields the "repeatable", "mandatory" and "is url" checkboxes are not displayed: the input html tag is displayed instead. Caused by bug 13618. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 20975] New: Improve auto escaping performance
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20975 Bug ID: 20975 Summary: Improve auto escaping performance Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13618 On bug 13618 we are trying to get rid of XSS issues with a global solution. Using Template::Stash::AutoEscaping we are going to apply a html filter to all of our template variables. The problem is that we can have thousands of variables displayed (and so escaped). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Prevent XSS in the Staff Client and the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 15733] New: Audio Alerts issues in master
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Bug ID: 15733 Summary: Audio Alerts issues in master Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In master there is a JSON error thrown when AudioAlerts are enabled. When checking in I get: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 3 of the JSON data This does not happen in 3.22 Also (in master and 3.22) single quotes audio selector break ability to edit an alert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 21673] New: Koha::Account::Lines->total_outstanding must be used when needed
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 Bug ID: 21673 Summary: Koha::Account::Lines->total_outstanding must be used when needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13098 There are several times the same pattern to retrieve the sum of amountoutstanding columns for Koha::Account::Line set. We should use Koha::Account::Lines->total_outstanding instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 [Bug 13098] Item lost multiple times by the same patron will create only be charged once -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 19574] New: Wrong itemtype can be chosen when placing holds
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19574 Bug ID: 19574 Summary: Wrong itemtype can be chosen when placing holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add a hold for an itemtype that doesn’t actually exist at a specific branch. Say that branch A has two itemtypes: books and map, while branch B has three: books, map and audio book. It is possible to add a hold for branch A with itemtype audio book although there is no item with such an itemtype at this branch. This will cause an internal server error if you try to delete this faulty hold. To recreate: 1) Enable AllowHoldItemTypeSelection 2) Add, or find, a bibliographic record with at least two branches and at least two items with two different itemtypes. Branch B should not have all itemtypes. 3) Add a hold for branch B, and choose an itemtype not available at this branch (there are no such items) 4) Try deleting the hold, note the internal server error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82420|0 |1 is obsolete| | --- Comment #78 from Michal Denar <black23(a)gmail.com> --- Created attachment 82797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82797&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21835] New: Request ID is displayed as NaN
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Bug ID: 21835 Summary: Request ID is displayed as NaN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com In the main ILL requests table, the request ID is displayed as NaN. There are two problems here. Firstly, we're not populating id_prefix in the API response, it got missing in the deprecation of TO_JSON in bug 20996. As such, by the time we get to the JS that populates the ILL table, there is no id_prefix property in the row object, so concatenating undefined with an integer returns NaN. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15