November 2018 - Koha-bugs - lists.koha-community.org

[Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all.
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all.
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|olli-antti.kivilahti(a)jns.fi |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all.
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Currently, we do not show Place hold on opac-detail if there are too many items. The user can click View all items to refresh the detail page with all items. At that time we show Place hold (if possible). If we just show Place hold if there are too many items, clicking Place hold could perhaps generate a refusal but will probably most often save another click on View all items (which even seems to confuse some users). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13654] Cannot place a hold for biblio with too many Items to display unless viewing them all.
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13654 --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to George Williams (NEKLS) from comment #6) > Any chance of re-writing this since it failed QA? I'd really like to see > this work. I was just opening a new report when I saw this one. I have a patch with one line more for it? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Any news here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #173 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi all, I have just added another follow-up which moves the function out of C4/Reserves into Koha/Biblio (as Tomás suggested in comment 169) The caller for this function is now: my $holds_allowed_on_record_today = $biblio->allowed_holds( $patron_obj ); I have amended the t/db_dependent/Reserves/MultiplePerRecord.t unit tests. Can this please be tested and if you could let me know of further required changes that would be great. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #172 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 82221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82221&action=ed… Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio Also updated t/db_dependen/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe a modal box loads to inform you that you have reached the maximum holds allowed today. 6. Click 'OK' on the modal and notice the first checkbox is selected and other unchecked checkboxes are disabled. 7. Repeat step 4 this time setting holds per day to 5 8. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays and select another item checkbox (so you have 2 selected checkboxes). Observe a modal saying you have reached the maximum number of holds for the record is loaded 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #171 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 82220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82220&action=ed… Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio Also updated t/db_dependen/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe a modal box loads to inform you that you have reached the maximum holds allowed today. 6. Click 'OK' on the modal and notice the first checkbox is selected and other unchecked checkboxes are disabled. 7. Repeat step 4 this time setting holds per day to 5 8. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays and select another item checkbox (so you have 2 selected checkboxes). Observe a modal saying you have reached the maximum number of holds for the record is loaded 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13406] Add classes to MARC Authority display to enable CSS styling
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority MARC display |Add classes to MARC |impossible to style via CSS |Authority display to enable | |CSS styling -- You are receiving this mail because: You are watching all bug changes.

1 0