November 2018 - Koha-bugs - lists.koha-community.org

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #173 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi all, I have just added another follow-up which moves the function out of C4/Reserves into Koha/Biblio (as Tomás suggested in comment 169) The caller for this function is now: my $holds_allowed_on_record_today = $biblio->allowed_holds( $patron_obj ); I have amended the t/db_dependent/Reserves/MultiplePerRecord.t unit tests. Can this please be tested and if you could let me know of further required changes that would be great. Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #172 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 82221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82221&action=ed… Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio Also updated t/db_dependen/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe a modal box loads to inform you that you have reached the maximum holds allowed today. 6. Click 'OK' on the modal and notice the first checkbox is selected and other unchecked checkboxes are disabled. 7. Repeat step 4 this time setting holds per day to 5 8. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays and select another item checkbox (so you have 2 selected checkboxes). Observe a modal saying you have reached the maximum number of holds for the record is loaded 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82220|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #171 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 82220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82220&action=ed… Bug 15565: (follow-up) Moved function form C4/Reserves to Koha/Biblio Also updated t/db_dependen/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe a modal box loads to inform you that you have reached the maximum holds allowed today. 6. Click 'OK' on the modal and notice the first checkbox is selected and other unchecked checkboxes are disabled. 7. Repeat step 4 this time setting holds per day to 5 8. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays and select another item checkbox (so you have 2 selected checkboxes). Observe a modal saying you have reached the maximum number of holds for the record is loaded 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13406] Add classes to MARC Authority display to enable CSS styling
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13406 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority MARC display |Add classes to MARC |impossible to style via CSS |Authority display to enable | |CSS styling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20647] New: When ILL is enabled the hover effect on the ILL requests button is wrong.
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Bug ID: 20647 Summary: When ILL is enabled the hover effect on the ILL requests button is wrong. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The Icon part of the button on the main staff client page does not highlight with the text for the ILL requests button the same was as it does for all other module buttons on that page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 12365] Allow descriptive notes to be added to circulation and fine rules
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow descriptive notes to |Allow descriptive notes to |be added to circulation |be added to circulation and |rules |fine rules -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Allow descriptive notes to be added to circulation rules
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Notes for rules |Allow descriptive notes to | |be added to circulation | |rules -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13560] MARC modification templates - Add an 'Add' option
by bugzilla-daemon＠bugs.koha-community.org 12 Nov '18

12 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an 'Add' option in MARC |MARC modification templates |modification templates |- Add an 'Add' option -- You are receiving this mail because: You are watching all bug changes.

1 0