November 2018 - Koha-bugs - lists.koha-community.org

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Sally Healey <sally.healey(a)cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18923] New: Resolve a warn in Biblio::GetCOinSBiblio
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 Bug ID: 18923 Summary: Resolve a warn in Biblio::GetCOinSBiblio Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 24

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 81907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81907&action=ed… Bug 15561 [QA Followup] - Add atomic update, fix other issues -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 81906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81906&action=ed… Bug 15561 [QA Followup] - Rename ExpireReservesMaxPickUpDelayCharge to WaitingHoldCancelationFee -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 81905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81905&action=ed… Bug 15561 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63358|0 |1 is obsolete| | Attachment #63359|0 |1 is obsolete| | Attachment #63360|0 |1 is obsolete| | Attachment #63361|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 81904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81904&action=ed… Bug 15561 - Add ability to charge cancelation fee from "Holds over" tab The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by the automatic expiration cron script. Some libraries would prefer to manually cancel holds via the "Holds over" tab of the "Holds awaiting pickup" page but still be able to charge the cancellation fee. Test Plan: 1) Apply this patch 2) Set ExpireReservesMaxPickUpDelayCharge to some number 3) Go to the Holds awaiting pickup page 4) Go to the Holds over tab 5) Note the new checkbox for charging the fee 6) Test canceling a single hold with the checkbox checked 7) Note a fee is charged 8) Test canceling a single hold with the checkbox unchecked 9) Note a fee is not charged 10) Test canceling all holds with the checkbox checked 11) Note the patrons are charged fees 12) Test canceling all holds without the checkbox checked 13) Note the patrons are not charged fees Signed-off-by: Jason Burds <JBurds(a)dubuque.lib.ia.us> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15561] Add ability to charge cancellation fee from "Holds over" tab
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #243 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 81902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81902&action=ed… Bug 10662: (follow-up) Template corrections and improvements This patch makes a number of corrections and improvements to the OAI harvester templates: - Add missing DataTables CSS include - Replace YUI grid with Bootstrap - Correct style of inline dialogs (.dialog.alert, .dialog.message) - Correct class of form hint and error messages - Format dates in saved and submitted requests tables - Add title-string sorting to DataTables configuration - Add delete confirmation to saved and submitted tables - Disable sorting on action columns - Style action links inside tables as buttons - Removed commented markup - Add missing JavaScript include (tools-menu.js) to highlight active section in sidebar menu - Add CodeMirror styling to record view page (CodeMirror XML mode file is added to enable this) - Remove invalid <script> "type" attribute To test, apply the patch and clear your cache if necessary. - Go to Tools -> OAI-PMH harvester - "Saved," "Submitted," and "Import history" table should look correct and work correctly: Sorting, column visibility, pagination, etc. - In the "Saved" and "Submitted" tables, dates should be formatted according to the dateformat preference and sorting of these dates should work correctly. - In the "Import history" table the "View record" and "View in catalog" links should be styled as Bootstrap buttons. - Click the "View record" button. - The view of the downloaded record should have XML syntax highlighting. - When you perform actions like submitting requests, starting requests, etc, corresponding dialogs should be styled correctly. Informational/successful information should be "message" style dialogs. Error dialogs should be "alert" style. - Click "New request" - Form hints in the new request form should be styled correctly. - Submit the form without filling in any fields. Field-specific error messages should be styled italic red. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3820] Members in Log Viewer Showing ?? in UPDATE
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com --- Comment #10 from Fiona Borthwick <fiona.borthwick(a)ptfs-europe.com> --- There is still interest from our customer base on this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0