November 2018 - Koha-bugs - lists.koha-community.org

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #43 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- -C4::Letters::SendQueuedMessages( - { - verbose => $verbose, - username => $username, - password => $password, - method => $method, - limit => $limit, - type => $type, - } +C4::Letters::SendQueuedMessages( { verbose => $verbose, username => $username, password => $password, method => $method } ); +sleep(15); Why do you remove limit and type? Why add sleep (debug leftover)? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #42 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- +my $instancemessagequeuefile = $logdir . "/messagequeue.lock"; +open(FOO, ">> $instancemessagequeuefile") or die "Cannot write to $instancemessagequeuefile: $!"; As Martin already said, the logdir might not be the best candidate. Also look at locking in rebuild_zebra.pl. Note that it tries three places and continues even if the system does not facilitate locking. I see in the follow-ups that you change it. Fine. You now copy locking from rebuild_zebra. Please consolidate: move it to a module. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Alex Buckley from comment #39) > Hi Marcel > > Thanks for testing. Can you please tell me which patch is failing to apply? > > When I test applying on up to date master it is applying fine: > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is > running > Applying: Bug 15529 - Wrapping email sending up in the verbose flag > Using index info to reconstruct a base tree... > M misc/cronjobs/process_message_queue.pl > Falling back to patching base and 3-way merge... > Auto-merging misc/cronjobs/process_message_queue.pl > Applying: Bug 15529: Followup to send without more libraries > Applying: Bug 15529: Altered logic for lockfile creation > > Cheers, > Alex Second patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- +print "$0 is already running. Exiting.\n"; +#Send email to inform administrator another process_message_queue.pl cron was attempted to run whilst previous execution of the file is taking place. +# Configure accordingly +MIME::Lite->send( 'smtp', ''); +my $email = MIME::Lite->new( +To => ' ', +From => ' ', +Type => 'TEXT', +Subject => 'process_message_queue.pl cron is already running', +Data => 'process_message_queue.pl cron is already running', +); + +$email->attach( +Type => 'Text', + Data => 'process_message_queue.pl cron is already running', ); +$email->send(); +exit(1); +} I would say: Just print already running to STDERR and quit. No need to send email. If the administrator wants an email, he can add MAILTO=root in cron. No need to add MIME::Lite etc. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #39 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Hi Marcel Thanks for testing. Can you please tell me which patch is failing to apply? When I test applying on up to date master it is applying fine: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is running Applying: Bug 15529 - Wrapping email sending up in the verbose flag Using index info to reconstruct a base tree... M misc/cronjobs/process_message_queue.pl Falling back to patching base and 3-way merge... Auto-merging misc/cronjobs/process_message_queue.pl Applying: Bug 15529: Followup to send without more libraries Applying: Bug 15529: Altered logic for lockfile creation Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Patch does not apply btw. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #49 from Olli-Antti Kivilahti <olli-antti.kivilahti(a)helsinki.fi> --- DB link table is a good idea. Zebra searches for the link relations were blazingly fast tho. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here a bit -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11175] Show the parent record's component parts in the detailed views
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Johanna Räisä <johanna.raisa(a)mikkeli.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa(a)mikkeli.fi --- Comment #48 from Johanna Räisä <johanna.raisa(a)mikkeli.fi> --- As we have used this in Finland for some years now, my opinion is that using the index for linking the records is not very efficient. You are always depended on it and if you want to make REST endpoint for the host and its component parts the callback probably isn't always solid. Also we have had issues with removing records. If you remove the host record the children are not going to be removed at the same time. And finding which children can be removed afterwards is difficult. On the other hand cleaning the database is getting very annoying and slow. My proposal is to move this linking to database level. Having a linking table which has host's biblionumber and child's biblionumber would make it solid and easier to handle. This could be a solution that we don't have to implement always to new search index platform. -- You are receiving this mail because: You are watching all bug changes.

1 0