November 2018 - Koha-bugs - lists.koha-community.org

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #225 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #216) > The Refresh import history button does not work, there is an error in js > console: > > TypeError: history_table.ajax is undefined That's very strange. I tested this before uploading and it was fine. I will add your follow-ups and try to reproduce. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #224 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 81789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81789 Bug 10662: (QA follow-up) Fix plural in pod and use statements Review of attachment 81789: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=106…) ----------------------------------------------------------------- ::: Koha/OAI/Harvester/Import/Record.pm @@ +29,4 @@ > > use Koha::OAI::Harvester::Import::MARCXML; > use Koha::OAI::Harvester::Biblios; > +use Koha::OAI::Harvester::Histories; This actually should be Koha::OAI::Harvester::History and not Koha::OAI::Harvester::Histories. This change breaks the harvester. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #223 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #213) > There are still COLLATE utf8_unicode_ci in column definitions in atomic > update and kohastrusture.sql Oh I see at the column level. I did the table level but must have missed those. I'll fix that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #222 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #212) > Koha/Schema/Result/*.pm changes should be in its own patch, as they are > generated. Could you split it please? Good point. I have done that in the past, and I can certainly do that here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #221 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #211) > Comment on attachment 81783 [details] [review] > Bug 10662: Build OAI-PMH Harvesting Client > > Review of attachment 81783 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/OAI/Harvester/Worker/Download/Stream.pm > @@ +111,5 @@ > > + } > > + > > + #NOTE: Prepare database statement handle > > + my $dbh = C4::Context->dbh; > > + my $sql = "insert into oai_harvester_import_queue (uuid,result) VALUES (?,?)"; > > You should not use SQL in Koha modules, use > Koha::OAI::Harvester::ImportQueue->new in place of execution of this > statement Ordinarily, I would agree. However, Koha::Object[s] use DBIx::Class, which is very slow. If you read more of Koha::OAI::Harvester::Download::Stream, you'll see that I re-use the same prepared statement handle (something we unfortunately have never done in Koha), which makes the inserts much much much faster. Here I'm aiming for high performance. DBIx::Class was built for convenience rather than performance, so I've opted to use DBI and SQL, as it's just so much faster. As a side note, Tomas and I chatted a bit at Kohacon about making the harvester's workers use Koha's plugins, so perhaps this is something where the built-in for Koha could use DBIC, and I could provide a more high performance plugin outside of Koha. Although it seems a shame that we'd prefer low performance over high performance :/. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #220 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #210) > (In reply to Josef Moravec from comment #209) > > Created attachment 81786 [details] > > Encoding problem + datatable > > > > In submitted requests table I encountered a encoding problem: > > > > "Knihovna ÃstÃ" should be "Knihovna Ústí". > > > > Also, the heading of datatable is usually formatted in one line, see patron > > circulation history for example. > > I am adding Owen because of the datatable styling. > > Owen, what would you suggest? I just added KohaTable as requested. If someone can provide additional details regarding styling, I'd be happy to change it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #219 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #209) > Created attachment 81786 [details] > Encoding problem + datatable > > In submitted requests table I encountered a encoding problem: > > "Knihovna ÃstÃ" should be "Knihovna Ústí". > > Also, the heading of datatable is usually formatted in one line, see patron > circulation history for example. That's strange. I've never had this problem before. I will try to reproduce. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #218 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #208) > In tables for history and requests you have column import_matcher_code, that > is bad I think, you should always use matcher_id and make it foreign key to > marc_matchers. I can see why you'd say that, but import_matcher_code is an optional field, so it can't be a foreign key. 99.99% of requests should never ever use that field, but it was added for libraries that might want to initially match against an existing set of records so they don't get duplicates when first starting harvesting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '18

02 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #217 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Josef Moravec from comment #207) > What is the intention on commented out code in > koha-tmpl/intranet-tmpl/prog/en/modules/tools/oai-pmh-harvester/dashboard.tt > in table with saved_requests? Originally, I displayed a lot more information in this table, but I commented it out, as I thought it would be too much. I kept it in comments in case during QA people thought there should be more information. This way I wouldn't have to rewrite it all out. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '18

01 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 21748, which changed state. Bug 21748 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->update_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21748 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.

1 0