November 2018 - Koha-bugs - lists.koha-community.org

[Bug 20284] New: ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284 Bug ID: 20284 Summary: ILL: Adding a 'new request' from OPAC fails with template error if text exists in ILLModuleCopyrightClearance Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.field(a)ptfs-europe.com If text is added to the system preference ILLModuleCopyrightClearance then you are unable to place an ILL request in the OPAC. You get a list of the backends but, upon selecting any of them, you get an internal server error. Error log shows: Template process failed: file error - : not found at /usr/share/koha/lib/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 37

[Bug 18837] New: Add an unmediated Interlibrary Loans workflow
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Bug ID: 18837 Summary: Add an unmediated Interlibrary Loans workflow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alex.sassmannshausen(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Some libraries may wish to allow their patrons to place Interlibrary loan requests without those requests going through a formal moderation process. The ILLModule cannot guarantee an unmediated workflow for every backend. I propose the following approach: - A system preference switching this functionality on & off. - Use ILL module's generic capabilities functionality to allow execution of unmediated requests on a per backend basis, but falling back on the normal process for backends that don't support unmediated. Alex -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 56

[Bug 18589] New: Show ILLs as part of patron profile
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug ID: 18589 Summary: Show ILLs as part of patron profile Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Bug 7317 adds a "Interlibrary loans" tab on the left hand side of patron details, under Purchase suggestions. But this behaves more like a link than a tab, taking you to the ILL module and a list limited to the patron in question. It would be better if this view looked more like a part of the patron details, with the tabs on the left hand side and the buttons on top. Compare this to the "Modification log" tab/link, which actually takes you to the log "module", but still looks like part of the patron profile. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 101

[Bug 21641] New: Software error when checking out an item with a charge associated with it
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21641 Bug ID: 21641 Summary: Software error when checking out an item with a charge associated with it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you try to check out an item with a charge associated with it the following error is thrown as the C4::Circulation->AddIssuingCharge() is executed: Undefined subroutine &C4::Circulation::getnextacctno called at /home/vagrant/kohaclone/C4/Circulation.pm line 3194 The getnextacctno function is in C4::Accounts. This module is in a use pragma at the top of C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 21900] New: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21900 Bug ID: 21900 Summary: intranet_catalog_biblio_enhancements_toolbar_button plugin hook broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Commit 1a0172a253e5432e5eef862768aaacb3463501f2 broke the display of buttons provided by plugins making use of the intranet_catalog_biblio_enhancements_toolbar_button hook. The addition of the html filter breaks the ability of the browser to parse the HTML provided by the plugin, the $raw filter needs to be used instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 21679] New: Software error when placing a hold on an item with a charge associated with it
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21679 Bug ID: 21679 Summary: Software error when placing a hold on an item with a charge associated with it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When you try and place a hold on an item with a charge associated with it, the hold fails with the error: Undefined subroutine &C4::Reserves::getnextacctno called at /usr/share/koha/C4/Reserves.pm line 574. The getnextacctno function is in C4::Accounts. This is exactly the same issue as bug 21641 and should be resolved in the same way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 20923] New: Merging backend status graph into main status graph incorrect use of grep
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 Bug ID: 20923 Summary: Merging backend status graph into main status graph incorrect use of grep Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com When the Illrequest object is being constructed, it consults the status graphs for enabled backends. These status graphs are then merged into the main graph in order to provide the full workflow for a request. As part of this process, the "next_actions" property is updated to reflect any new statuses. During this, a check is performed to determine if the status graph knows about the next status being declared by a backend status graph: if ( grep $prev_action, @core_status_ids ) { This is incorrect. According to http://perldoc.perl.org/functions/grep.html, the first parameter should be a block or expression, here we are passing a string. This malfunctions in so much as passing "REQ" with match twice in the following array [ "REQ", "REQREV" ], this is not what we would expect. The fix is to substitute the following line: if ( grep /^$prev_action$/, @core_status_ids ) { -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 8

[Bug 20917] New: Improve email functionality relating to ILL requests
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Bug ID: 20917 Summary: Improve email functionality relating to ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com The ILL module has the ability to send emails containing details of requests to "partner" libraries. This functionality, though currently in the core ILL code, is actually only required by the "FreeForm" backend. It is surfaced in the UI as a form containing an email template and a multi-select to select the partners who will receive the email. The email functionality offered by ILL, though functional, is lacking in some important respects, which this bug proposes addressing. Proposed enhancements, which are all inter-related, are: - Move emailing functionality from the core ILL module to the FreeForm backend where it is actually used - Email is sent independently of the Koha message queue, which is understood to be undesirable, this should be addressed - As such, there is no ability for users to specify a default message template, using the Notices and Slips module, this should be addressed - It is not possible for users to specify default "reply-to" addresses for all ILL related emails, currently the ReplyToDefault syspref is used, this should be addressed - No message notification is sent to nominated staff when a request is modified, this should be addressed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 20883] New: Patron userid should be exposed
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Bug ID: 20883 Summary: Patron userid should be exposed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com Currently, when displaying a list of ILL requests, or viewing a single request, the requester's userid is not displayed. This should be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 21016] New: Plugins: Expand usage of opac_js method, or create intranet_js
by bugzilla-daemon＠bugs.koha-community.org 07 Nov '22

07 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21016 Bug ID: 21016 Summary: Plugins: Expand usage of opac_js method, or create intranet_js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org There is an opac_js method which gives the opportunity for a plugin to return some Javascript to be embedded in the OPAC. I propose that we either make this method more generic, perhaps, plugin_js, so it can reasonably be used for JS for either the OPAC or intranet, or we add an intranet_js method for embedding JS in plugins that touch the staff client. I suspect there's a use case for a plugin wanting to return different JS for the OPAC and staff client, so the latter idea might be preferable. The inspiration for this proposal is the CLA Check Permissions plugin (Bug 20968), the current workflow is a bit clunky with the button on the Bib toolbar taking the user to a page generated by the plugin, on which the main Javascript is run, opening a modal. The plugin has no use for the additional page, but is necessary to run the Javascript. The proposal would allow us to run the Javascript directly in the Bib view, which would make for a better UX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5