December 2018 - Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #62 from Michal Denar <black23(a)gmail.com> --- Created attachment 83409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83409&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #61 from Michal Denar <black23(a)gmail.com> --- Created attachment 83408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83408&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #60 from Michal Denar <black23(a)gmail.com> --- Created attachment 83407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83407&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #59 from Michal Denar <black23(a)gmail.com> --- Created attachment 83406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83406&action=ed… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 --- Comment #58 from Michal Denar <black23(a)gmail.com> --- Created attachment 83405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83405&action=ed… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83318|0 |1 is obsolete| | Attachment #83319|0 |1 is obsolete| | Attachment #83320|0 |1 is obsolete| | Attachment #83321|0 |1 is obsolete| | Attachment #83322|0 |1 is obsolete| | Attachment #83323|0 |1 is obsolete| | Attachment #83324|0 |1 is obsolete| | Attachment #83325|0 |1 is obsolete| | Attachment #83326|0 |1 is obsolete| | --- Comment #57 from Michal Denar <black23(a)gmail.com> --- Created attachment 83404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83404&action=ed… Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4398] Example notice for 'claims notice' in Serials
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4398 --- Comment #10 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Very helpful, thank you Katrin! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 4398] Example notice for 'claims notice' in Serials
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4398 --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, usually you'd claim one or more serials. I think the notice should contain information from the bibliographic record and information about the issue that is claimed. Maybe something like that: Title - ISSN Issue information Title - ISSN Issue information ... The issue information is in the serial table I believe (issue 1, vol 12 2015 or similar). The text should be a polite asking for sending the issues that have been found to be late or missing. Does this help? (And now that I saw it, the info in the French exampe looks good :) : <<biblio.title>> - ISSN: <<biblioitems.issn>> <<serial.serialseq>>, published <<serial.publisheddate>> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '18

20 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha(a)catalyst.net.nz --- Comment #30 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Another Academy coming up... where else would we like students to make this change? -- You are receiving this mail because: You are watching all bug changes.

1 0