December 2018 - Koha-bugs - lists.koha-community.org

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #8 from Devinim <kohadevinim(a)devinim.com.tr> --- Created attachment 83387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83387&action=ed… Bug 5770: (follow-up) New system pref for new suggestion email -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #7 from Devinim <kohadevinim(a)devinim.com.tr> --- Created attachment 83386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83386&action=ed… Bug 5770: Notify for new suggestion - sample notices This patch adds the new notice for all languages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #6 from Devinim <kohadevinim(a)devinim.com.tr> --- Created attachment 83385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83385&action=ed… Bug 5770: Notify for new suggestion Test plan: 1 - Make sure create a new notice suggestions > NEW_SUGGESTION 2 - Change EmailPurchaseSuggestions and EmailAddressForSuggestions system preferences. 3 - Create a suggestion 4 - Verify the notice is generated in the message_queue table. 6 - Verify that the e-mail will be sent to the address specified in the EmailPurchaseSuggestions system preferences. 7 - And then return to 2. 8 - Repeat steps. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 Devinim <kohadevinim(a)devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5770] Email librarian when purchase suggestion made
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770 --- Comment #5 from Devinim <kohadevinim(a)devinim.com.tr> --- Created attachment 83384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83384&action=ed… Bug 5770: New system pref for new suggestion email Add two new system preferences for new suggestion email. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 21649] New: Add child button in the staff client is no longer automatically populating the parent address
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649 Bug ID: 21649 Summary: Add child button in the staff client is no longer automatically populating the parent address Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: margaret(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In 18.05 when a staff member clicks the Add Child button on a Parent's/Guardian's account the main address is not populated on the new patron page. Other details carry over but the main address is empty. I tested on a 17.11 instance and the feature works correctly there. To Replicate: 1) Install/be running 18.05.04 2) Create or find an adult patron account you want to test with; make sure they have an address - street, city, etc. 3) On the Details tab of the patron's record click on the "+Add child" button. 4) See that the main address text boxes are empty on the /cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=... page. The Guarantor information and Contact information seems to come over, but Address does not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 21567] New: WebService:ILS related tests fail during package build
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21567 Bug ID: 21567 Summary: WebService:ILS related tests fail during package build Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org Now that libwebservice-ils-perl is available to the nightly server, related tests fail: 1. # Failed test 'error_message()' # at t/Koha_ExternalContent_OverDrive.t line 52. # Original: # Can't connect to oauth.overdrive.com:443 # Request: # POST https://oauth.overdrive.com/token # Authorization: Basic RFVNTVk6RFVNTVk= # User-Agent: Koha/18.06.00.041 # Content-Length: 126 # Content-Type: application/x-www-form-urlencoded # # redirect_uri=http%3A%2F%2Fmykoha.org%2Fcgi-bin%2Fkoha%2Fexternal%2Foverdrive%2Fauth.pl&grant_type=authorization_code&code=blah # # Response: # 500 Can't connect to oauth.overdrive.com:443 # Content-Type: text/plain # Client-Date: Sat, 13 Oct 2018 22:30:28 GMT # Client-Warning: Internal response # # Can't connect to oauth.overdrive.com:443 # # Name or service not known at /usr/share/perl5/LWP/Protocol/http.pm line 49. # # Turned into: # Can't connect to oauth.overdrive.com:443 # Looks like you failed 1 test of 5. t/Koha_ExternalContent_OverDrive.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests 2. # Failed test 'Invalid RecordedBooks partner credentials' # at t/Koha_ExternalContent_RecordedBooks.t line 29. # Looks like you failed 1 test of 3. t/Koha_ExternalContent_RecordedBooks.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests (less 1 skipped subtest: 1 okay) -- You are receiving this mail because: You are watching all bug changes.

1 39

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #192 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Over the last little while in amongst lots of other stuff I have made changes to fix the issues Katrin outlined in comments 174 and #175. Please retest :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #191 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 83381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83381&action=ed… Bug 15565: (follow-up) Place multiple holds from opac-search.pl Previously before this patch if you selected multiple bibliographic results from opac-search.pl and selected 'Place hold' and confirmed the hold only 1 hold on the first of the selected biblios would be placed. This patch fixes this bug and enables users to be able to place holds on multiple bibliographic records in opac-search.pl, select 'Place hold', select if they want each of these holds to be on 'Next available', 'Next available from group', or 'A specific item' and place their holds and all the holds they placed will be placed correctly. Test plan: 1. Follow test plan on the last patch - (Don't apply this patch) 2. Try to select multiple bibliographic record checkboxes and select 'Place hold' 3. Confirm holds and notice you are re-directed to opac-user.pl and only the first hold has been placed 4. Apply this patch 5. Restart memcached and plack if running 6. Repeat steps 2 and 3 and notice all holds were placed 7. Repeat step 2 and then select a variety of 'A specific item' and 'Next available item' holds for each of the bibliographic holds and confirm they are all placed correctly 8. Confirm you can still place multiple holds correctly in opac-reserve accessing from a OPAC biblio detail page Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 19 Dec '18

19 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #190 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 83380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83380&action=ed… Bug 15565: (follow-up) Changes to maximum hold allowed logic Implemented changes to the logic to address Katrin Fischer's points in comment #175, also changed the modal box wording to use 'hold' not 'reserve' Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe the first item checkbox is checked and other unchecked checkboxes are disabled. 6. Repeat step 4 this time setting holds per day to 5 7. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays 8. Select a second item checkbox and observe a modal saying you have reached the maximum number of holds for the record is loaded - notice the wording 'hold' not 'reserve' in use in the modal box 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed - notice the wording of 'hold' not 'reserve' is used in the modal box. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. In both the OPAC and staff client try placing a record level hold, selecting a value from the 'Holds to place (count)' dropdown. Notice that the maximum value of this is the lowest value out of the 'maximum number of holds per record', 'maximum number of holds per day' and the 'maxreserves' system preference so in this case it will be 2 18. Save and notice 2 holds are placed 19. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0