February 2018 - Koha-bugs - lists.koha-community.org

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 72108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72108&action=ed… Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan Adding a days>0 test in the sub with a POD line. Specific subtest for this sub added in Suggestions.t. Test plan: Run t/db_dependent/Suggestions.t again. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 72107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72107&action=ed… Bug 13287: (QA follow-up) Prepare Suggestions.t for changes Just rearranging some modules here. Adding Koha::Database and schema calls. Test plan: Run t/db_dependent/Suggestions.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #39 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 72106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72106&action=ed… Bug 13287: (QA follow-up) Add db revision Added missing upgrade SQL system preference. Corrected system preference screen message Fixes on purge_suggestions.pl - perlcritic friendlier - address $PERL5LIB comment by using $PROGRAM_NAME (comment #10) - used STDERR (comment #10) - perltidy TEST PLAN --------- $ ./installer/data/mysql/updatedatabase.pl -- should run upgrade and generate new systempreference in table $ ./misc/cronjobs/purge_suggestions.pl --help -- should give help with a real path used instead of $PERL5LIB. $ ./misc/cronjobs/purge_suggestions.pl -days -1 -- should give error message as expected $ ./misc/cronjobs/purge_suggestions.pl -days 0 -- should give error message as expected Go to OPAC system preferences tab and check the PurgeSuggestionsOlderThan system preference -- message should be as expected (see comment #9) run koha qa test tools -- all should pass Signed-off-by: Marc Veron <veron(a)veron.ch> Signed-off-by: Jon Knight <J.P.Knight(a)lboro.ac.uk> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Amended: Moved new pref from OPAC to Acquisitions preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #38 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 72105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72105&action=ed… Bug 13287: Add a system preference to define the number of days used in purge_suggestions.pl The system preferences value is used whenever purge_suggestions.pl is called without the 'days' parameter. This patch uses the preference description suggested by comment #9. This version should now be cleanly applicable. I Apply the patch II Run updatedatabase.pl a) Run purge_suggestions.pl without the days parameter - validate that there is an error message b) Run purge_suggestions.pl with the days parameter - validate that there is no error message c) Insert a number of days in the system variable PurgeSuggestionsOlderThan d) Run purge_suggestions.pl without the days parameter - validate that there is no error message Signed-off-by: Liz Rea <liz(a)catalyst.net.nz> Tested per plan, all tests pass. Signed-off-by: Marc Veron <veron(a)veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64696|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72104|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64696|0 |1 is obsolete| | --- Comment #38 from Victor Grousset/tuxayo <victor.grousset(a)biblibre.com> --- Created attachment 72104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72104&action=ed… Bug 12310 : Modify scripts in order to convert any string to the good format paxed's solution is obsolete since the form asks for a number. The script includes 2 function which check if it is possible to transform properly into the format "XX.XX" and which do it. The money symbols are ignored. All other symbols are ignored. Modify the tooltips helping the users entering monrtary information in the right format. Fields on all those pages are now automatically formatted - cgi-bin/koha/admin/aqbudgetperiods.tt - cgi-bin/koha/admin/aqbudgets.tt - cgi-bin/koha/members/mancredit.tt - cgi-bin/koha/members/maninvoice.tt Test plan : 1) Check you can't enter any string except like "XX.XX" when - you create a Budget (Administration->Budget) - you write a fine (Circulation->[select a Borrower]->new fine ) - you pay an existing fine 2) Apply patch 3) Check you can enter any string with - anything you want - a , or a . as separator (both are default) - change the syspref DigitSeparator into the separator you with and check again ex : XXX,XXX,XXX.XX => . XXX XXX XXX,XX => ,. or , XXX XXX XXX.XX => ,. or . The string is immediately changed after you change the field Please note that any other symbole is ignored -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20233] New: When paying fines, Koha always claims user has no fines
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20233 Bug ID: 20233 Summary: When paying fines, Koha always claims user has no fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com While testing a related bug I noticed that on the 'pay fines' tab, there is always a message showing: ... has no outstanding fines. It doesn't matter if I added fines to the accounts or not, the message is always there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 --- Comment #37 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0