February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11317] Add a way to access files from the intranet
by bugzilla-daemon＠bugs.koha-community.org 25 Feb '18

25 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #119 from Josef Moravec <josef.moravec(a)gmail.com> --- Sorry, still some issues found with this: 1) Please undo the changes of spaces to tabs in reports-home.tt - there is no reason to touch these lines and tab char is forbidden 2) Move javascript to the end of page - see JS12 rule: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS12:_Include_javasc… 3) Please add _[% KOHA_VERSION %] to css path, see bug 12904 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #12 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 72170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72170&action=ed… Bug 12502: QA Follow-up 1) The method under C4 was deleted. There wasn't any reason for a method under Koha, in the end, because it's a simple update that requires no additional processing. If I had to do any legwork with the data before updating the Order fields, I would've written a wrapper. As it stands right now, the work can be done directly in the controller without polluting the Koha/Acquisition/Orders.pm class. 2) Added the ISBN field to csv_header, and added that value to lateorders-export I've also changed the string internaldate to internalnote, small typo fix. 3) Made adjustements client-side and server-side. In the browser, you can now see a small loading icon to inform the user that the 'Save note' button actually triggered an action. A new alert message also informs the user if something awry happened while updating the orders' notes. I took a look at the user page, to see how notes were saved, but I was not satisfied with the idea of mixing an Ajax call with a window.location.reload; doesn't make sense in my mind to uselessly reload the page if the information had already reached the server, and since it was already coded that way, I felt like this change was the best course of action. Server-side, it is now possible to save an empty field. Before this patch, 'if($note)' would actually fail on an empty string, which meant you could never erase a note, for any reason whatsoever. After testing this patch, if the width of the input is still something that you'd like to see changed, I'll have no problem reducing it a little, but you'll have to tell me how large is _too_ large :) 4) Order no. -> Order line 5) Added the new columns to the admin/visibility yaml 6) It would be possible to also display an ISSN, but I won't make this patch any large than it is for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67587|0 |1 is obsolete| | --- Comment #11 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 72169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72169&action=ed… Bug 12502 - Add ordernumber and ISBN to late order Adds ordernumber as 2nd column and ISBN as last Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12502] Add columns for note, order number and ISBN to late orders page
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67586|0 |1 is obsolete| | --- Comment #10 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 72168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72168&action=ed… Bug 12502 - Add vendor and internal note to late orders page Followed test plan and patch worked as described. Also ran QA test tools and all modified files passed. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #43 from Charles Farmer <charles.farmer(a)inlibro.com> --- Hi Katrin, Thank you once again for commenting! I've tackled points 1 to 4 of comment#38. It'd be great if this version could once again be tested. For point #5, from what I see in the code, you're correct: highlighting is only applied to subfields. On the issue of changing the CSS class to highlight important fields differently from mandatory fields, it sounds like an idea I can get behind. Do you have a color suggestion for those fields? Clearer yellow? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer <charles.farmer(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer(a)inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8643] Add important constraint to marc subfields
by bugzilla-daemon＠bugs.koha-community.org 23 Feb '18

23 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #42 from Charles Farmer <charles.farmer(a)inlibro.com> --- Created attachment 72157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72157&action=ed… Bug 8643 - QA Follow-up * Field 'important' now added after 'mandatory' in table marc_tag_structure * Removed modification on table serialitems in kohastructure.sql * Removed bogus line in marctagstructure.tt * Fixed the missing tag number in the alert message -- You are receiving this mail because: You are watching all bug changes.

1 0