February 2018 - Koha-bugs - lists.koha-community.org

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71267|0 |1 is obsolete| | --- Comment #190 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72076&action=ed… Bug 11708: UT: Use DateTime instead of localtime+sprintf -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71266|0 |1 is obsolete| | --- Comment #189 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72075&action=ed… Bug 11708: UT: Replace 'ok' by 'is' where appropriate -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71265|0 |1 is obsolete| | --- Comment #188 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72074&action=ed… Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. In the process, this patch adds 4 new "Koha::Object" modules: - Koha::Bookseller(s) - Koha::Basket(s) - Koha::Basketgroup(s) - Koha::Order(s) It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71264|0 |1 is obsolete| | --- Comment #187 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72073&action=ed… Bug 11708: Place "Basket groups" menu entry on top of the side navigation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71263|0 |1 is obsolete| | --- Comment #186 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72072&action=ed… Bug 11708: Remove column aqbasketgroups.closed It is redundant with aqbasketgroups.closeddate Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: use atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71262|0 |1 is obsolete| | --- Comment #185 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72071&action=ed… Bug 11708: basketgroup.pl can now display basketgroups for all suppliers This happens when no booksellerid is given. This patch also adds 4 columns: - No. of ordered titles - No. of received titles - Ordered amount - Charged amount (amount of received orders) Add filters to basketgroup tables columns Show closed date in closed basketgroups tables Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71261|0 |1 is obsolete| | --- Comment #184 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72070&action=ed… Bug 11708: Unit tests for aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71260|0 |1 is obsolete| | --- Comment #183 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 72069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72069&action=ed… Bug 11708: Add aqbasketgroups.closeddate Signed-off-by: juliette levast <juliette.levast(a)iepg.fr> Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Patch updated: Use atomic update -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |magnus(a)libriotech.no -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11936] Consistent log message for item insert
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '18

22 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11936 --- Comment #4 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 72066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72066&action=ed… Bug 11936 - Consistent log message for item insert If you use bulkmarcimport.pl to import records with items it looks like the successfull insert of the record is reported multiple time, but the second and subsequent "ok" is really related to importing the item(s). This patch changes the log message on successfully inserting an item to match the log message given when inserting an item fails. To test, the easy way: - Look at lines 530 and 536 of bulkmarcimport.pl, and note that the "op" in those two lines are different - Apply the patch - Look at lines 530 and 536 again, and note that the "op" is now identical, and that this makes sense, since they are both related to the same operation, specifically inserting an item To test, the hard way - Have some records with items - Import the records with bulkmarcimport.pl, and make sure to specify the -l option, to create a log of the actions taken - Look at the log and verify it looks something like this: id;operation;status 1;insert;ok 1;insert;ok 2;insert;ok 2;insert;ok - Apply this patch and import some more records with items. The log should now be similar to this: id;operation;status 1;insert;ok 1;insertitem;ok 2;insert;ok 2;insertitem;ok -- You are receiving this mail because: You are watching all bug changes.

1 0