February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 --- Comment #33 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72060&action=ed… Bug 15492: Add KOHA_VERSION to included .css and .js Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70179|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72059&action=ed… Bug 15492: Display nicer message on data corruption This patch hides scary messages and changes the wording for a more idiomatic approach. Thanks to Nick :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70178|0 |1 is obsolete| | --- Comment #31 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72058&action=ed… Bug 15492: Make SCI use its own sysprefs and CSS file Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70177|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72057&action=ed… Bug 15492: Make existing code aware of new self_check* permissions This patch makes the existing code for SCO use the new permissions schema for self check modules. Specifically addresses this change: circulate => self_checkout becomes slef_check => self_checkout_module about.pl checks are dejusted too. get_template_and_user gets refactored to avoid code duplication and the conditions are adjusted for the new permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70176|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72056&action=ed… Bug 15492: New sysprefs and permissions In order to make this module unrelated to the SCO module, this patch introduces the following sysprefs: - SelfCheckInMainUserBlock - SelfCheckInModuleUserID - SelfCheckInTimeout - SelfCheckInUserCSS - SelfCheckInUserJS It also adds a new user flag and sub-permission: - self_check => self_checkin_module and moves the circulate => self_checkout permission into - self_check => self_checkout_module Descriptions are adjusted accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70175|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72055&action=ed… Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70174|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72054&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70173|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72053&action=ed… Bug 15492: Add the SelfCheckInModule syspref Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | CC| |josef.moravec(a)gmail.com Status|Signed Off |Patch doesn't apply --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- This patchset does not apply on current master. Also, could you please add KOHA_VERSION to included js and css files in templates? -- You are receiving this mail because: You are watching all bug changes.

1 0