February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70177|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72057&action=ed… Bug 15492: Make existing code aware of new self_check* permissions This patch makes the existing code for SCO use the new permissions schema for self check modules. Specifically addresses this change: circulate => self_checkout becomes slef_check => self_checkout_module about.pl checks are dejusted too. get_template_and_user gets refactored to avoid code duplication and the conditions are adjusted for the new permissions. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70176|0 |1 is obsolete| | --- Comment #29 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72056&action=ed… Bug 15492: New sysprefs and permissions In order to make this module unrelated to the SCO module, this patch introduces the following sysprefs: - SelfCheckInMainUserBlock - SelfCheckInModuleUserID - SelfCheckInTimeout - SelfCheckInUserCSS - SelfCheckInUserJS It also adds a new user flag and sub-permission: - self_check => self_checkin_module and moves the circulate => self_checkout permission into - self_check => self_checkout_module Descriptions are adjusted accordingly. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70175|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72055&action=ed… Bug 15492: (QA follow-up) Reset SCI if idle for 30 seconds Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70174|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72054&action=ed… Bug 15492: Add SCI module This patch adds the SCI module, and adapts C4::Auth to know about it. The current behaviour is: - Requires admin user initialization/login - Uses the logged users' library - A form allows to scan multiple barcodes - A button sends the barcode list to the controller to batch perform the checkins - Successful and failed checkins are sent to the template - Results are displayed - Logout link To test: - Apply this patches - Make sure you upgrade: $ kshell k$ perl installer/data/mysql/updatedatabase.pl - Have 'SelfCheckInModule' disabled - Go to http://kohadev.myDNSname.org:8080/cgi-bin/koha/sci/sci-main.pl [1] => SUCCESS: You are rejected because the feature is disabled - Enable 'SelfCheckInModule' - Go to the previous URL => SUCCESS: You are required to login - Login with a user WITHOUT self_checkout permissions => SUCCESS: You are not allowed to log into the Self check-in module. - Login with a user WITH self_checkour permissions => SUCCESS: You gain access, and are presented the UI - Go through the several options => SUCCESS: All works as it should - Click the 'Help' link => SUCCESS: A help text is displayed on a modal - Sign off :-D - Bonus points: $ kshell k$ qa -c 2 -v 2 => SUCCESS: All tests green [1] Adjust to your dev's OPAC setup Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70173|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 72053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72053&action=ed… Bug 15492: Add the SelfCheckInModule syspref Signed-off-by: David Bourgault <david.bourgault(a)inlibro.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15492] Stand alone self check-in tool
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | CC| |josef.moravec(a)gmail.com Status|Signed Off |Patch doesn't apply --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- This patchset does not apply on current master. Also, could you please add KOHA_VERSION to included js and css files in templates? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Claudio <costalc(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #80 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 72034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72034&action=ed… Bug 14576: Followup Fix (remove) extra call for item Fix rebase error code duplication -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #79 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 72033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72033&action=ed… Bug 14576: Unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14576] Allow arbitrary automatic update of location on checkin
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '18

21 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70795|0 |1 is obsolete| | Attachment #70796|0 |1 is obsolete| | Attachment #70797|0 |1 is obsolete| | --- Comment #78 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 72032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72032&action=ed… Bug 14576 - Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) -- You are receiving this mail because: You are watching all bug changes.

1 0