February 2018 - Koha-bugs - lists.koha-community.org

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #49 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71876&action=ed… Bug 9573: Lost items report - Add a new "Export selected items" link Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71875&action=ed… Bug 9573: Lost items report - Add a new itemlost_on column This patch adds a new "Lost on" column to the result table Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #47 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71874&action=ed… Bug 9573: Lost items report - add KohaTable to itemlost Before this patch set, we used KohaTable to display a table with the column visibility plugin, and an usual dataTable initialisation for the filters. For the lost items report table we will need both. To do so we need to reorganize the code a bit We cannot pass a selector but the id of the node which represents the table. Indeed it is how works currently the filters (we may want to improve that later) Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 --- Comment #46 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71873&action=ed… Bug 9573: Lost items report - Move filters code to a separate js file For the next patches we will need to reuse what is already done on the bibliographic record detail page. This patch moves the code to make it reusable easily and avoid copy and paste. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71275|0 |1 is obsolete| | Attachment #71276|0 |1 is obsolete| | Attachment #71277|0 |1 is obsolete| | Attachment #71278|0 |1 is obsolete| | Attachment #71279|0 |1 is obsolete| | Attachment #71280|0 |1 is obsolete| | Attachment #71281|0 |1 is obsolete| | Attachment #71282|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71872&action=ed… Bug 9573: Lost items report - Add items.notforloan as a filter This patch adds a new "Not for loan" status filter to the lost items report. Test plan: 0/ Apply all patches from this patch set 1/ Use the new "Not for loan" filter to search lost items 2/ The table result must be consistent and a new "Not for loan" column should be there 3/ Confirm that you are able to hide/show this column with the column settings tool. Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 70043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043 Bug 11373: Add a "cash register" feature to the fine payment form. Review of attachment 70043: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- I am wondering about the usability here. For paying a partial fine I am forced to manually edit 2 input fields which adds more steps for the busy circulation desk and also might cause more potential for errors. Maybe it would make sense to automatically change the amount collected to the amount paid when it's changed? Or to make this optional? I'd like to get some librarians to weigh in on these changes if possible. Some other small issues noted below. QA tools are clean. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +98,5 @@ > </ul> > <div class="tabs-container"> > +[% IF (error_negative) %] > + <div id="error_message" class="dialog alert"> > + <span>The amount paid can't be negative!</span> Why the additional spans everywhere? A message inside a div should not need it (see also other cases below). @@ +175,5 @@ > + [% give_change %] > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid :</label> No additional spaces between text and : please :) ::: members/paycollect.pl @@ +128,5 @@ > + elsif ($total_paid < $total_due and $total_collected ne $total_paid) { > + $template->param( > + amount_paid => sprintf('%.2f', $total_paid), > + amount_collected => sprintf('%.2f', $total_collected), > + give_change => sprintf('%.2f',($total_collected-$total_paid)) I am wondering about the formatting done in various spots in the patch. I'll ask a second opinion about that. Please note that we have a TT plugin for displaying prices in different ways and CurrencyFormat system preference (entering prices still happens with . ). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Jonathan, there are some conflicts about the new VERSION variable for .js files. I've tried to resolve those, but get tons of errors in the QA scripts. Can you please take a look? I will paste some examples below: FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/sco/help.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 13) FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/opac-user.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 742) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 719) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 862) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 46) OK git manipulation FAIL spelling transfered ==> transferred FAIL valid (Missing operator before shelfbrowser?) String found where operator expected syntax error (Missing operator before 'shelfbrowser.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/shelfbrowser.tt had compilation errors. Bareword found where operator expected Unquoted string "shelfbrowser" may clash with future reserved word FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt FAIL critic Code before strictures are enabled at line 1, column 1. See page 429 of PBP. OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Bareword found where operator expected (Missing operator before 'doc-head-open.inc'?) (Missing operator before 'doc-head-close.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt had compilation errors. Unquoted string "render" may clash with future reserved word (Missing semicolon on previous line?) (Missing operator before suggestion?) (Missing operator before divider?) syntax error Unquoted string "label" may clash with future reserved word (Missing operator before Koha?) (Missing operator before jsinclude?) Unquoted string "html" may clash with future reserved word (Missing operator before 'opac-bottom.inc'?) Unknown regexp modifier "/v" Unquoted string "divider" may clash with future reserved word String found where operator expected Unquoted string "opac" may clash with future reserved word Unknown regexp modifier "/n" Unquoted string "jsinclude" may clash with future reserved word Unquoted string "suggestions" may clash with future reserved word Unquoted string "cssinclude" may clash with future reserved word Unquoted string "koha" may clash with future reserved word Unquoted string "title" may clash with future reserved word (Missing operator before cssinclude?) Unquoted string "pl" may clash with future reserved word -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #112 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- QA tests added: commit 42ce839b1a61e5fef1836b4525bf942c6b53d878 Bug 12904: Add [% KOHA_VERSION %] for .js and .css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20004] New: Adapt /v1/cities to new naming guidelines
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Bug ID: 20004 Summary: Adapt /v1/cities to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20