February 2018 - Koha-bugs - lists.koha-community.org

[Bug 11373] Add a "cash register" feature to the fine payment form.
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 70043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70043 Bug 11373: Add a "cash register" feature to the fine payment form. Review of attachment 70043: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- I am wondering about the usability here. For paying a partial fine I am forced to manually edit 2 input fields which adds more steps for the busy circulation desk and also might cause more potential for errors. Maybe it would make sense to automatically change the amount collected to the amount paid when it's changed? Or to make this optional? I'd like to get some librarians to weigh in on these changes if possible. Some other small issues noted below. QA tools are clean. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +98,5 @@ > </ul> > <div class="tabs-container"> > +[% IF (error_negative) %] > + <div id="error_message" class="dialog alert"> > + <span>The amount paid can't be negative!</span> Why the additional spans everywhere? A message inside a div should not need it (see also other cases below). @@ +175,5 @@ > + [% give_change %] > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid :</label> No additional spaces between text and : please :) ::: members/paycollect.pl @@ +128,5 @@ > + elsif ($total_paid < $total_due and $total_collected ne $total_paid) { > + $template->param( > + amount_paid => sprintf('%.2f', $total_paid), > + amount_collected => sprintf('%.2f', $total_collected), > + give_change => sprintf('%.2f',($total_collected-$total_paid)) I am wondering about the formatting done in various spots in the patch. I'll ask a second opinion about that. Please note that we have a TT plugin for displaying prices in different ways and CurrencyFormat system preference (entering prices still happens with . ). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9573] Ability to download items lost report
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '18

17 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Jonathan, there are some conflicts about the new VERSION variable for .js files. I've tried to resolve those, but get tons of errors in the QA scripts. Can you please take a look? I will paste some examples below: FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/sco/help.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 13) FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/opac-user.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 742) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 719) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 862) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 46) OK git manipulation FAIL spelling transfered ==> transferred FAIL valid (Missing operator before shelfbrowser?) String found where operator expected syntax error (Missing operator before 'shelfbrowser.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/shelfbrowser.tt had compilation errors. Bareword found where operator expected Unquoted string "shelfbrowser" may clash with future reserved word FAIL koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt FAIL critic Code before strictures are enabled at line 1, column 1. See page 429 of PBP. OK forbidden patterns OK git manipulation OK pod OK spelling FAIL valid Bareword found where operator expected (Missing operator before 'doc-head-open.inc'?) (Missing operator before 'doc-head-close.inc'?) koha-tmpl/opac-tmpl/bootstrap/en-GB/modules/svc/suggestion.tt had compilation errors. Unquoted string "render" may clash with future reserved word (Missing semicolon on previous line?) (Missing operator before suggestion?) (Missing operator before divider?) syntax error Unquoted string "label" may clash with future reserved word (Missing operator before Koha?) (Missing operator before jsinclude?) Unquoted string "html" may clash with future reserved word (Missing operator before 'opac-bottom.inc'?) Unknown regexp modifier "/v" Unquoted string "divider" may clash with future reserved word String found where operator expected Unquoted string "opac" may clash with future reserved word Unknown regexp modifier "/n" Unquoted string "jsinclude" may clash with future reserved word Unquoted string "suggestions" may clash with future reserved word Unquoted string "cssinclude" may clash with future reserved word Unquoted string "koha" may clash with future reserved word Unquoted string "title" may clash with future reserved word (Missing operator before cssinclude?) Unquoted string "pl" may clash with future reserved word -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #112 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- QA tests added: commit 42ce839b1a61e5fef1836b4525bf942c6b53d878 Bug 12904: Add [% KOHA_VERSION %] for .js and .css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20004] New: Adapt /v1/cities to new naming guidelines
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20004 Bug ID: 20004 Summary: Adapt /v1/cities to new naming guidelines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 20

[Bug 19801] New: Internal note added to the detail's user page
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19801 Bug ID: 19801 Summary: Internal note added to the detail's user page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: patrick.robitaille(a)collecto.ca QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hi, When a user have a internal note in his account, this note is visible when we consult the user's informations in the "check-out" page.We see this note too when we do a chechk-out for this user in the circulation page. It would be great to see this note too in the user "details" page in his account. Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 39

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9851] way to get full records for purchase suggestions
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9851 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20232] New: www/search_utf8.t does not clean up
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20232 Bug ID: 20232 Summary: www/search_utf8.t does not clean up Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org At least 2 tables (import_batches and biblio) are not cleaned up at the end of the tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19913] New: Embedded HTML5 videos are broken
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19913 Bug ID: 19913 Summary: Embedded HTML5 videos are broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18754 The video element is badly generated. Caused by commit 752aef4593f1aa2d64700bf9738e7e03907eb1cd Bug 18754: Translatability: Get rid of exposed tt directives in opac-detail.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18754 [Bug 18754] Translatability: Get rid of exposed tt directives in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.

1 16

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20231 Bug ID: 20231 Summary: Hacked by SpawN ~ LH # ©2018 All Rights Reversed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs(a)lists.koha-community.org Reporter: nomlebirde(a)ziyap.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 71842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71842&action=ed… Hacked by SpawN ~ LH # ©2018 All Rights Reversed Hacked by SpawN ~ LH # ©2018 All Rights Reversed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4