February 2018 - Koha-bugs - lists.koha-community.org

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #178 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71764&action=ed… Bug 12598: Remove warnings from tests and make them pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #177 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71763&action=ed… Bug 12598: Add use Koha::Patron::debarments statement Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #176 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71762&action=ed… Bug 12598: Re-add bug 18555: Create patron list from patron import Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #175 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71761&action=ed… Bug 12598 Allow matched patron to be updated When a test was introduced to not add duplicate userids it overlooked that if you were matching on userid you do not want the update to be rejected. Add a test to overcome this logical flaw if updating by matching userid -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #174 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71760&action=ed… Bug 12598: Re-add some missing stuffs This patch will have to be squashed with previous ones, but for readability I prefer to let it alone for now. It reintroduces 2 missing changes: commit fd123903651435c56ca14d88897e9ce4d7a38bb5 Bug 15010: Import patron tool creates 'duplicate' restrictions ( debarments ) commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7 Bug 12543 - Add userid as matchpoint for "Import patrons" tool Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #173 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71759&action=ed… Bug 12598: Fix conflict with 17829 - GetMember Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #172 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71758&action=ed… Bug 12598: Fix conflict with bug 16911 Tests will have to be written for this change Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #171 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71757&action=ed… Bug 12598: Update code to use new modules Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71755|0 |1 is obsolete| | --- Comment #170 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71756&action=ed… Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Fix merge to master. Backport 3 updates from latest import_borrowers.pl Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes package Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Rebase + backport of 16426 plus fixing 16426 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598: catch warnings raised by import_patrons in tests Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12598] New misc/import_borrowers.pl command line tool
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66575|0 |1 is obsolete| | Attachment #66576|0 |1 is obsolete| | Attachment #66577|0 |1 is obsolete| | Attachment #66578|0 |1 is obsolete| | Attachment #66579|0 |1 is obsolete| | Attachment #66580|0 |1 is obsolete| | Attachment #67276|0 |1 is obsolete| | Attachment #67277|0 |1 is obsolete| | Attachment #70265|0 |1 is obsolete| | Attachment #70266|0 |1 is obsolete| | --- Comment #169 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 71755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71755&action=ed… Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)kul.oslo.kommune.no> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Fix merge to master. Backport 3 updates from latest import_borrowers.pl Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes package Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598 - Rebase + backport of 16426 plus fixing 16426 Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 12598: catch warnings raised by import_patrons in tests Signed-off-by: Colin Campbell <colin.campbell(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0