February 2018 - Koha-bugs - lists.koha-community.org

[Bug 20221] New: Fix for JavaScript error during checkout or holds patron search
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20221 Bug ID: 20221 Summary: Fix for JavaScript error during checkout or holds patron search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 19641 If you submit a patron name to the checkout form it will trigger a JavaScript error in the console because there is JS embedded in an include, circ-patron-search-results.inc. This JS should be moved so that it is included in the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 [Bug 19641] Move patron templates JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 20193] New: Label export displaying on never-ending webpage
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20193 Bug ID: 20193 Summary: Label export displaying on never-ending webpage Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: claire_gravely(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org When trying to export a label batch, the pop up frame to display export options is not being correctly created. Instead the export information is at the bottom of a never-ending page. (Scrolling never reaches it). To reproduce: Go to Manage Label batches (label-manage.pl) and/or edit a batch (label-edit-batch.pl) and try to export. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #111 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #110) > Created attachment 71822 [details] [review] > Bug 12904: Add KOHA_VERSION to few more .css Pushed to master. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12904] Force browser to load new javascript files after upgrade
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #110 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71822&action=ed… Bug 12904: Add KOHA_VERSION to few more .css -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9290] Restricting patron category for online purchase suggestion
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 Vinod <mishravk79(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mishravk79(a)gmail.com --- Comment #4 from Vinod <mishravk79(a)gmail.com> --- @Indranil, I will be the part of co-sponsor, trying to get some more very soon. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #11 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71802&action=ed… Bug 12001: Format DEBT correctly Before this patchset, DEBT was formatted in the module, now it should be done template-side. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71801&action=ed… Bug 12001: Prove that result are the same \o/ -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71800&action=ed… Bug 12001: Move GetMemberAccountBalance to Koha::Account->non_issues_charges As said previously, GetMemberAccountBalance returns ( the balance, the non issues charges, the other charges) The other charges are the balance - the non issues charges. In this patch we remove the subroutine from C4::Members and use the new Koha::Account->non_issues_charges subroutine instead -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71799&action=ed… Bug 12001: Add tests Yes, we need tests to make sure we understand what is going on in this subroutine. The different combination of HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge are tested here with the subroutine we are going to remove (GetMemberAccountBalance). In one of the next patches the new methods will be used to make sure we are not modifying the calculated values (except the formatting). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '18

16 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70342|0 |1 is obsolete| | Attachment #70343|0 |1 is obsolete| | Attachment #70344|0 |1 is obsolete| | Attachment #70345|0 |1 is obsolete| | Attachment #70346|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 71798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71798&action=ed… Bug 12001: Move GetMemberAccountRecords to the Koha namespace The GetMemberAccountRecords may be a perf killer, it retrieves all the account lines of a patron and then the related item and biblio information. Most of the time we only want to know how much the patron owns to the library (sum of amountoutstanding). We already have this information in Koha::Patron->account->balance. This patch replaces the occurrences of this subroutine by fetching only the information we need, either the balance, the detail, or both. It removes the formatting done in the module, to use the TT plugin 'Price' instead. There is a very weird and error-prone behavior/feature in GetMemberAccountBalance (FIXME): as the accountlines.accounttype is a varchar(5), the value of the authorised value used for the ManInvInNoissuesCharge pref (category MANUAL_INV) is truncated to the 5 first characters. That could lead to unexpected behaviors. On the way, this patchset also replace the GetMemberAccountBalance subroutine, which returns the balance, the non issues charges and the other charges. We only need to have the balance and the non issues charges to calcul the third one. Test plan: Add several fees for a patron and play with HoldsInNoissuesCharge, RentalsInNoissuesCharge and ManInvInNoissuesCharge. The information (biblio and item info, as well as the account line) must be correctly displayed on the different screens: 'Fines' module, fine slips, circulation module Note that this patchset could introduce regression on price formatting, but will be easy to fix using the TT plugin. -- You are receiving this mail because: You are watching all bug changes.

1 0