February 2018 - Koha-bugs - lists.koha-community.org

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #51 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71319&action=ed… Bug 15486: Make circ rules UI handle holds_per_day This patch makes the staff UI correctly handle the holds_per_day configuration. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #50 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71318&action=ed… Bug 15486: Modify request.tt to handle the new error string This patch makes reserve/request.pl display a convenient error description when a hold cannot be placed due to the new daily limit configuration. To test: - Apply this patchset - Upgrade - Configure your circulation rules so there's a daily limit for holds - Place holds so the patron reaches the maximum - Place one more hold - Notice the hold cannot be placed and a convenient error message is displayed. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #49 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71317&action=ed… Bug 15486: Extend CanItemBeReserved so it handles daily holds limits This patch implements the required changes in C4::Reserves::CanItemBeReserved so it implements a daily limit on holds. It returns the 'tooManyReservesToday' string if the policy doesn't allow placing the hold. It returns 'OK' (current behaviour) otherwise. To test: - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: Tests fail because the error condition is not making CanItemBeReserved return the desired error code. - Apply this patch - Run: k$ prove t/db_dependent/Holds.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #48 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71316&action=ed… Bug 15486: Unit tests This patch introduces unit tests for the new circulation rules option that allows setting a max holds per day limit. To test: - Apply the patch - Run: $ sudo koha-shell kohadev k$ cd kohaclone k$ prove t/db_dependent/Holds.t => FAIL: CanItemBeReserved doesn't check the amount of holds per day and the introduced error code is not returned. OK is returned instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #47 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71315&action=ed… Bug 15486: DBIC update schema -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #46 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 71314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71314&action=ed… Bug 15486: DB structure change This patch adds a new column __max_holds_per_day__ to the issuingrules table. It's going to be used to set a daily limit for holds. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68730|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15486] Restrict number of holds placed by day
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '18

07 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68729|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0