February 2018 - Koha-bugs - lists.koha-community.org

[Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '18

04 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20020, 20019, 20018, 20017, | |20016, 20015, 20012, 20013, | |20011, 20010, 20009, 20000, | |19998, 19997, 19996, 19995, | |19993, 19992 --- Comment #27 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This bug hasn't seen much attention for a few years now. During the Open Source Academy 2018 the students switched a lot (all?) scripts over to use Modern::Perl; instead of the separate use strict; use warnings; pragmas. I think by not using use warnings; in those scripts, we have possibly been hiding problems and switching it on globally might now be the way to go. We can keep an eye on the logs as we are still rather early in the release cycle and keep fixing warns as we find them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19992 [Bug 19992] use Modern::Perl in Admin perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19993 [Bug 19993] use Modern::Perl in Acquisition perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 [Bug 19995] use Modern::Perl in Catalogue perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19996 [Bug 19996] use Modern::Perl in cataloguing perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19997 [Bug 19997] use Modern::Perl in Circulation perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19998 [Bug 19998] use Modern::Perl in error perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20000 [Bug 20000] use Modern::Perl in installer perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20009 [Bug 20009] use Modern::Perl in Members perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20010 [Bug 20010] use Modern::Perl in Patroncards perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20011 [Bug 20011] use Modern::Perl in plugins perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20012 [Bug 20012] use Modern::Perl in Reports perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20013 [Bug 20013] use Modern::Perl in Reserves perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20015 [Bug 20015] use Modern::Perl in Serials perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20016 [Bug 20016] use Modern::Perl in svc scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20017 [Bug 20017] use Modern::Perl in Tools perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20018 [Bug 20018] use Modern::Perl in offline circulation perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019 [Bug 20019] use Modern::Perl in miscellaneous perl scripts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20020 [Bug 20020] use Modern::Perl in XT scripts -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '18

04 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71087|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 71175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71175&action=ed… Bug 12932: When all modules installed, Perl version check ignored The description in comment #0 is quite true, because the scope of the $checkmodule variable is local to just the module checking. If we change the scope, we can include the perl check as part of the new scope, and thus properly set its value. As Debian Jessie, Stretch and Ubuntu Xenial all have good versions of Perl by default, the easiest way to test this is to: - make sure to have some optional modules not installed. - change the system preference 'Version' to one just under the current version in your SQL client. - modify the version check line to 5.030000 - restart_all and try going to the staff client. -- This should not inform you that your perl version is bad. - git reset hard back to origin/master - apply the patch - modify the version check line to 5.030000 - change the system preference 'Version' to one just under the current version in your SQL client. - restart_all and try going to the staff client. -- This should trigger the patch, and you should be informed your perl version is bad. - git reset hard back to origin/master - apply the patch - run koha qa test tools Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12932] Web installer's Perl version check will not raise errors if all modules are installed
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '18

04 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '18

04 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71111|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 71172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71172&action=ed… Bug 11827: Untranslatable "Cancel Rating" in jQuery rating plugin - Make the "Cancel rating" text translatable (and change capitalization to conform to Koha coding guidelines) - Improve the two other messages to use formatted strings instead of concatenation. - Use the exact same text for the "your rating" text, so it only appears once in the po-file. Test plan: 1. See that the "Cancel rating" -text doesn't appear in po/xx-YY-opac-bootstrap.po 2. Note how there's two versions of the your rating -text ("your rating: %s, " and "your rating:") in the po-file 3. Apply patch 4. Update the xx-YY translation 5. Check the po-file. It should now contain the "Cancel rating" and a single "your rating: %s, " 6. Translate those texts, and update & install the language. 7. Go to the OPAC detail page of a biblio, and check the rating texts. 8. Hovering over the rating minus -sign should show the translated "Cancel rating" 9. Check that the text after the stars is correct with and without your rating Signed-off-by: Pasi Kallinen <pasi.kallinen(a)joensuu.fi> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11827] Untranslatable "Cancel Rating" in jQuery rating plugin
by bugzilla-daemon＠bugs.koha-community.org 04 Feb '18

04 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11827 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20072] New: Fix build-git-snapshot for Debian source format quilt
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '18

03 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20072 Bug ID: 20072 Summary: Fix build-git-snapshot for Debian source format quilt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net With bug 18696 we need a few tiny changes to build-git-snapshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 18696] New: Change debian/source/format to quilt
by bugzilla-daemon＠bugs.koha-community.org 03 Feb '18

03 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18696 Bug ID: 18696 Summary: Change debian/source/format to quilt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mirko(a)abunchofthings.net QA Contact: testopia(a)bugs.koha-community.org CC: mirko(a)abunchofthings.net debian/source/format uses 'native'. As Koha is not native Debian software, and to allow Debian revision numbers like -2 in 16.05.13-2, it should be changed to 'quilt'. This is only relevant to packaging and does not affect Koha itself. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 7047] renewing serials note not visible
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047 Maksim Sen <maksim.sen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69474|0 |1 is obsolete| | --- Comment #5 from Maksim Sen <maksim.sen(a)inlibro.com> --- Created attachment 71168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71168&action=ed… Bug 7047 - Storing subscription renewal note in suggestion to be displayed on the suggestion page. Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription. Test plan: 1. Create a subscription (if one does not already exist) 2. Set the RenewSerialAddsSuggestion syspref to 'Add' 3. Renew the item making sure to write in a value into the note field 3. Visit the suggestions page and notice that the note is not displayed for the newly created suggestion 4. Apply patch 5. Repeat step 3. Notice that there is now a new branchcode dropdown box. Select one of your libraries and write in the value into the note field 6. Visit suggestions and notice there is now a 'Suggestion note' column in the table containing the note. Also note that the suggestion has the correct branchcode associated with it Sponsored-By: Catalyst IT Signed-off-by: Maksim Sen <maksim(a)inlibro.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12219] Purchase Suggestions branch level permissions
by bugzilla-daemon＠bugs.koha-community.org 02 Feb '18

02 Feb '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 Lisette <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0